From: Eric Blake <eblake@redhat.com>
To: Fam Zheng <famz@redhat.com>, qemu-devel@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>,
pbonzini@redhat.com, Markus Armbruster <armbru@redhat.com>,
Stefan Hajnoczi <stefanha@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v2 RESEND 3/4] qapi-schema: Add version info for transaction types
Date: Tue, 04 Nov 2014 17:27:12 +0100 [thread overview]
Message-ID: <5458FE60.80003@redhat.com> (raw)
In-Reply-To: <1414979247-11194-4-git-send-email-famz@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 760 bytes --]
On 11/03/2014 02:47 AM, Fam Zheng wrote:
> Signed-off-by: Fam Zheng <famz@redhat.com>
> ---
> qapi-schema.json | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/qapi-schema.json b/qapi-schema.json
> index 1ddd395..48ba583 100644
> --- a/qapi-schema.json
> +++ b/qapi-schema.json
> @@ -1256,6 +1256,8 @@
> # @transaction.
> #
> # Since 1.1
> +# drive-backup since 1.6
> +# blockdev-snapshot-internal-sync since 1.7
> # blockdev-backup since 2.3
Aha - you (almost) addressed my comment from 2/4 - you missed that abort
was also added in 1.6, alongside drive-backup.
I'd be okay if you squashed this in with 2/4.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 539 bytes --]
next prev parent reply other threads:[~2014-11-04 16:27 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-03 1:47 [Qemu-devel] [PATCH v2 RESEND 0/4] qmp: Add "blockdev-backup" Fam Zheng
2014-11-03 1:47 ` [Qemu-devel] [PATCH v2 RESEND 1/4] qmp: Add command 'blockdev-backup' Fam Zheng
2014-11-04 16:05 ` Eric Blake
2014-11-03 1:47 ` [Qemu-devel] [PATCH v2 RESEND 2/4] block: Add blockdev-backup to transaction Fam Zheng
2014-11-04 16:24 ` Eric Blake
2014-11-03 1:47 ` [Qemu-devel] [PATCH v2 RESEND 3/4] qapi-schema: Add version info for transaction types Fam Zheng
2014-11-04 16:27 ` Eric Blake [this message]
2014-11-03 1:47 ` [Qemu-devel] [PATCH v2 RESEND 4/4] qemu-iotests: Test blockdev-backup in 055 Fam Zheng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5458FE60.80003@redhat.com \
--to=eblake@redhat.com \
--cc=armbru@redhat.com \
--cc=famz@redhat.com \
--cc=kwolf@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.