From: Sven Eckelmann <sven@narfation.org>
To: The list for a Better Approach To Mobile Ad-hoc Networking
<b.a.t.m.a.n@lists.open-mesh.org>
Cc: "Linus Lüssing" <linus.luessing@c0d3.blue>
Subject: Re: [PATCH v2] batman-adv: bcast: queue per interface, if needed
Date: Fri, 14 May 2021 13:52:17 +0200 [thread overview]
Message-ID: <5459898.nmiLi0PJat@sven-desktop> (raw)
In-Reply-To: <20210514113532.GF2222@otheros>
[-- Attachment #1: Type: text/plain, Size: 1230 bytes --]
On Friday, 14 May 2021 13:35:32 CEST Linus Lüssing wrote:
> On Fri, May 14, 2021 at 10:28:53AM +0200, Sven Eckelmann wrote:
> > On Tuesday, 27 April 2021 20:45:27 CEST Linus Lüssing wrote:
> > > - * The skb is not consumed, so the caller should make sure that the
> > > - * skb is freed.
> > > + * This call clones the given skb, hence the caller needs to take into
> > > + * account that the data segment of the original skb might not be
> > > + * modifiable anymore.
> >
> > But none of your callers is now taking care of it because you've removed all
> > skb_copy's. All you do is to clone the control data and give it to the
> > underlying layers. And they may write freely to the data. Thus breaking
> > parallel (and under some circumstances sequential) running code which operates
> > on the skbs.
>
> Hi Sven,
>
> Thanks for looking at it so far. I'm not quite sure if the
> skb_copy() is needed though. Because there is a new skb_cow(). Let
> me explain my thoughts:
[...]
Haven't checked this in detail. But please split this part in a separate patch
with the corresponding explanation. Should make it easier to understand why
the skb_copy is no longer needed.
Kind regards,
Sven
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
prev parent reply other threads:[~2021-05-14 11:52 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-27 18:45 [PATCH v2] batman-adv: bcast: queue per interface, if needed Linus Lüssing
2021-05-14 8:28 ` Sven Eckelmann
2021-05-14 11:35 ` Linus Lüssing
2021-05-14 11:52 ` Sven Eckelmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5459898.nmiLi0PJat@sven-desktop \
--to=sven@narfation.org \
--cc=b.a.t.m.a.n@lists.open-mesh.org \
--cc=linus.luessing@c0d3.blue \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.