All of lore.kernel.org
 help / color / mirror / Atom feed
From: Chao Zhu <chaozhu-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org>
To: David Marchand
	<david.marchand-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>,
	dev-VfR2kkLFssw@public.gmane.org
Cc: bjzhuc-vtt25B2cwJLQT0dZR+AlfA@public.gmane.org
Subject: Re: [PATCH v3 00/10] split architecture specific operations
Date: Wed, 05 Nov 2014 10:39:56 +0800	[thread overview]
Message-ID: <54598DFC.6070006@linux.vnet.ibm.com> (raw)
In-Reply-To: <1414500657-23774-1-git-send-email-david.marchand-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>


> The set of patches split x86 architecture specific operations from DPDK and put
> them to x86 arch directory.
> This will make the adoption of DPDK much easier on other computer architecture.
> For a new architecture, just add an architecture specific directory and
> necessary building configuration files, then DPDK eal library can support it.
>
>
> Reviewing patchset from Chao, I ended up modifying it along the way,
> so here is a new iteration of this patchset.
>
> Changes since Chao v2 patchset :
>
> - added a preliminary patch for moving rte_atomic.h (for better readability)
> - fixed documentation generation
> - implemented a generic header for each arch specific header (cpuflags, memcpy,
>    prefetch were missing)
> - removed C++ stuff from generic headers
> - centralised all doxygen stuff in generic headers (no need to have duplicates)
> - refactored rte_cycles functions
> - moved vmware tsc stuff to arch rte_cycles.h headers
> - finished x86 factorisation
>
>
> Little summary of current state :
>
> - all applications continue to include the eal headers as before, these headers
>    are the arch-specific ones
> - the arch specific headers always include the generic ones. The generic headers
>    contain the doxygen documentation and code common to all architectures
> - a x86 architecture has been defined which handles both 32bits and 64bits
>    peculiarities
>
>
> It builds fine for 32/64 bits (w and w/o "force intrinsics"), but I really would
> like a lot of eyes on this (and I would say, especially, rte_cycles, rte_memcpy
> and rte_cpuflags).
> I still have some concerns about the use of intrinsics for architecture != x86
> but I think Chao will be the best to look at this.
>
>
Acked-by: Chao Zhu <bjzhuc-vtt25B2cwJLQT0dZR+AlfA@public.gmane.org>

  parent reply	other threads:[~2014-11-05  2:39 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-10-28 12:50 [PATCH v3 00/10] split architecture specific operations David Marchand
     [not found] ` <1414500657-23774-1-git-send-email-david.marchand-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
2014-10-28 12:50   ` [PATCH v3 01/10] eal: move rte_atomic.h header David Marchand
2014-10-28 12:50   ` [PATCH v3 02/10] eal: split atomic operations to architecture specific David Marchand
2014-10-28 12:50   ` [PATCH v3 03/10] eal: split byte order " David Marchand
2014-10-28 12:50   ` [PATCH v3 04/10] eal: split CPU cycle operation " David Marchand
2014-10-28 12:50   ` [PATCH v3 05/10] eal: split prefetch operations " David Marchand
2014-10-28 12:50   ` [PATCH v3 06/10] eal: split spinlock " David Marchand
2014-10-28 12:50   ` [PATCH v3 07/10] eal: split memcpy operation " David Marchand
2014-10-28 12:50   ` [PATCH v3 08/10] eal: split CPU flags operations " David Marchand
2014-10-28 12:50   ` [PATCH v3 09/10] eal: install all arch headers David Marchand
2014-10-28 12:50   ` [PATCH v3 10/10] eal: factorize x86 headers David Marchand
2014-11-03  8:10   ` [PATCH v3 00/10] split architecture specific operations Chao CH Zhu
2014-11-05  2:39   ` Chao Zhu [this message]
     [not found]     ` <54598DFC.6070006-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org>
2014-11-05 21:57       ` Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54598DFC.6070006@linux.vnet.ibm.com \
    --to=chaozhu-23vcf4htsmix0ybbhkvfkdbpr1lh4cv8@public.gmane.org \
    --cc=bjzhuc-vtt25B2cwJLQT0dZR+AlfA@public.gmane.org \
    --cc=david.marchand-pdR9zngts4EAvxtiuMwx3w@public.gmane.org \
    --cc=dev-VfR2kkLFssw@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.