From: Paolo Bonzini <pbonzini@redhat.com>
To: SeokYeon Hwang <syeon.hwang@samsung.com>, qemu-devel@nongnu.org
Cc: qemu-trivial@nongnu.org, peter.maydell@linaro.org
Subject: Re: [Qemu-trivial] [PATCH v2] translate-all: Marked map_exec() with the 'unused' attribute
Date: Wed, 05 Nov 2014 12:01:26 +0100 [thread overview]
Message-ID: <545A0386.9030109@redhat.com> (raw)
In-Reply-To: <1415002312-30827-1-git-send-email-syeon.hwang@samsung.com>
On 03/11/2014 09:11, SeokYeon Hwang wrote:
> Marked map_exec() with the 'unused' attribute to avoid '-Wunused-function' on clang 3.4 or later.
>
> Signed-off-by: SeokYeon Hwang <syeon.hwang@samsung.com>
Cc: qemu-trivial@nongnu.org
Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
> translate-all.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/translate-all.c b/translate-all.c
> index ba5c840..9d150fb 100644
> --- a/translate-all.c
> +++ b/translate-all.c
> @@ -270,14 +270,14 @@ bool cpu_restore_state(CPUState *cpu, uintptr_t retaddr)
> }
>
> #ifdef _WIN32
> -static inline void map_exec(void *addr, long size)
> +static __attribute__((unused)) void map_exec(void *addr, long size)
> {
> DWORD old_protect;
> VirtualProtect(addr, size,
> PAGE_EXECUTE_READWRITE, &old_protect);
> }
> #else
> -static inline void map_exec(void *addr, long size)
> +static __attribute__((unused)) void map_exec(void *addr, long size)
> {
> unsigned long start, end, page_size;
>
>
WARNING: multiple messages have this Message-ID (diff)
From: Paolo Bonzini <pbonzini@redhat.com>
To: SeokYeon Hwang <syeon.hwang@samsung.com>, qemu-devel@nongnu.org
Cc: qemu-trivial@nongnu.org, peter.maydell@linaro.org
Subject: Re: [Qemu-devel] [PATCH v2] translate-all: Marked map_exec() with the 'unused' attribute
Date: Wed, 05 Nov 2014 12:01:26 +0100 [thread overview]
Message-ID: <545A0386.9030109@redhat.com> (raw)
In-Reply-To: <1415002312-30827-1-git-send-email-syeon.hwang@samsung.com>
On 03/11/2014 09:11, SeokYeon Hwang wrote:
> Marked map_exec() with the 'unused' attribute to avoid '-Wunused-function' on clang 3.4 or later.
>
> Signed-off-by: SeokYeon Hwang <syeon.hwang@samsung.com>
Cc: qemu-trivial@nongnu.org
Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
> translate-all.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/translate-all.c b/translate-all.c
> index ba5c840..9d150fb 100644
> --- a/translate-all.c
> +++ b/translate-all.c
> @@ -270,14 +270,14 @@ bool cpu_restore_state(CPUState *cpu, uintptr_t retaddr)
> }
>
> #ifdef _WIN32
> -static inline void map_exec(void *addr, long size)
> +static __attribute__((unused)) void map_exec(void *addr, long size)
> {
> DWORD old_protect;
> VirtualProtect(addr, size,
> PAGE_EXECUTE_READWRITE, &old_protect);
> }
> #else
> -static inline void map_exec(void *addr, long size)
> +static __attribute__((unused)) void map_exec(void *addr, long size)
> {
> unsigned long start, end, page_size;
>
>
next prev parent reply other threads:[~2014-11-05 11:01 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-03 8:11 [Qemu-devel] [PATCH v2] translate-all: Marked map_exec() with the 'unused' attribute SeokYeon Hwang
2014-11-03 15:03 ` Peter Maydell
2014-11-05 11:01 ` Paolo Bonzini [this message]
2014-11-05 11:01 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=545A0386.9030109@redhat.com \
--to=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=syeon.hwang@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.