From: Paolo Bonzini <pbonzini@redhat.com>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: qemu-devel@nongnu.org, Markus Armbruster <armbru@redhat.com>,
SeokYeon Hwang <syeon.hwang@samsung.com>
Subject: Re: [Qemu-devel] [PATCH] pci: fixed mismatch of error-handling between pci_qdev_init() and qdev
Date: Wed, 05 Nov 2014 15:55:29 +0100 [thread overview]
Message-ID: <545A3A61.50001@redhat.com> (raw)
In-Reply-To: <20141105132815.GA4884@redhat.com>
On 05/11/2014 14:28, Michael S. Tsirkin wrote:
> > I think bypassing the question by converting to realize makes the most
> > sense...
>
> I'm fine with doing that but Markus's patches wouldn't
> yet have solved the problem by themselves since init
> is still around, right?
>
> This probably means fixing this bug can't justify
> merging the realize patchset after freeze.
Yes, I agree. I meant that the API is not very well defined. I would
handle everything else on a case-by-case basis, by reviewing each init
function that is converted to realize.
Since the patch was for an out-of-tree device, it can wait for 2.3 anyway.
Paolo
next prev parent reply other threads:[~2014-11-05 14:55 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-05 10:11 [Qemu-devel] [PATCH] pci: fixed mismatch of error-handling between pci_qdev_init() and qdev SeokYeon Hwang
2014-11-05 10:59 ` Paolo Bonzini
2014-11-05 12:46 ` Michael S. Tsirkin
2014-11-05 13:16 ` Markus Armbruster
2014-11-05 13:18 ` Paolo Bonzini
2014-11-05 13:28 ` Michael S. Tsirkin
2014-11-05 14:55 ` Paolo Bonzini [this message]
2014-11-06 2:26 ` SeokYeon Hwang
2014-11-06 9:20 ` Markus Armbruster
2014-11-06 9:26 ` Michael S. Tsirkin
2014-11-06 9:41 ` SeokYeon Hwang
2014-11-06 9:23 ` Michael S. Tsirkin
2014-11-07 4:17 ` SeokYeon Hwang
2014-11-07 7:45 ` Markus Armbruster
2014-11-10 8:24 ` SeokYeon Hwang
2014-11-10 8:50 ` Markus Armbruster
2014-11-05 13:28 ` SeokYeon Hwang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=545A3A61.50001@redhat.com \
--to=pbonzini@redhat.com \
--cc=armbru@redhat.com \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=syeon.hwang@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.