From: Leon Alrae <leon.alrae@imgtec.com>
To: "Maciej W. Rozycki" <macro@codesourcery.com>, qemu-devel@nongnu.org
Cc: Aurelien Jarno <aurelien@aurel32.net>
Subject: Re: [Qemu-devel] [PATCH] mips: Remove CONFIG_VT82C686 from non-Fulong configs
Date: Wed, 5 Nov 2014 15:24:34 +0000 [thread overview]
Message-ID: <545A4132.9090608@imgtec.com> (raw)
In-Reply-To: <alpine.DEB.1.10.1411031811300.2881@tp.orcam.me.uk>
On 03/11/2014 18:36, Maciej W. Rozycki wrote:
> Fix the regression introduced with commit
> 47934d0aadc075b05ce2d9e8a44fa6a46edd1afa [hw: move ISA bridges and
> devices to hw/isa/, configure with default-configs/], by removing
> CONFIG_VT82C686 from configurations that previously did not enable it.
> That southbridge is only available on Fulong platforms (CONFIG_FULONG)
> that are exclusively little-endian, 64-bit MIPS. Previously vt82c686.o
> was pulled explicitly with obj-$(CONFIG_FULONG).
>
> Signed-off-by: Maciej W. Rozycki <macro@codesourcery.com>
> ---
> Hi,
>
> Trivial stuff first, tougher later on. Compile-tested only, this
> addresses a regression and should be obviously correct. Please apply.
>
> Thanks,
>
> Maciej
>
> qemu-mipseb-fulong-vt82c686.diff
> Index: qemu-git-trunk/default-configs/mips-softmmu.mak
> ===================================================================
> --- qemu-git-trunk.orig/default-configs/mips-softmmu.mak 2014-03-01 02:45:51.000000000 +0000
> +++ qemu-git-trunk/default-configs/mips-softmmu.mak 2014-10-28 23:01:51.178971390 +0000
> @@ -32,6 +32,5 @@ CONFIG_G364FB=y
> CONFIG_I8259=y
> CONFIG_JAZZ_LED=y
> CONFIG_MC146818RTC=y
> -CONFIG_VT82C686=y
> CONFIG_ISA_TESTDEV=y
> CONFIG_EMPTY_SLOT=y
> Index: qemu-git-trunk/default-configs/mips64-softmmu.mak
> ===================================================================
> --- qemu-git-trunk.orig/default-configs/mips64-softmmu.mak 2014-03-01 02:45:51.000000000 +0000
> +++ qemu-git-trunk/default-configs/mips64-softmmu.mak 2014-10-28 23:02:09.678926473 +0000
> @@ -32,6 +32,5 @@ CONFIG_G364FB=y
> CONFIG_I8259=y
> CONFIG_JAZZ_LED=y
> CONFIG_MC146818RTC=y
> -CONFIG_VT82C686=y
> CONFIG_ISA_TESTDEV=y
> CONFIG_EMPTY_SLOT=y
> Index: qemu-git-trunk/default-configs/mipsel-softmmu.mak
> ===================================================================
> --- qemu-git-trunk.orig/default-configs/mipsel-softmmu.mak 2014-03-01 02:45:51.000000000 +0000
> +++ qemu-git-trunk/default-configs/mipsel-softmmu.mak 2014-10-28 23:02:26.677701438 +0000
> @@ -32,6 +32,5 @@ CONFIG_G364FB=y
> CONFIG_I8259=y
> CONFIG_JAZZ_LED=y
> CONFIG_MC146818RTC=y
> -CONFIG_VT82C686=y
> CONFIG_ISA_TESTDEV=y
> CONFIG_EMPTY_SLOT=y
>
Reviewed-by: Leon Alrae <leon.alrae@imgtec.com>
prev parent reply other threads:[~2014-11-05 15:24 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-03 18:36 [Qemu-devel] [PATCH] mips: Remove CONFIG_VT82C686 from non-Fulong configs Maciej W. Rozycki
2014-11-05 15:24 ` Leon Alrae [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=545A4132.9090608@imgtec.com \
--to=leon.alrae@imgtec.com \
--cc=aurelien@aurel32.net \
--cc=macro@codesourcery.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.