From: Jonathan Cameron <jic23@kernel.org>
To: "Ivan T. Ivanov" <iivanov@mm-sol.com>,
Peter Meerwald <pmeerw@pmeerw.net>
Cc: Hartmut Knaack <knaack.h@gmx.de>,
Lars-Peter Clausen <lars@metafoo.de>,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-msm@vger.kernel.org
Subject: Re: [PATCH v4] iio: iadc: Qualcomm SPMI PMIC current ADC driver
Date: Wed, 05 Nov 2014 16:06:00 +0000 [thread overview]
Message-ID: <545A4AE8.6070402@kernel.org> (raw)
In-Reply-To: <1415004303.407.11.camel@mm-sol.com>
On 03/11/14 08:45, Ivan T. Ivanov wrote:
>
> On Fri, 2014-10-31 at 21:48 +0100, Peter Meerwald wrote:
>>> Ivan T. Ivanov schrieb am 22.10.2014 16:13:
>>>> The current ADC is peripheral of Qualcomm SPMI PMIC chips. It has
>>>> 16 bits resolution and register space inside PMIC accessible across
>>>> SPMI bus.
>>>>
>>>> The driver registers itself through IIO interface.
>>> Pretty much there, just one question I would like to double-check: The CPU of these chips is
>> Little Endian, right?
>>> Annoyingly, you introduced a small typo in this revision, but that alone doesn't qualify for a
>> new revision. A separate patch fixing it would probably be best. See inline.
>>
>> some minor comments below
>
> Thanks, will fix them. IIO maintainers, what do you
> prefer, new version or fallow-up patch?
>
Follow up please.
> Regards,
> Ivan
> --
> To unsubscribe from this list: send the line "unsubscribe linux-iio" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
next prev parent reply other threads:[~2014-11-05 16:06 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-22 14:13 [PATCH v4] iio: iadc: Qualcomm SPMI PMIC current ADC driver Ivan T. Ivanov
2014-10-22 14:13 ` Ivan T. Ivanov
[not found] ` <1413987213-22218-1-git-send-email-iivanov-NEYub+7Iv8PQT0dZR+AlfA@public.gmane.org>
2014-10-25 20:04 ` Jonathan Cameron
2014-10-25 20:04 ` Jonathan Cameron
2014-10-31 20:13 ` Hartmut Knaack
[not found] ` <5453ED55.2000003-Mmb7MZpHnFY@public.gmane.org>
2014-10-31 20:48 ` Peter Meerwald
2014-10-31 20:48 ` Peter Meerwald
[not found] ` <alpine.DEB.2.02.1410312128100.18476-jW+XmwGofnusTnJN9+BGXg@public.gmane.org>
2014-11-03 8:45 ` Ivan T. Ivanov
2014-11-03 8:45 ` Ivan T. Ivanov
2014-11-05 16:06 ` Jonathan Cameron [this message]
2014-11-01 16:39 ` Ivan T. Ivanov
[not found] ` <1414859945.2207.1.camel-NEYub+7Iv8PQT0dZR+AlfA@public.gmane.org>
2014-11-01 19:46 ` Hartmut Knaack
2014-11-01 19:46 ` Hartmut Knaack
2014-11-03 8:41 ` Ivan T. Ivanov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=545A4AE8.6070402@kernel.org \
--to=jic23@kernel.org \
--cc=iivanov@mm-sol.com \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pmeerw@pmeerw.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.