Re: [PATCH v4] iio: iadc: Qualcomm SPMI PMIC current ADC driver

All of lore.kernel.org
 help / color / mirror / Atom feed

From: "Ivan T. Ivanov" <iivanov-NEYub+7Iv8PQT0dZR+AlfA@public.gmane.org>
To: Peter Meerwald <pmeerw-jW+XmwGofnusTnJN9+BGXg@public.gmane.org>
Cc: Hartmut Knaack <knaack.h-Mmb7MZpHnFY@public.gmane.org>,
	Jonathan Cameron <jic23-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
	Lars-Peter Clausen <lars-Qo5EllUWu/uELgA04lAiVw@public.gmane.org>,
	linux-iio-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-arm-msm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH v4] iio: iadc: Qualcomm SPMI PMIC current ADC driver
Date: Mon, 03 Nov 2014 10:45:03 +0200	[thread overview]
Message-ID: <1415004303.407.11.camel@mm-sol.com> (raw)
In-Reply-To: <alpine.DEB.2.02.1410312128100.18476-jW+XmwGofnusTnJN9+BGXg@public.gmane.org>


On Fri, 2014-10-31 at 21:48 +0100, Peter Meerwald wrote:
> > Ivan T. Ivanov schrieb am 22.10.2014 16:13:
> > > The current ADC is peripheral of Qualcomm SPMI PMIC chips. It has
> > > 16 bits resolution and register space inside PMIC accessible across
> > > SPMI bus.
> > >
> > > The driver registers itself through IIO interface.
> > Pretty much there, just one question I would like to double-check: The CPU of these chips is 
> Little Endian, right?
> > Annoyingly, you introduced a small typo in this revision, but that alone doesn't qualify for a 
> new revision. A separate patch fixing it would probably be best. See inline.
> 
> some minor comments below

Thanks, will fix them. IIO maintainers, what do you
prefer, new version or fallow-up patch?

Regards,
Ivan

WARNING: multiple messages have this Message-ID (diff)

From: "Ivan T. Ivanov" <iivanov@mm-sol.com>
To: Peter Meerwald <pmeerw@pmeerw.net>
Cc: Hartmut Knaack <knaack.h@gmx.de>,
	Jonathan Cameron <jic23@kernel.org>,
	Lars-Peter Clausen <lars@metafoo.de>,
	linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-arm-msm@vger.kernel.org
Subject: Re: [PATCH v4] iio: iadc: Qualcomm SPMI PMIC current ADC driver
Date: Mon, 03 Nov 2014 10:45:03 +0200	[thread overview]
Message-ID: <1415004303.407.11.camel@mm-sol.com> (raw)
In-Reply-To: <alpine.DEB.2.02.1410312128100.18476@pmeerw.net>


On Fri, 2014-10-31 at 21:48 +0100, Peter Meerwald wrote:
> > Ivan T. Ivanov schrieb am 22.10.2014 16:13:
> > > The current ADC is peripheral of Qualcomm SPMI PMIC chips. It has
> > > 16 bits resolution and register space inside PMIC accessible across
> > > SPMI bus.
> > >
> > > The driver registers itself through IIO interface.
> > Pretty much there, just one question I would like to double-check: The CPU of these chips is 
> Little Endian, right?
> > Annoyingly, you introduced a small typo in this revision, but that alone doesn't qualify for a 
> new revision. A separate patch fixing it would probably be best. See inline.
> 
> some minor comments below

Thanks, will fix them. IIO maintainers, what do you
prefer, new version or fallow-up patch?

Regards,
Ivan

next prev parent reply	other threads:[~2014-11-03  8:45 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-10-22 14:13 [PATCH v4] iio: iadc: Qualcomm SPMI PMIC current ADC driver Ivan T. Ivanov
2014-10-22 14:13 ` Ivan T. Ivanov
     [not found] ` <1413987213-22218-1-git-send-email-iivanov-NEYub+7Iv8PQT0dZR+AlfA@public.gmane.org>
2014-10-25 20:04   ` Jonathan Cameron
2014-10-25 20:04     ` Jonathan Cameron
2014-10-31 20:13 ` Hartmut Knaack
     [not found]   ` <5453ED55.2000003-Mmb7MZpHnFY@public.gmane.org>
2014-10-31 20:48     ` Peter Meerwald
2014-10-31 20:48       ` Peter Meerwald
     [not found]       ` <alpine.DEB.2.02.1410312128100.18476-jW+XmwGofnusTnJN9+BGXg@public.gmane.org>
2014-11-03  8:45         ` Ivan T. Ivanov [this message]
2014-11-03  8:45           ` Ivan T. Ivanov
2014-11-05 16:06           ` Jonathan Cameron
2014-11-01 16:39   ` Ivan T. Ivanov
     [not found]     ` <1414859945.2207.1.camel-NEYub+7Iv8PQT0dZR+AlfA@public.gmane.org>
2014-11-01 19:46       ` Hartmut Knaack
2014-11-01 19:46         ` Hartmut Knaack
2014-11-03  8:41         ` Ivan T. Ivanov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1415004303.407.11.camel@mm-sol.com \
    --to=iivanov-neyub+7iv8pqt0dzr+alfa@public.gmane.org \
    --cc=jic23-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
    --cc=knaack.h-Mmb7MZpHnFY@public.gmane.org \
    --cc=lars-Qo5EllUWu/uELgA04lAiVw@public.gmane.org \
    --cc=linux-arm-msm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-iio-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=pmeerw-jW+XmwGofnusTnJN9+BGXg@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Be sure your reply has a Subject: header at the top and a blank line before the message body.

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.