From: "santosh.shilimkar@oralce.com" <santosh.shilimkar@oracle.com>
To: Tony Lindgren <tony@atomide.com>, linux-omap@vger.kernel.org
Cc: linux-arm-kernel@lists.infradead.org,
Santosh Shilimkar <ssantosh@kernel.org>
Subject: Re: [PATCH 1/5] ARM: OMAP3: Fix errors for omap_l3_smx when booted with device tree
Date: Wed, 05 Nov 2014 12:16:45 -0800 [thread overview]
Message-ID: <545A85AD.3030309@oracle.com> (raw)
In-Reply-To: <1415212550-24692-2-git-send-email-tony@atomide.com>
On 11/05/2014 10:35 AM, Tony Lindgren wrote:
> When booting omap3 in device tree mode, we're currently getting
> the following errors:
>
> omap_l3_smx omap_l3_smx.0: couldn't request debug irq
> omap_l3_smx: probe of omap_l3_smx.0 failed with error -22
>
> This is because we don't have handling in the driver for the
> compatible property and instead assume platform data being
> passed.
>
> Note that this binding is already documented, and implemented
> for the related omap_l3_noc driver for omap4 and later. Looks
> like the binding somehow never got never implemented for this
> omap_l3_smx driver though.
>
> Let's also remove __exit_p to allow binding and unbinding
> of the driver while at it.
>
> Reported-by: Pavel Machek <pavel@ucw.cz>
> Reported-by: Russell King <rmk+kernel@arm.linux.org.uk>
> Cc: Santosh Shilimkar <ssantosh@kernel.org>
> Signed-off-by: Tony Lindgren <tony@atomide.com>
> ---
Acked-by: Santosh Shilimkar <ssantosh@kernel.org>
WARNING: multiple messages have this Message-ID (diff)
From: santosh.shilimkar@oracle.com (santosh.shilimkar@oralce.com)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/5] ARM: OMAP3: Fix errors for omap_l3_smx when booted with device tree
Date: Wed, 05 Nov 2014 12:16:45 -0800 [thread overview]
Message-ID: <545A85AD.3030309@oracle.com> (raw)
In-Reply-To: <1415212550-24692-2-git-send-email-tony@atomide.com>
On 11/05/2014 10:35 AM, Tony Lindgren wrote:
> When booting omap3 in device tree mode, we're currently getting
> the following errors:
>
> omap_l3_smx omap_l3_smx.0: couldn't request debug irq
> omap_l3_smx: probe of omap_l3_smx.0 failed with error -22
>
> This is because we don't have handling in the driver for the
> compatible property and instead assume platform data being
> passed.
>
> Note that this binding is already documented, and implemented
> for the related omap_l3_noc driver for omap4 and later. Looks
> like the binding somehow never got never implemented for this
> omap_l3_smx driver though.
>
> Let's also remove __exit_p to allow binding and unbinding
> of the driver while at it.
>
> Reported-by: Pavel Machek <pavel@ucw.cz>
> Reported-by: Russell King <rmk+kernel@arm.linux.org.uk>
> Cc: Santosh Shilimkar <ssantosh@kernel.org>
> Signed-off-by: Tony Lindgren <tony@atomide.com>
> ---
Acked-by: Santosh Shilimkar <ssantosh@kernel.org>
next prev parent reply other threads:[~2014-11-05 20:16 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-05 18:35 [PATCH 0/5] Few fixes for omaps to reduce bootup noise Tony Lindgren
2014-11-05 18:35 ` Tony Lindgren
2014-11-05 18:35 ` [PATCH 1/5] ARM: OMAP3: Fix errors for omap_l3_smx when booted with device tree Tony Lindgren
2014-11-05 18:35 ` Tony Lindgren
2014-11-05 20:16 ` santosh.shilimkar@oralce.com
2014-11-05 20:16 ` santosh.shilimkar@oralce.com
2014-11-05 20:16 ` santosh.shilimkar@oralce.com [this message]
2014-11-05 20:16 ` santosh.shilimkar@oralce.com
2014-11-05 18:35 ` [PATCH 2/5] ARM: dts: Fix NAND last partition size on LDP Tony Lindgren
2014-11-05 18:35 ` Tony Lindgren
2014-11-05 18:35 ` [PATCH 3/5] ARM: dts: Add twl keypad map for LDP Tony Lindgren
2014-11-05 18:35 ` Tony Lindgren
2014-11-05 18:35 ` [PATCH 4/5] " Tony Lindgren
2014-11-05 18:35 ` Tony Lindgren
2014-11-05 18:44 ` Tony Lindgren
2014-11-05 18:44 ` Tony Lindgren
2014-11-05 18:35 ` [PATCH 5/5] ARM: OMAP4+: Remove unused omap_l3_noc platform init Tony Lindgren
2014-11-05 18:35 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=545A85AD.3030309@oracle.com \
--to=santosh.shilimkar@oracle.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=ssantosh@kernel.org \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.