[PATCH] sna: Use VMask in 3DSTATE_PS

[PATCH] sna: Use VMask in 3DSTATE_PS

[Rodrigo Vivi]

Using dispatch mask cause hangs waiting PS Done on some cases like bug #83207,
with larger screen or when scaling it.

Also mesa uses VMask instead of Dmask for 3DSTATE_PS because in some cases
they were getting incorrect derivatives for subspans.

Reference: https://bugs.freedesktop.org/show_bug.cgi?id=83207
Cc: Timo Aaltonen <tjaalton@ubuntu.com>
Cc: Gary Wang <gary.c.wang@intel.com>
Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
---
 src/sna/gen8_render.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/sna/gen8_render.c b/src/sna/gen8_render.c
index d375753..ac22808 100644
--- a/src/sna/gen8_render.c
+++ b/src/sna/gen8_render.c
@@ -954,7 +954,7 @@ gen8_emit_wm(struct sna *sna, int kernel)
 	OUT_BATCH(GEN8_3DSTATE_PS | (12 - 2));
 	OUT_BATCH64(kernels[0] ?: kernels[1] ?: kernels[2]);
 	OUT_BATCH(1 << PS_SAMPLER_COUNT_SHIFT |
-		  //PS_VECTOR_MASK_ENABLE |
+		  PS_VECTOR_MASK_ENABLE |
 		  wm_kernels[kernel].num_surfaces << PS_BINDING_TABLE_ENTRY_COUNT_SHIFT);
 	OUT_BATCH64(0); /* scratch address */
 	OUT_BATCH(PS_MAX_THREADS |
-- 
1.9.3

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [PATCH] sna: Use VMask in 3DSTATE_PS

[Timo Aaltonen]

On 06.11.2014 01:48, Rodrigo Vivi wrote:
> Using dispatch mask cause hangs waiting PS Done on some cases like bug #83207,
> with larger screen or when scaling it.
> 
> Also mesa uses VMask instead of Dmask for 3DSTATE_PS because in some cases
> they were getting incorrect derivatives for subspans.
> 
> Reference: https://bugs.freedesktop.org/show_bug.cgi?id=83207
> Cc: Timo Aaltonen <tjaalton@ubuntu.com>
> Cc: Gary Wang <gary.c.wang@intel.com>
> Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com>

works great, thanks!

Tested-by: Timo Aaltonen <timo.aaltonen@canonical.com>

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [PATCH] sna: Use VMask in 3DSTATE_PS

[Chris Wilson]

On Thu, Nov 06, 2014 at 08:22:54AM +0200, Timo Aaltonen wrote:
> On 06.11.2014 01:48, Rodrigo Vivi wrote:
> > Using dispatch mask cause hangs waiting PS Done on some cases like bug #83207,
> > with larger screen or when scaling it.
> > 
> > Also mesa uses VMask instead of Dmask for 3DSTATE_PS because in some cases
> > they were getting incorrect derivatives for subspans.
> > 
> > Reference: https://bugs.freedesktop.org/show_bug.cgi?id=83207
> > Cc: Timo Aaltonen <tjaalton@ubuntu.com>
> > Cc: Gary Wang <gary.c.wang@intel.com>
> > Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
> 
> works great, thanks!
> 
> Tested-by: Timo Aaltonen <timo.aaltonen@canonical.com>

Thanks for finding that and testing,
Pushed.
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx