From: Chris Friesen <chris.friesen@windriver.com>
To: "Martin K. Petersen" <martin.petersen@oracle.com>
Cc: Jens Axboe <axboe@kernel.dk>, lkml <linux-kernel@vger.kernel.org>,
linux-scsi@vger.kernel.org, Mike Snitzer <snitzer@redhat.com>
Subject: Re: absurdly high "optimal_io_size" on Seagate SAS disk
Date: Thu, 6 Nov 2014 13:14:18 -0600 [thread overview]
Message-ID: <545BC88A.7060706@windriver.com> (raw)
In-Reply-To: <yq1fvdwb3lq.fsf@sermon.lab.mkp.net>
On 11/06/2014 12:12 PM, Martin K. Petersen wrote:
>>>>>> "Chris" == Chris Friesen <chris.friesen@windriver.com>
>>>>>> writes:
>
> Chris> That'd work, but is it the best way to go? I mean, I found
> one Chris> report of a similar problem on an SSD (model number
> unknown). In Chris> that case it was a near-UINT_MAX value as well.
>
> My concern is still the same. Namely that this particular drive
> happens to be returning UINT_MAX but it might as well be a value
> that's entirely random. Or even a value that is small and innocuous
> looking but completely wrong.
>
> Chris> The problem with the blacklist is that until someone patches
> it, Chris> the drive is broken. And then it stays blacklisted even
> if the Chris> firmware gets fixed.
>
> Well, you can manually blacklist in /proc/scsi/device_info.
>
> Chris> I'm wondering if it might not be better to just ignore all
> values Chris> larger than X (where X is whatever we think is the
> largest Chris> conceivable reasonable value).
>
> The problem is that finding that is not easy and it too will be a
> moving target.
Do we need to be perfect, or just "good enough"?
For a RAID card I expect it would be related to chunk size or stripe
width or something...but even then I would expect to be able to cap it
at 100MB or so. Or are there storage systems on really fast interfaces
that could legitimately want a hundred meg of data at a time?
On 11/06/2014 12:15 PM, Jens Axboe wrote:
> Didn't check, but assuming the value is the upper 24 bits of 32. If
> so, might not hurt to check for as 0xfffffe00 as an invalid value.
Yep, in all three wonky cases so far "optimal_io_size" ended up as
4294966784, which is 0xfffffe00. Does something mask out the lower bits?
Chris
WARNING: multiple messages have this Message-ID (diff)
From: Chris Friesen <chris.friesen@windriver.com>
To: "Martin K. Petersen" <martin.petersen@oracle.com>
Cc: Jens Axboe <axboe@kernel.dk>, lkml <linux-kernel@vger.kernel.org>,
<linux-scsi@vger.kernel.org>, Mike Snitzer <snitzer@redhat.com>
Subject: Re: absurdly high "optimal_io_size" on Seagate SAS disk
Date: Thu, 6 Nov 2014 13:14:18 -0600 [thread overview]
Message-ID: <545BC88A.7060706@windriver.com> (raw)
In-Reply-To: <yq1fvdwb3lq.fsf@sermon.lab.mkp.net>
On 11/06/2014 12:12 PM, Martin K. Petersen wrote:
>>>>>> "Chris" == Chris Friesen <chris.friesen@windriver.com>
>>>>>> writes:
>
> Chris> That'd work, but is it the best way to go? I mean, I found
> one Chris> report of a similar problem on an SSD (model number
> unknown). In Chris> that case it was a near-UINT_MAX value as well.
>
> My concern is still the same. Namely that this particular drive
> happens to be returning UINT_MAX but it might as well be a value
> that's entirely random. Or even a value that is small and innocuous
> looking but completely wrong.
>
> Chris> The problem with the blacklist is that until someone patches
> it, Chris> the drive is broken. And then it stays blacklisted even
> if the Chris> firmware gets fixed.
>
> Well, you can manually blacklist in /proc/scsi/device_info.
>
> Chris> I'm wondering if it might not be better to just ignore all
> values Chris> larger than X (where X is whatever we think is the
> largest Chris> conceivable reasonable value).
>
> The problem is that finding that is not easy and it too will be a
> moving target.
Do we need to be perfect, or just "good enough"?
For a RAID card I expect it would be related to chunk size or stripe
width or something...but even then I would expect to be able to cap it
at 100MB or so. Or are there storage systems on really fast interfaces
that could legitimately want a hundred meg of data at a time?
On 11/06/2014 12:15 PM, Jens Axboe wrote:
> Didn't check, but assuming the value is the upper 24 bits of 32. If
> so, might not hurt to check for as 0xfffffe00 as an invalid value.
Yep, in all three wonky cases so far "optimal_io_size" ended up as
4294966784, which is 0xfffffe00. Does something mask out the lower bits?
Chris
next prev parent reply other threads:[~2014-11-06 19:14 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-06 16:47 absurdly high "optimal_io_size" on Seagate SAS disk Chris Friesen
2014-11-06 17:16 ` Chris Friesen
2014-11-06 17:16 ` Chris Friesen
2014-11-06 17:34 ` Martin K. Petersen
2014-11-06 17:34 ` Martin K. Petersen
2014-11-06 17:45 ` Chris Friesen
2014-11-06 17:45 ` Chris Friesen
2014-11-06 18:12 ` Martin K. Petersen
2014-11-06 18:12 ` Martin K. Petersen
2014-11-06 18:15 ` Jens Axboe
2014-11-06 19:14 ` Chris Friesen [this message]
2014-11-06 19:14 ` Chris Friesen
2014-11-07 1:56 ` Martin K. Petersen
2014-11-07 1:56 ` Martin K. Petersen
2014-11-07 5:35 ` Chris Friesen
2014-11-07 5:35 ` Chris Friesen
2014-11-07 15:18 ` Dale R. Worley
2014-11-07 16:25 ` Martin K. Petersen
2014-11-07 16:25 ` Martin K. Petersen
2014-11-07 17:42 ` Martin K. Petersen
2014-11-07 17:42 ` Martin K. Petersen
2014-11-07 17:51 ` Chris Friesen
2014-11-07 17:51 ` Chris Friesen
2014-11-07 18:03 ` Martin K. Petersen
2014-11-07 18:03 ` Martin K. Petersen
2014-11-07 18:48 ` Chris Friesen
2014-11-07 18:48 ` Chris Friesen
2014-11-07 19:17 ` Martin K. Petersen
2014-11-07 19:17 ` Martin K. Petersen
2014-11-07 21:04 ` Chris Friesen
2014-11-07 21:04 ` Chris Friesen
2014-11-07 17:10 ` Elliott, Robert (Server Storage)
2014-11-07 17:40 ` Martin K. Petersen
2014-11-07 17:40 ` Martin K. Petersen
2014-11-07 20:15 ` Douglas Gilbert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=545BC88A.7060706@windriver.com \
--to=chris.friesen@windriver.com \
--cc=axboe@kernel.dk \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=snitzer@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.