From: Paolo Bonzini <pbonzini@redhat.com>
To: kvm-ia64@vger.kernel.org
Subject: Re: [PATCH v13 6/7] arm: KVM: dirty log read write protect support
Date: Sat, 08 Nov 2014 07:28:50 +0000 [thread overview]
Message-ID: <545DC632.6020002@redhat.com> (raw)
In-Reply-To: <1415320848-13813-7-git-send-email-m.smarduch@samsung.com>
On 07/11/2014 20:47, Mario Smarduch wrote:
>> That can happen if the error occurred in the final
>> copy to userspace, after page tables have been modified.
>
> Upon error return userspace should terminate logging, error out whether
> used for migration or other use cases, with some stale spte TLBs cached
> read/write, which doesn't appear to be harmful.
Fair enough; for x86 I elected to always do the TLB flush, but you can
do it differently. Perhaps add a comment with the above paragraph, thouhg.
> But you mention 'final copy' which makes me think I'm missing something?
I meant final copy before leaving the function.
Paolo
WARNING: multiple messages have this Message-ID (diff)
From: Paolo Bonzini <pbonzini@redhat.com>
To: Mario Smarduch <m.smarduch@samsung.com>
Cc: james.hogan@imgtec.com, christoffer.dall@linaro.org,
agraf@suse.de, marc.zyngier@arm.com, cornelia.huck@de.ibm.com,
borntraeger@de.ibm.com, catalin.marinas@arm.com,
kvmarm@lists.cs.columbia.edu, kvm@vger.kernel.org,
kvm-ppc@vger.kernel.org, kvm-ia64@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, steve.capper@arm.com,
peter.maydell@linaro.org
Subject: Re: [PATCH v13 6/7] arm: KVM: dirty log read write protect support
Date: Sat, 08 Nov 2014 07:28:50 +0000 [thread overview]
Message-ID: <545DC632.6020002@redhat.com> (raw)
In-Reply-To: <545D21BE.2020203@samsung.com>
On 07/11/2014 20:47, Mario Smarduch wrote:
>> That can happen if the error occurred in the final
>> copy to userspace, after page tables have been modified.
>
> Upon error return userspace should terminate logging, error out whether
> used for migration or other use cases, with some stale spte TLBs cached
> read/write, which doesn't appear to be harmful.
Fair enough; for x86 I elected to always do the TLB flush, but you can
do it differently. Perhaps add a comment with the above paragraph, thouhg.
> But you mention 'final copy' which makes me think I'm missing something?
I meant final copy before leaving the function.
Paolo
WARNING: multiple messages have this Message-ID (diff)
From: pbonzini@redhat.com (Paolo Bonzini)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v13 6/7] arm: KVM: dirty log read write protect support
Date: Sat, 08 Nov 2014 08:28:50 +0100 [thread overview]
Message-ID: <545DC632.6020002@redhat.com> (raw)
In-Reply-To: <545D21BE.2020203@samsung.com>
On 07/11/2014 20:47, Mario Smarduch wrote:
>> That can happen if the error occurred in the final
>> copy to userspace, after page tables have been modified.
>
> Upon error return userspace should terminate logging, error out whether
> used for migration or other use cases, with some stale spte TLBs cached
> read/write, which doesn't appear to be harmful.
Fair enough; for x86 I elected to always do the TLB flush, but you can
do it differently. Perhaps add a comment with the above paragraph, thouhg.
> But you mention 'final copy' which makes me think I'm missing something?
I meant final copy before leaving the function.
Paolo
WARNING: multiple messages have this Message-ID (diff)
From: Paolo Bonzini <pbonzini@redhat.com>
To: Mario Smarduch <m.smarduch@samsung.com>
Cc: james.hogan@imgtec.com, christoffer.dall@linaro.org,
agraf@suse.de, marc.zyngier@arm.com, cornelia.huck@de.ibm.com,
borntraeger@de.ibm.com, catalin.marinas@arm.com,
kvmarm@lists.cs.columbia.edu, kvm@vger.kernel.org,
kvm-ppc@vger.kernel.org, kvm-ia64@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, steve.capper@arm.com,
peter.maydell@linaro.org
Subject: Re: [PATCH v13 6/7] arm: KVM: dirty log read write protect support
Date: Sat, 08 Nov 2014 08:28:50 +0100 [thread overview]
Message-ID: <545DC632.6020002@redhat.com> (raw)
In-Reply-To: <545D21BE.2020203@samsung.com>
On 07/11/2014 20:47, Mario Smarduch wrote:
>> That can happen if the error occurred in the final
>> copy to userspace, after page tables have been modified.
>
> Upon error return userspace should terminate logging, error out whether
> used for migration or other use cases, with some stale spte TLBs cached
> read/write, which doesn't appear to be harmful.
Fair enough; for x86 I elected to always do the TLB flush, but you can
do it differently. Perhaps add a comment with the above paragraph, thouhg.
> But you mention 'final copy' which makes me think I'm missing something?
I meant final copy before leaving the function.
Paolo
next prev parent reply other threads:[~2014-11-08 7:28 UTC|newest]
Thread overview: 113+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-07 0:40 [PATCH v13 6/7] arm: KVM: dirty log read write protect support Mario Smarduch
2014-11-07 0:40 ` Mario Smarduch
2014-11-07 0:40 ` Mario Smarduch
2014-11-07 0:40 ` Mario Smarduch
2014-11-07 7:38 ` Paolo Bonzini
2014-11-07 7:38 ` Paolo Bonzini
2014-11-07 7:38 ` Paolo Bonzini
2014-11-07 7:38 ` Paolo Bonzini
2014-11-07 10:19 ` Marc Zyngier
2014-11-07 10:19 ` Marc Zyngier
2014-11-07 10:19 ` Marc Zyngier
2014-11-07 19:47 ` Mario Smarduch
2014-11-07 19:47 ` Mario Smarduch
2014-11-07 19:47 ` Mario Smarduch
2014-11-07 19:47 ` Mario Smarduch
2014-11-08 7:28 ` Paolo Bonzini [this message]
2014-11-08 7:28 ` Paolo Bonzini
2014-11-08 7:28 ` Paolo Bonzini
2014-11-08 7:28 ` Paolo Bonzini
-- strict thread matches above, loose matches on Subject: below --
2014-11-07 0:40 [PATCH v13 7/7] arm: KVM: ARMv7 dirty page logging 2nd stage page fault Mario Smarduch
2014-11-07 0:40 ` Mario Smarduch
2014-11-07 0:40 ` Mario Smarduch
2014-11-07 0:40 ` Mario Smarduch
2014-11-07 10:33 ` Marc Zyngier
2014-11-07 10:33 ` Marc Zyngier
2014-11-07 10:33 ` Marc Zyngier
2014-11-07 10:33 ` Marc Zyngier
2014-11-07 19:21 ` Mario Smarduch
2014-11-07 19:21 ` Mario Smarduch
2014-11-07 19:21 ` Mario Smarduch
2014-11-07 19:21 ` Mario Smarduch
2014-11-07 0:40 [PATCH v13 5/7] arm: KVM: Add initial dirty page locking infrastructure Mario Smarduch
2014-11-07 0:40 ` Mario Smarduch
2014-11-07 0:40 ` Mario Smarduch
2014-11-07 0:40 ` Mario Smarduch
2014-11-07 10:15 ` Marc Zyngier
2014-11-07 10:15 ` Marc Zyngier
2014-11-07 10:15 ` Marc Zyngier
2014-11-07 10:15 ` Marc Zyngier
2014-11-07 19:07 ` Mario Smarduch
2014-11-07 19:07 ` Mario Smarduch
2014-11-07 19:07 ` Mario Smarduch
2014-11-07 19:07 ` Mario Smarduch
2014-11-07 0:40 [PATCH v13 4/7] arm: KVM: Add ARMv7 API to flush TLBs Mario Smarduch
2014-11-07 0:40 ` Mario Smarduch
2014-11-07 0:40 ` Mario Smarduch
2014-11-07 0:40 ` Mario Smarduch
2014-11-07 9:44 ` Marc Zyngier
2014-11-07 9:44 ` Marc Zyngier
2014-11-07 9:44 ` Marc Zyngier
2014-11-07 18:58 ` Mario Smarduch
2014-11-07 18:58 ` Mario Smarduch
2014-11-07 18:58 ` Mario Smarduch
2014-11-07 18:58 ` Mario Smarduch
2014-11-07 20:18 ` Christoffer Dall
2014-11-07 20:18 ` Christoffer Dall
2014-11-07 20:18 ` Christoffer Dall
2014-11-07 20:18 ` Christoffer Dall
2014-11-07 20:46 ` Mario Smarduch
2014-11-07 20:46 ` Mario Smarduch
2014-11-07 20:46 ` Mario Smarduch
2014-11-07 20:46 ` Mario Smarduch
2014-11-07 0:40 [PATCH v13 3/7] KVM: x86: flush TLBs last before returning from KVM_GET_DIRTY_LOG Mario Smarduch
2014-11-07 0:40 ` Mario Smarduch
2014-11-07 0:40 ` Mario Smarduch
2014-11-07 0:40 ` Mario Smarduch
2014-11-07 7:44 ` Paolo Bonzini
2014-11-07 7:44 ` Paolo Bonzini
2014-11-07 7:44 ` Paolo Bonzini
2014-11-07 7:44 ` Paolo Bonzini
2014-11-07 19:50 ` Mario Smarduch
2014-11-07 19:50 ` Mario Smarduch
2014-11-07 19:50 ` Mario Smarduch
2014-11-07 19:50 ` Mario Smarduch
2014-11-07 20:02 ` Christoffer Dall
2014-11-07 20:02 ` Christoffer Dall
2014-11-07 20:02 ` Christoffer Dall
2014-11-07 20:02 ` Christoffer Dall
2014-11-07 20:44 ` Mario Smarduch
2014-11-07 20:44 ` Mario Smarduch
2014-11-07 20:44 ` Mario Smarduch
2014-11-07 20:44 ` Mario Smarduch
2014-11-07 21:07 ` Christoffer Dall
2014-11-07 21:07 ` Christoffer Dall
2014-11-07 21:07 ` Christoffer Dall
2014-11-07 21:07 ` Christoffer Dall
2014-11-07 0:40 [PATCH v13 2/7] KVM: Add generic support for dirty page logging Mario Smarduch
2014-11-07 0:40 ` Mario Smarduch
2014-11-07 0:40 ` Mario Smarduch
2014-11-07 0:40 ` Mario Smarduch
2014-11-07 9:07 ` Cornelia Huck
2014-11-07 9:07 ` Cornelia Huck
2014-11-07 9:07 ` Cornelia Huck
2014-11-07 9:07 ` Cornelia Huck
2014-11-07 9:26 ` Paolo Bonzini
2014-11-07 9:26 ` Paolo Bonzini
2014-11-07 9:26 ` Paolo Bonzini
2014-11-07 9:26 ` Paolo Bonzini
2014-11-07 18:55 ` Mario Smarduch
2014-11-07 18:55 ` Mario Smarduch
2014-11-07 18:55 ` Mario Smarduch
2014-11-07 18:55 ` Mario Smarduch
2014-11-07 0:40 [PATCH v13 1/7] KVM: Add architecture-defined TLB flush support Mario Smarduch
2014-11-07 0:40 ` Mario Smarduch
2014-11-07 0:40 ` Mario Smarduch
2014-11-07 0:40 ` Mario Smarduch
2014-11-07 9:39 ` Marc Zyngier
2014-11-07 9:39 ` Marc Zyngier
2014-11-07 9:39 ` Marc Zyngier
2014-11-07 0:40 [PATCH v13 0/7] KVM/arm/x86: dirty page logging support for ARMv7 (3.17.0-rc1) Mario Smarduch
2014-11-07 0:40 ` Mario Smarduch
2014-11-07 0:40 ` Mario Smarduch
2014-11-07 0:40 ` Mario Smarduch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=545DC632.6020002@redhat.com \
--to=pbonzini@redhat.com \
--cc=kvm-ia64@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.