From: Vlastimil Babka <vbabka@suse.cz>
To: "P. Christeas" <xrg@linux.gr>,
Hillf Danton <hillf.zj@alibaba-inc.com>,
linux-kernel <linux-kernel@vger.kernel.org>
Cc: linux-mm@kvack.org
Subject: Re: Early test: hangs in mm/compact.c w. Linus's 12d7aacab56e9ef185c
Date: Sun, 09 Nov 2014 10:35:18 +0100 [thread overview]
Message-ID: <545F3556.5000802@suse.cz> (raw)
In-Reply-To: <1433036.WjB5pb09Zh@xorhgos3.pefnos>
On 11/09/2014 09:22 AM, P. Christeas wrote:
> On Sunday 09 November 2014, Hillf Danton wrote:
>> - return COMPACT_CONTINUE;
>> + return COMPACT_SKIPPED;
>
> I guess this one would mitigate against Vlastmil's migration scanner issue,
> wouldn't it?
Please no, that's a wrong fix. The purpose of compaction is to make the
high-order watermark meet, not give up.
> In that case, I should wait a bit[1] to try the first patch, then revert, try
> yours and (hopefully) have some results.
I hope my patch will be enough,
> Then, apply both.
>
> [1] trying to push the vm by loading memory-hungry apps and random load.
Maybe the tools/testing/selftests/vm/transhuge-stress could help
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: Vlastimil Babka <vbabka@suse.cz>
To: "P. Christeas" <xrg@linux.gr>,
Hillf Danton <hillf.zj@alibaba-inc.com>,
linux-kernel <linux-kernel@vger.kernel.org>
Cc: linux-mm@kvack.org
Subject: Re: Early test: hangs in mm/compact.c w. Linus's 12d7aacab56e9ef185c
Date: Sun, 09 Nov 2014 10:35:18 +0100 [thread overview]
Message-ID: <545F3556.5000802@suse.cz> (raw)
In-Reply-To: <1433036.WjB5pb09Zh@xorhgos3.pefnos>
On 11/09/2014 09:22 AM, P. Christeas wrote:
> On Sunday 09 November 2014, Hillf Danton wrote:
>> - return COMPACT_CONTINUE;
>> + return COMPACT_SKIPPED;
>
> I guess this one would mitigate against Vlastmil's migration scanner issue,
> wouldn't it?
Please no, that's a wrong fix. The purpose of compaction is to make the
high-order watermark meet, not give up.
> In that case, I should wait a bit[1] to try the first patch, then revert, try
> yours and (hopefully) have some results.
I hope my patch will be enough,
> Then, apply both.
>
> [1] trying to push the vm by loading memory-hungry apps and random load.
Maybe the tools/testing/selftests/vm/transhuge-stress could help
next prev parent reply other threads:[~2014-11-09 9:35 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-09 4:47 Early test: hangs in mm/compact.c w. Linus's 12d7aacab56e9ef185c Hillf Danton
2014-11-09 4:47 ` Hillf Danton
2014-11-09 8:22 ` P. Christeas
2014-11-09 8:22 ` P. Christeas
2014-11-09 9:35 ` Vlastimil Babka [this message]
2014-11-09 9:35 ` Vlastimil Babka
2014-11-10 3:23 ` Hillf Danton
2014-11-10 3:23 ` Hillf Danton
-- strict thread matches above, loose matches on Subject: below --
2014-11-04 7:26 P. Christeas
2014-11-04 8:55 ` Vlastimil Babka
2014-11-04 8:55 ` Vlastimil Babka
2014-11-04 9:36 ` P. Christeas
2014-11-05 15:26 ` Vlastimil Babka
2014-11-05 15:26 ` Vlastimil Babka
2014-11-05 16:02 ` P. Christeas
2014-11-05 16:02 ` P. Christeas
2014-11-06 19:23 ` P. Christeas
2014-11-06 21:38 ` Vlastimil Babka
2014-11-06 21:38 ` Vlastimil Babka
2014-11-08 13:11 ` P. Christeas
2014-11-08 22:18 ` Vlastimil Babka
2014-11-08 22:18 ` Vlastimil Babka
2014-11-09 8:27 ` Pavel Machek
2014-11-09 9:43 ` Vlastimil Babka
2014-11-09 9:43 ` Vlastimil Babka
2014-11-09 22:32 ` Norbert Preining
2014-11-09 22:32 ` Norbert Preining
2014-11-10 6:07 ` Joonsoo Kim
2014-11-10 6:07 ` Joonsoo Kim
2014-11-10 7:53 ` Vlastimil Babka
2014-11-10 7:53 ` Vlastimil Babka
2014-11-10 8:05 ` Joonsoo Kim
2014-11-10 8:05 ` Joonsoo Kim
2014-11-10 8:14 ` P. Christeas
2014-11-10 8:14 ` P. Christeas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=545F3556.5000802@suse.cz \
--to=vbabka@suse.cz \
--cc=hillf.zj@alibaba-inc.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=xrg@linux.gr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.