From: Joao Eduardo Luis <joao@redhat.com>
To: Loic Dachary <loic@dachary.org>,
Ceph Development <ceph-devel@vger.kernel.org>
Subject: Re: Pull requests : speed up the reviews
Date: Sun, 09 Nov 2014 12:08:30 +0000 [thread overview]
Message-ID: <545F593E.9010608@redhat.com> (raw)
In-Reply-To: <545E53B5.3070600@dachary.org>
On 11/08/2014 05:32 PM, Loic Dachary wrote:
> Hi Ceph,
>
> In the past few weeks the number of pending pull requests grew from around 20 to over 80. The good thing is that there are more contributions, the problem is that it requires more reviewers. Ceph is not the only project suffering from this kind of problem and attending the OpenStack summit last week reminded me that the sooner it is addressed the better.
>
> After a few IRC discussions some ideas came up and my favorite is that every developer paid full time to work on Ceph dedicates a daily 15 minutes time slot, time boxed, to review pull requests. Timeboxing is kind of frustrating because some reviews require more. It basically means one has to focus on the pull request for ten minutes at most and take five minutes to write a useful comment that helps the author moving forward. But it also is the only way to make room for a daily activity with no risk of postponing it because something more urgent came up.
>
> What do you think ?
On my calendar, I do have a time slot of one hour each morning to review
pull requests and mailing lists but I seldom honor it, especially when
I'm caught up in other stuff.
I'll move it over to lunch so that it has no chance in interfering with
other tasks and try to make a habit of it.
It would also be interesting to see more community involvement. I
believe it would be healthy for the project if we could have (at least)
a portion of reviews being performed by other people besides solely the
paid developers/maintainers.
-Joao
--
Joao Eduardo Luis
Software Engineer | http://ceph.com
next prev parent reply other threads:[~2014-11-09 12:08 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-08 17:32 Pull requests : speed up the reviews Loic Dachary
2014-11-09 12:08 ` Joao Eduardo Luis [this message]
2014-11-10 5:10 ` David Zafman
2014-11-10 19:07 ` Gregory Farnum
2014-11-10 19:17 ` Sage Weil
2014-11-10 19:50 ` Loic Dachary
2014-11-10 21:03 ` Gregory Farnum
2014-11-11 18:07 ` Sage Weil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=545F593E.9010608@redhat.com \
--to=joao@redhat.com \
--cc=ceph-devel@vger.kernel.org \
--cc=loic@dachary.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.