Re: Pull requests : speed up the reviews

[Loic Dachary <loic@dachary.org>]

[-- Attachment #1: Type: text/plain, Size: 2210 bytes --]

Hi Greg,

> On Mon, 10 Nov 2014, Gregory Farnum wrote:
>> I suppose one way of handling this might be to ask everybody to
>> dedicate a small amount of time to reviews (as you suggest), but to
>> emphasize PR management as much as doing the actual review.
>>
>> 1) If you don't have assigned PRs, look at the unassigned PRs from
>> oldest to newest, and based on the target area assign it to the person
>> you think most appropriate.after doing basic due diligence for issues
>> that you can handle (ie, the feature is something you don't know is
>> inappropriate; skimming the code doesn't make you cry; etc)
>>
>> 2) Manage any reviews assigned to you:
>>   2a) if you're the wrong target, assign it to somebody more appropriate
>>   2b) If you're the right target but are trying to get somebody else
>> acquainted with the code base, maybe assign it to them
>>   2c) assign priorities based on importance and age
>>
>> 3) review PRs in appropriate order at the level they deserve, and then
>> either merge or assign it back to the author

I'll do as you suggest.

>> In particular, this clearly assigns responsibility for a PR to an
>> individual. It lets people offload as necessary, and gives feedback to
>> contributors quickly even if that feedback is just "we appreciate your
>> submission and it is in somebody's queue". It lets people contribute
>> to the PR process even if there isn't something they feel qualified to
>> review directly. And it doesn't emphasize the time spent reviewing so
>> much as the act of moving a PR through the stages of merging. (A
>> 15-minute timebox might sound great, but trust me we have lots of PRs
>> that would never make it into the code base if they were done in
>> 15-minute chunks.)

I see what you mean. However there are few pull requests of that kind in the queue, or am I understimating most of them ?

>> Obviously this is also not a very formal process, but I think maybe if
>> we start approaching things this way it will help move stuff through
>> the pipeline faster. Based on Sage's sudden enthusiasm for assigning
>> PR owners I think he might agree...?

+1

-- 
Loïc Dachary, Artisan Logiciel Libre


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 263 bytes --]