All of lore.kernel.org
 help / color / mirror / Atom feed
From: hdegoede@redhat.com (Hans de Goede)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: dts: sunxi: Banana Pi: increase startup-delay for the GMAC PHY regulator
Date: Sun, 09 Nov 2014 22:05:26 +0100	[thread overview]
Message-ID: <545FD716.5060305@redhat.com> (raw)
In-Reply-To: <1415539714-7652-2-git-send-email-merker@debian.org>

Hi,

On 11/09/2014 02:28 PM, Karsten Merker wrote:
> On the LeMaker Banana Pi, probing the external ethernet PHY connected
> to the SoC's internal GMAC module sometimes fails.  The PHY power
> supply is handled via a GPIO-controlled regulator, and the existing
> regulator startup-delay of 50000us is too short to make sure that the
> PHY is always fully powered up when it is queried by phylib.  To
> guarantee a reliable PHY detection, the startup-delay has to be
> increased to 60000us.

We should probably just increase it to 100000us to be safe, otherwise:

Acked-by: Hans de Goede <hdegoede@redhat.com>

Regards,

Hans

WARNING: multiple messages have this Message-ID (diff)
From: Hans de Goede <hdegoede-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
To: Karsten Merker <merker-8fiUuRrzOP0dnm+yROfE0A@public.gmane.org>,
	Maxime Ripard
	<maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>,
	Ian Campbell
	<ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org>
Cc: linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
	devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	dev-3kdeTeqwOZ9EV1b7eY7vFQ@public.gmane.org
Subject: Re: [PATCH] ARM: dts: sunxi: Banana Pi: increase startup-delay for the GMAC PHY regulator
Date: Sun, 09 Nov 2014 22:05:26 +0100	[thread overview]
Message-ID: <545FD716.5060305@redhat.com> (raw)
In-Reply-To: <1415539714-7652-2-git-send-email-merker-8fiUuRrzOP0dnm+yROfE0A@public.gmane.org>

Hi,

On 11/09/2014 02:28 PM, Karsten Merker wrote:
> On the LeMaker Banana Pi, probing the external ethernet PHY connected
> to the SoC's internal GMAC module sometimes fails.  The PHY power
> supply is handled via a GPIO-controlled regulator, and the existing
> regulator startup-delay of 50000us is too short to make sure that the
> PHY is always fully powered up when it is queried by phylib.  To
> guarantee a reliable PHY detection, the startup-delay has to be
> increased to 60000us.

We should probably just increase it to 100000us to be safe, otherwise:

Acked-by: Hans de Goede <hdegoede-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>

Regards,

Hans

  reply	other threads:[~2014-11-09 21:05 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-11-09 13:28 [PATCH] ARM: dts: Fix failing ethernet PHY detection on the LeMaker Banana Pi Karsten Merker
2014-11-09 13:28 ` Karsten Merker
2014-11-09 13:28 ` [PATCH] ARM: dts: sunxi: Banana Pi: increase startup-delay for the GMAC PHY regulator Karsten Merker
2014-11-09 13:28   ` Karsten Merker
2014-11-09 21:05   ` Hans de Goede [this message]
2014-11-09 21:05     ` Hans de Goede
2014-11-11 17:34     ` Maxime Ripard
2014-11-11 17:34       ` Maxime Ripard
2014-11-11 18:35       ` Hans de Goede
2014-11-11 18:35         ` Hans de Goede
2014-11-11 23:01 ` [PATCH V2 0/1] ARM: dts: Fix failing ethernet PHY detection on the LeMaker Banana Pi Karsten Merker
2014-11-11 23:01   ` Karsten Merker
2014-11-11 23:01   ` [PATCH V2 1/1] ARM: dts: sunxi: Banana Pi: increase startup-delay for the GMAC PHY regulator Karsten Merker
2014-11-11 23:01     ` Karsten Merker
2014-11-12 13:37     ` Maxime Ripard
2014-11-12 13:37       ` Maxime Ripard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=545FD716.5060305@redhat.com \
    --to=hdegoede@redhat.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.