From: Zubair Lutfullah Kakakhel <Zubair.Kakakhel@imgtec.com>
To: Andy Yan <andy.yan@rock-chips.com>,
airlied@linux.ie, heiko@sntech.de, fabio.estevam@freescale.com,
rmk+kernel@arm.linux.org.uk
Cc: devel@driverdev.osuosl.org, devicetree@vger.kernel.org,
Arnd Bergmann <arnd@arndb.de>, Josh Boyer <jwboyer@redhat.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
Inki Dae <inki.dae@samsung.com>,
linux-rockchip@lists.infradead.org,
Rob Herring <robh+dt@kernel.org>,
Sean Paul <seanpaul@chromium.org>,
djkurtz@google.com, Philipp Zabel <p.zabel@pengutronix.de>,
ykk@rock-chips.com, Grant Likely <grant.likely@linaro.org>,
Dave Airlie <airlied@redhat.com>,
Shawn Guo <shawn.guo@linaro.org>,
jay.xu@rock-chips.com, Lucas Stach <l.stach@pengutronix.de>
Subject: Re: [PATCH V5 3/7] dw-hdmi: make checkpatch happy
Date: Mon, 10 Nov 2014 09:22:13 +0000 [thread overview]
Message-ID: <546083C5.8060502@imgtec.com> (raw)
In-Reply-To: <1415424598-7533-1-git-send-email-andy.yan@rock-chips.com>
Hi Andy,
In 3.18 rc4, I cannot find checkpatch errors in imx-hdmi.c
Have these errors come during the previous 2 patches.
If yes, then these changes need to be squashed into the previous
patches. No patch should add a checkpatch error and then fix it in a later patch.
Regards
ZubairLK
On 08/11/14 05:29, Andy Yan wrote:
> CHECK: Alignment should match open parenthesis
> + if ((hdmi->vic == 10) || (hdmi->vic == 11) ||
> + (hdmi->vic == 12) || (hdmi->vic == 13) ||
>
> CHECK: braces {} should be used on all arms of this statement
> + if (hdmi->hdmi_data.video_mode.mdvi)
> [...]
> + else {
> [...]
>
> Signed-off-by: Andy Yan <andy.yan@rock-chips.com>
> ---
> drivers/gpu/drm/bridge/dw_hdmi.c | 97 ++++++++++++++++++++--------------------
> 1 file changed, 48 insertions(+), 49 deletions(-)
WARNING: multiple messages have this Message-ID (diff)
From: Zubair Lutfullah Kakakhel <Zubair.Kakakhel@imgtec.com>
To: Andy Yan <andy.yan@rock-chips.com>, <airlied@linux.ie>,
<heiko@sntech.de>, <fabio.estevam@freescale.com>,
<rmk+kernel@arm.linux.org.uk>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Grant Likely <grant.likely@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
Philipp Zabel <p.zabel@pengutronix.de>,
Shawn Guo <shawn.guo@linaro.org>, Josh Boyer <jwboyer@redhat.com>,
Sean Paul <seanpaul@chromium.org>,
Inki Dae <inki.dae@samsung.com>, Dave Airlie <airlied@redhat.com>,
Arnd Bergmann <arnd@arndb.de>,
Lucas Stach <l.stach@pengutronix.de>, <djkurtz@google.com>,
<ykk@rock-chips.com>, <linux-kernel@vger.kernel.org>,
<dri-devel@lists.freedesktop.org>, <devel@driverdev.osuosl.org>,
<devicetree@vger.kernel.org>,
<linux-rockchip@lists.infradead.org>, <jay.xu@rock-chips.com>
Subject: Re: [PATCH V5 3/7] dw-hdmi: make checkpatch happy
Date: Mon, 10 Nov 2014 09:22:13 +0000 [thread overview]
Message-ID: <546083C5.8060502@imgtec.com> (raw)
In-Reply-To: <1415424598-7533-1-git-send-email-andy.yan@rock-chips.com>
Hi Andy,
In 3.18 rc4, I cannot find checkpatch errors in imx-hdmi.c
Have these errors come during the previous 2 patches.
If yes, then these changes need to be squashed into the previous
patches. No patch should add a checkpatch error and then fix it in a later patch.
Regards
ZubairLK
On 08/11/14 05:29, Andy Yan wrote:
> CHECK: Alignment should match open parenthesis
> + if ((hdmi->vic == 10) || (hdmi->vic == 11) ||
> + (hdmi->vic == 12) || (hdmi->vic == 13) ||
>
> CHECK: braces {} should be used on all arms of this statement
> + if (hdmi->hdmi_data.video_mode.mdvi)
> [...]
> + else {
> [...]
>
> Signed-off-by: Andy Yan <andy.yan@rock-chips.com>
> ---
> drivers/gpu/drm/bridge/dw_hdmi.c | 97 ++++++++++++++++++++--------------------
> 1 file changed, 48 insertions(+), 49 deletions(-)
next prev parent reply other threads:[~2014-11-10 9:22 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-08 5:26 [PATCH V5 0/7]dw-hdmi: convert imx hdmi to bridge/dw-hdmi Andy Yan
2014-11-08 5:26 ` Andy Yan
2014-11-08 5:28 ` [PATCH V5 1/7] imx-drm: imx-hdmi: split imx soc specific code from imx-hdmi Andy Yan
2014-11-08 5:28 ` Andy Yan
2014-11-10 10:51 ` Zubair Lutfullah Kakakhel
2014-11-10 10:51 ` Zubair Lutfullah Kakakhel
2014-11-10 11:28 ` Andy Yan
2014-11-10 11:28 ` Andy Yan
2014-11-08 5:29 ` [PATCH V5 3/7] dw-hdmi: make checkpatch happy Andy Yan
2014-11-08 5:29 ` Andy Yan
2014-11-10 9:22 ` Zubair Lutfullah Kakakhel [this message]
2014-11-10 9:22 ` Zubair Lutfullah Kakakhel
2014-11-10 9:28 ` Andy Yan
2014-11-10 9:28 ` Andy Yan
2014-11-10 9:31 ` Andy Yan
2014-11-10 9:31 ` Andy Yan
[not found] ` <1415424410-7364-1-git-send-email-andy.yan-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
2014-11-08 5:29 ` [PATCH V5 2/7] dw-hdmi: move imx-hdmi to bridge/dw-hdmi Andy Yan
2014-11-08 5:29 ` Andy Yan
2014-11-08 5:30 ` [PATCH V5 4/7] dw-hdmi: return defer if can't get ddc i2c adapter Andy Yan
2014-11-08 5:30 ` Andy Yan
2014-11-08 5:31 ` [PATCH V5 5/7] dw-hdmi: add support for multi byte register width access Andy Yan
2014-11-08 5:31 ` Andy Yan
2014-11-08 5:32 ` [PATCH V5 6/7] dw-hdmi: convert dw-hdmi to drm_bridge mode Andy Yan
2014-11-08 5:32 ` Andy Yan
2014-11-08 5:32 ` [PATCH V5 7/7] dt-bindings: add document for dw-hdmi Andy Yan
2014-11-08 5:32 ` Andy Yan
2014-11-10 9:17 ` Zubair Lutfullah Kakakhel
2014-11-10 9:17 ` Zubair Lutfullah Kakakhel
2014-11-10 9:44 ` Andy Yan
2014-11-10 9:53 ` Zubair Lutfullah Kakakhel
2014-11-10 9:53 ` Zubair Lutfullah Kakakhel
2014-11-10 9:59 ` Andy Yan
2014-11-10 9:59 ` Andy Yan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=546083C5.8060502@imgtec.com \
--to=zubair.kakakhel@imgtec.com \
--cc=airlied@linux.ie \
--cc=airlied@redhat.com \
--cc=andy.yan@rock-chips.com \
--cc=arnd@arndb.de \
--cc=devel@driverdev.osuosl.org \
--cc=devicetree@vger.kernel.org \
--cc=djkurtz@google.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=fabio.estevam@freescale.com \
--cc=grant.likely@linaro.org \
--cc=gregkh@linuxfoundation.org \
--cc=heiko@sntech.de \
--cc=inki.dae@samsung.com \
--cc=jay.xu@rock-chips.com \
--cc=jwboyer@redhat.com \
--cc=l.stach@pengutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=p.zabel@pengutronix.de \
--cc=rmk+kernel@arm.linux.org.uk \
--cc=robh+dt@kernel.org \
--cc=seanpaul@chromium.org \
--cc=shawn.guo@linaro.org \
--cc=ykk@rock-chips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.