All of lore.kernel.org
 help / color / mirror / Atom feed
From: Max Reitz <mreitz@redhat.com>
To: Fam Zheng <famz@redhat.com>, qemu-devel@nongnu.org
Cc: qemu-trivial@nongnu.org, mjt@tls.msk.ru,
	Markus Armbruster <armbru@redhat.com>
Subject: Re: [Qemu-trivial] [Qemu-devel] [PATCH] block: Fix comment for bdrv_co_get_block_status
Date: Mon, 10 Nov 2014 11:24:12 +0100	[thread overview]
Message-ID: <5460924C.7040308@redhat.com> (raw)
In-Reply-To: <1415610638-3918-1-git-send-email-famz@redhat.com>

On 2014-11-10 at 10:10, Fam Zheng wrote:
> It returns more information than binary, fix the comment.
>
> Signed-off-by: Fam Zheng <famz@redhat.com>
> ---
>   block.c | 6 +++---
>   1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/block.c b/block.c
> index dacd881..42c914e 100644
> --- a/block.c
> +++ b/block.c
> @@ -3903,9 +3903,9 @@ typedef struct BdrvCoGetBlockStatusData {
>   } BdrvCoGetBlockStatusData;
>   
>   /*
> - * Returns true iff the specified sector is present in the disk image. Drivers
> - * not implementing the functionality are assumed to not support backing files,
> - * hence all their sectors are reported as allocated.
> + * Returns the status of the specified sectors. Drivers not implementing the
> + * functionality are assumed to not support backing files, hence all their
> + * sectors are reported as allocated.
>    *
>    * If 'sector_num' is beyond the end of the disk image the return value is 0
>    * and 'pnum' is set to 0.

"status" is a bit broad, but pointing to "line 86 in 
include/block/block.h" for a further explanation will probably not be 
very stable.

Reviewed-by: Max Reitz <mreitz@redhat.com>


WARNING: multiple messages have this Message-ID (diff)
From: Max Reitz <mreitz@redhat.com>
To: Fam Zheng <famz@redhat.com>, qemu-devel@nongnu.org
Cc: qemu-trivial@nongnu.org, mjt@tls.msk.ru,
	Markus Armbruster <armbru@redhat.com>
Subject: Re: [Qemu-devel] [PATCH] block: Fix comment for bdrv_co_get_block_status
Date: Mon, 10 Nov 2014 11:24:12 +0100	[thread overview]
Message-ID: <5460924C.7040308@redhat.com> (raw)
In-Reply-To: <1415610638-3918-1-git-send-email-famz@redhat.com>

On 2014-11-10 at 10:10, Fam Zheng wrote:
> It returns more information than binary, fix the comment.
>
> Signed-off-by: Fam Zheng <famz@redhat.com>
> ---
>   block.c | 6 +++---
>   1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/block.c b/block.c
> index dacd881..42c914e 100644
> --- a/block.c
> +++ b/block.c
> @@ -3903,9 +3903,9 @@ typedef struct BdrvCoGetBlockStatusData {
>   } BdrvCoGetBlockStatusData;
>   
>   /*
> - * Returns true iff the specified sector is present in the disk image. Drivers
> - * not implementing the functionality are assumed to not support backing files,
> - * hence all their sectors are reported as allocated.
> + * Returns the status of the specified sectors. Drivers not implementing the
> + * functionality are assumed to not support backing files, hence all their
> + * sectors are reported as allocated.
>    *
>    * If 'sector_num' is beyond the end of the disk image the return value is 0
>    * and 'pnum' is set to 0.

"status" is a bit broad, but pointing to "line 86 in 
include/block/block.h" for a further explanation will probably not be 
very stable.

Reviewed-by: Max Reitz <mreitz@redhat.com>

  reply	other threads:[~2014-11-10 10:24 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-11-10  9:10 [Qemu-trivial] [PATCH] block: Fix comment for bdrv_co_get_block_status Fam Zheng
2014-11-10  9:10 ` [Qemu-devel] " Fam Zheng
2014-11-10 10:24 ` Max Reitz [this message]
2014-11-10 10:24   ` Max Reitz
2014-11-10 11:07   ` [Qemu-trivial] " Markus Armbruster
2014-11-10 11:07     ` Markus Armbruster
2014-11-11 14:33 ` [Qemu-trivial] " Michael Tokarev
2014-11-11 14:33   ` [Qemu-devel] " Michael Tokarev

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5460924C.7040308@redhat.com \
    --to=mreitz@redhat.com \
    --cc=armbru@redhat.com \
    --cc=famz@redhat.com \
    --cc=mjt@tls.msk.ru \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-trivial@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.