From: Sergei Shtylyov <sergei.shtylyov-M4DtvfQ/ZS1MRgGoP+s0PdBPR1lH4CV8@public.gmane.org>
To: Wenyou Yang <wenyou.yang-AIFe0yeh4nAAvxtiuMwx3w@public.gmane.org>,
wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org,
ludovic.desroches-AIFe0yeh4nAAvxtiuMwx3w@public.gmane.org
Cc: khilman-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
nicolas.ferre-AIFe0yeh4nAAvxtiuMwx3w@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org
Subject: Re: [PATCH v4] i2c/at91: adopt pinctrl support
Date: Mon, 10 Nov 2014 14:13:28 +0300 [thread overview]
Message-ID: <54609DD8.8030903@cogentembedded.com> (raw)
In-Reply-To: <1415584552-11390-1-git-send-email-wenyou.yang-AIFe0yeh4nAAvxtiuMwx3w@public.gmane.org>
Hello.
On 11/10/2014 4:55 AM, Wenyou Yang wrote:
> Amend the at91 i2c pin controller
You're amending the hardware itself, really? :-)
> to optionally take a pin controlhandle
I don't see the code that does this.
> and set the state of the pins to:
> - "default" on boot and resume.
I don't see where you are changing anything for the probe() method.
Perhaps you meant the driver core code which selects the dafault profile
automatically?
> - "sleep" on suspend().
> This should make it possible to optimize energy usage for the pins
> both for the suspend/resume cycle
> Signed-off-by: Wenyou Yang <wenyou.yang-AIFe0yeh4nAAvxtiuMwx3w@public.gmane.org>
> ---
> Hi Wolfram,
>
> Thanks a lot.
>
> The change of this version is to remove
> pinctrl_pm_select_default_state(&pdev->dev) from the _probe function.
Aha, you've specifically removed this...
WBR, Sergei
WARNING: multiple messages have this Message-ID (diff)
From: sergei.shtylyov@cogentembedded.com (Sergei Shtylyov)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v4] i2c/at91: adopt pinctrl support
Date: Mon, 10 Nov 2014 14:13:28 +0300 [thread overview]
Message-ID: <54609DD8.8030903@cogentembedded.com> (raw)
In-Reply-To: <1415584552-11390-1-git-send-email-wenyou.yang@atmel.com>
Hello.
On 11/10/2014 4:55 AM, Wenyou Yang wrote:
> Amend the at91 i2c pin controller
You're amending the hardware itself, really? :-)
> to optionally take a pin controlhandle
I don't see the code that does this.
> and set the state of the pins to:
> - "default" on boot and resume.
I don't see where you are changing anything for the probe() method.
Perhaps you meant the driver core code which selects the dafault profile
automatically?
> - "sleep" on suspend().
> This should make it possible to optimize energy usage for the pins
> both for the suspend/resume cycle
> Signed-off-by: Wenyou Yang <wenyou.yang@atmel.com>
> ---
> Hi Wolfram,
>
> Thanks a lot.
>
> The change of this version is to remove
> pinctrl_pm_select_default_state(&pdev->dev) from the _probe function.
Aha, you've specifically removed this...
WBR, Sergei
WARNING: multiple messages have this Message-ID (diff)
From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: Wenyou Yang <wenyou.yang@atmel.com>,
wsa@the-dreams.de, ludovic.desroches@atmel.com
Cc: khilman@kernel.org, nicolas.ferre@atmel.com,
linux-kernel@vger.kernel.org, linux-i2c@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v4] i2c/at91: adopt pinctrl support
Date: Mon, 10 Nov 2014 14:13:28 +0300 [thread overview]
Message-ID: <54609DD8.8030903@cogentembedded.com> (raw)
In-Reply-To: <1415584552-11390-1-git-send-email-wenyou.yang@atmel.com>
Hello.
On 11/10/2014 4:55 AM, Wenyou Yang wrote:
> Amend the at91 i2c pin controller
You're amending the hardware itself, really? :-)
> to optionally take a pin controlhandle
I don't see the code that does this.
> and set the state of the pins to:
> - "default" on boot and resume.
I don't see where you are changing anything for the probe() method.
Perhaps you meant the driver core code which selects the dafault profile
automatically?
> - "sleep" on suspend().
> This should make it possible to optimize energy usage for the pins
> both for the suspend/resume cycle
> Signed-off-by: Wenyou Yang <wenyou.yang@atmel.com>
> ---
> Hi Wolfram,
>
> Thanks a lot.
>
> The change of this version is to remove
> pinctrl_pm_select_default_state(&pdev->dev) from the _probe function.
Aha, you've specifically removed this...
WBR, Sergei
next prev parent reply other threads:[~2014-11-10 11:13 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-10 1:55 [PATCH v4] i2c/at91: adopt pinctrl support Wenyou Yang
2014-11-10 1:55 ` Wenyou Yang
2014-11-10 1:55 ` Wenyou Yang
[not found] ` <1415584552-11390-1-git-send-email-wenyou.yang-AIFe0yeh4nAAvxtiuMwx3w@public.gmane.org>
2014-11-10 11:13 ` Sergei Shtylyov [this message]
2014-11-10 11:13 ` Sergei Shtylyov
2014-11-10 11:13 ` Sergei Shtylyov
[not found] ` <54609DD8.8030903-M4DtvfQ/ZS1MRgGoP+s0PdBPR1lH4CV8@public.gmane.org>
2014-11-11 0:53 ` Yang, Wenyou
2014-11-11 0:53 ` Yang, Wenyou
2014-11-11 0:53 ` Yang, Wenyou
2014-11-12 15:51 ` Wolfram Sang
2014-11-12 15:51 ` Wolfram Sang
2014-11-12 15:51 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54609DD8.8030903@cogentembedded.com \
--to=sergei.shtylyov-m4dtvfq/zs1mrggop+s0pdbpr1lh4cv8@public.gmane.org \
--cc=khilman-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=ludovic.desroches-AIFe0yeh4nAAvxtiuMwx3w@public.gmane.org \
--cc=nicolas.ferre-AIFe0yeh4nAAvxtiuMwx3w@public.gmane.org \
--cc=wenyou.yang-AIFe0yeh4nAAvxtiuMwx3w@public.gmane.org \
--cc=wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.