All of lore.kernel.org
 help / color / mirror / Atom feed
From: afaerber@suse.de (Andreas Färber)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 2/2] arm64: Add Juno SoC device tree.
Date: Mon, 10 Nov 2014 20:05:42 +0100	[thread overview]
Message-ID: <54610C86.9090002@suse.de> (raw)
In-Reply-To: <1415618875-8469-3-git-send-email-Liviu.Dudau@arm.com>

Hi,

Am 10.11.2014 um 12:27 schrieb Liviu Dudau:
> diff --git a/arch/arm64/boot/dts/juno.dts b/arch/arm64/boot/dts/juno.dts
> new file mode 100644
> index 0000000..7f998de
> --- /dev/null
> +++ b/arch/arm64/boot/dts/juno.dts
> @@ -0,0 +1,374 @@
> +/*
> + * ARM Ltd. Juno Plaform

"Platform"

> + *

Shouldn't this mention a license, ideally dual-licensed?

> + */
> +
> +/dts-v1/;
> +
> +#include <dt-bindings/interrupt-controller/arm-gic.h>
> +
> +/ {
> +	model = "Juno";
> +	compatible = "arm,juno", "arm,vexpress";
> +	interrupt-parent = <&gic>;
> +	#address-cells = <2>;
> +	#size-cells = <2>;
> +
> +	aliases {
> +		serial0 = &soc_uart0;
> +	};
> +
> +	cpus {
> +		#address-cells = <2>;
> +		#size-cells = <0>;
> +
> +		A53_0:cpu at 100 {
[snip]

Can you please add a space after colon, like you did for non-CPU nodes?

Regards,
Andreas

-- 
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 N?rnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imend?rffer; HRB 21284 AG N?rnberg

WARNING: multiple messages have this Message-ID (diff)
From: "Andreas Färber" <afaerber-l3A5Bk7waGM@public.gmane.org>
To: Liviu Dudau <Liviu.Dudau-5wv7dgnIgG8@public.gmane.org>,
	arm-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
	Olof Johansson <olof-nZhT3qVonbNeoWH0uzbU5w@public.gmane.org>
Cc: Arnd Bergmann <arnd-r2nGTMty4D4@public.gmane.org>,
	Kevin Hilman <khilman-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>,
	Mark Rutland <mark.rutland-5wv7dgnIgG8@public.gmane.org>,
	device tree <devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	Pawel Moll <pawel.moll-5wv7dgnIgG8@public.gmane.org>,
	Ian Campbell
	<ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org>,
	Catalin Marinas <catalin.marinas-5wv7dgnIgG8@public.gmane.org>,
	Will Deacon <will.deacon-5wv7dgnIgG8@public.gmane.org>,
	LKML <linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	Rob Herring <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
	Kumar Gala <galak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>,
	LAKML
	<linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org>
Subject: Re: [PATCH v2 2/2] arm64: Add Juno SoC device tree.
Date: Mon, 10 Nov 2014 20:05:42 +0100	[thread overview]
Message-ID: <54610C86.9090002@suse.de> (raw)
In-Reply-To: <1415618875-8469-3-git-send-email-Liviu.Dudau-5wv7dgnIgG8@public.gmane.org>

Hi,

Am 10.11.2014 um 12:27 schrieb Liviu Dudau:
> diff --git a/arch/arm64/boot/dts/juno.dts b/arch/arm64/boot/dts/juno.dts
> new file mode 100644
> index 0000000..7f998de
> --- /dev/null
> +++ b/arch/arm64/boot/dts/juno.dts
> @@ -0,0 +1,374 @@
> +/*
> + * ARM Ltd. Juno Plaform

"Platform"

> + *

Shouldn't this mention a license, ideally dual-licensed?

> + */
> +
> +/dts-v1/;
> +
> +#include <dt-bindings/interrupt-controller/arm-gic.h>
> +
> +/ {
> +	model = "Juno";
> +	compatible = "arm,juno", "arm,vexpress";
> +	interrupt-parent = <&gic>;
> +	#address-cells = <2>;
> +	#size-cells = <2>;
> +
> +	aliases {
> +		serial0 = &soc_uart0;
> +	};
> +
> +	cpus {
> +		#address-cells = <2>;
> +		#size-cells = <0>;
> +
> +		A53_0:cpu@100 {
[snip]

Can you please add a space after colon, like you did for non-CPU nodes?

Regards,
Andreas

-- 
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 21284 AG Nürnberg
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

WARNING: multiple messages have this Message-ID (diff)
From: "Andreas Färber" <afaerber@suse.de>
To: Liviu Dudau <Liviu.Dudau@arm.com>,
	arm@kernel.org, Olof Johansson <olof@lixom.net>
Cc: Arnd Bergmann <arnd@arndb.de>, Kevin Hilman <khilman@linaro.org>,
	Mark Rutland <mark.rutland@arm.com>,
	device tree <devicetree@vger.kernel.org>,
	Pawel Moll <pawel.moll@arm.com>,
	Ian Campbell <ijc+devicetree@hellion.org.uk>,
	Catalin Marinas <catalin.marinas@arm.com>,
	Will Deacon <will.deacon@arm.com>,
	LKML <linux-kernel@vger.kernel.org>,
	Rob Herring <robh+dt@kernel.org>,
	Kumar Gala <galak@codeaurora.org>,
	LAKML <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v2 2/2] arm64: Add Juno SoC device tree.
Date: Mon, 10 Nov 2014 20:05:42 +0100	[thread overview]
Message-ID: <54610C86.9090002@suse.de> (raw)
In-Reply-To: <1415618875-8469-3-git-send-email-Liviu.Dudau@arm.com>

Hi,

Am 10.11.2014 um 12:27 schrieb Liviu Dudau:
> diff --git a/arch/arm64/boot/dts/juno.dts b/arch/arm64/boot/dts/juno.dts
> new file mode 100644
> index 0000000..7f998de
> --- /dev/null
> +++ b/arch/arm64/boot/dts/juno.dts
> @@ -0,0 +1,374 @@
> +/*
> + * ARM Ltd. Juno Plaform

"Platform"

> + *

Shouldn't this mention a license, ideally dual-licensed?

> + */
> +
> +/dts-v1/;
> +
> +#include <dt-bindings/interrupt-controller/arm-gic.h>
> +
> +/ {
> +	model = "Juno";
> +	compatible = "arm,juno", "arm,vexpress";
> +	interrupt-parent = <&gic>;
> +	#address-cells = <2>;
> +	#size-cells = <2>;
> +
> +	aliases {
> +		serial0 = &soc_uart0;
> +	};
> +
> +	cpus {
> +		#address-cells = <2>;
> +		#size-cells = <0>;
> +
> +		A53_0:cpu@100 {
[snip]

Can you please add a space after colon, like you did for non-CPU nodes?

Regards,
Andreas

-- 
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 21284 AG Nürnberg

  parent reply	other threads:[~2014-11-10 19:05 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-11-10 11:27 [PATCH v2 0/2] arm64: Add support for Juno development board Liviu Dudau
2014-11-10 11:27 ` Liviu Dudau
2014-11-10 11:27 ` Liviu Dudau
2014-11-10 11:27 ` [PATCH v2 1/2] arm64: Create link to include/dt-bindings to enable C preprocessor use Liviu Dudau
2014-11-10 11:27   ` Liviu Dudau
2014-11-10 11:27 ` [PATCH v2 2/2] arm64: Add Juno SoC device tree Liviu Dudau
2014-11-10 11:27   ` Liviu Dudau
2014-11-10 11:27   ` Liviu Dudau
2014-11-10 17:42   ` Olof Johansson
2014-11-10 17:42     ` Olof Johansson
2014-11-10 17:42     ` Olof Johansson
2014-11-10 20:19     ` Liviu Dudau
2014-11-10 20:19       ` Liviu Dudau
2014-11-10 20:19       ` Liviu Dudau
2014-11-10 19:05   ` Andreas Färber [this message]
2014-11-10 19:05     ` Andreas Färber
2014-11-10 19:05     ` Andreas Färber
2014-11-10 20:00     ` Liviu Dudau
2014-11-10 20:00       ` Liviu Dudau
2014-11-10 20:00       ` Liviu Dudau

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54610C86.9090002@suse.de \
    --to=afaerber@suse.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.