All of lore.kernel.org
 help / color / mirror / Atom feed
From: Richard Weinberger <richard@nod.at>
To: Fabio Estevam <festevam@gmail.com>
Cc: Fabio Estevam <fabio.estevam@freescale.com>,
	"linux-mtd@lists.infradead.org" <linux-mtd@lists.infradead.org>,
	Brian Norris <computersforpeace@gmail.com>,
	Huang Shijie <shijie8@gmail.com>
Subject: Re: [PATCH] mtd: gpmi: Remove noisy error message
Date: Tue, 11 Nov 2014 21:22:46 +0100	[thread overview]
Message-ID: <54627016.1020403@nod.at> (raw)
In-Reply-To: <CAOMZO5C3STv-ZsTyXhxs2rhUMM7nu+kuzdAtV_Fo9c5azdeAuA@mail.gmail.com>

Am 11.11.2014 um 21:16 schrieb Fabio Estevam:
> On Tue, Nov 11, 2014 at 6:10 PM, Richard Weinberger <richard@nod.at> wrote:
> 
>> If the development board has by default no NAND, disable the driver
>> in imx28-evk.dts file.
> 
> Again, people are free to put a NAND into the socket and just use it.

If people change their board they are free to fix their dts. :)

>> You can leave a comment how to enable the driver if an user creates
>> a new board based on this eval board with a NAND.
> 
> No, I don't think this is a good idea.
> 
> BTW, I don't see any other nand driver that prints error on the probe
> error path like this one.

mpc5121_nfc.c for example does. Before every "goto error" in mpc5121_nfc_probe()
it prints an error message.

Thanks,
//richard

  reply	other threads:[~2014-11-11 20:23 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-11-11 16:01 [PATCH] mtd: gpmi: Remove noisy error message Fabio Estevam
2014-11-11 19:45 ` Richard Weinberger
2014-11-11 19:57   ` Fabio Estevam
2014-11-11 20:00     ` Richard Weinberger
2014-11-11 20:05       ` Fabio Estevam
2014-11-11 20:10         ` Richard Weinberger
2014-11-11 20:16           ` Fabio Estevam
2014-11-11 20:22             ` Richard Weinberger [this message]
2014-11-11 20:28               ` Fabio Estevam
2014-11-11 20:31                 ` Richard Weinberger
2014-11-26  3:18             ` Brian Norris
2014-11-26 11:44               ` Fabio Estevam
2014-11-26 13:35                 ` Richard Weinberger
2014-12-17  0:27 ` Brian Norris

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54627016.1020403@nod.at \
    --to=richard@nod.at \
    --cc=computersforpeace@gmail.com \
    --cc=fabio.estevam@freescale.com \
    --cc=festevam@gmail.com \
    --cc=linux-mtd@lists.infradead.org \
    --cc=shijie8@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.