Re: [PATCH] mtd: gpmi: Remove noisy error message

[Richard Weinberger <richard@nod.at>]

Am 26.11.2014 um 12:44 schrieb Fabio Estevam:
> On Wed, Nov 26, 2014 at 1:18 AM, Brian Norris
> <computersforpeace@gmail.com> wrote:
>> On Tue, Nov 11, 2014 at 06:16:29PM -0200, Fabio Estevam wrote:
>>> BTW, I don't see any other nand driver that prints error on the probe
>>> error path like this one.
>>
>> You're probably still going to see failure prints like
>>
>>   nand: No NAND device found
>>
>> in nand_scan_ident(), right? Or does driver probe fail earlier than that
>> somehow?
> 
> Yes, this is what I get currently:
> 
> [    1.645433] nand: No NAND device found
> [    1.650372] gpmi-nand 8000c000.gpmi-nand: driver registration failed: -19
> 
> In my opinion the "No NAND device found" is enough.

If we remove the said log message and one really has a NAND installed which fails
to probe will he notice that and get the correct error code printed?
If yes, the removal won't hurt.

My point is that having non-existing hardware in the device does not make much sense.
Lot's of DTs are very generic and carry a lot of unused stuff with them,
but this is not a good practice as DTs should describe the actual hardware and not
all possible board variants.

Thanks,
//richard