All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stephen Warren <swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
To: Olof Johansson <olof-nZhT3qVonbNeoWH0uzbU5w@public.gmane.org>,
	thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
	gnurou-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org
Cc: linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
	gregkh-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org,
	Laxman Dewangan
	<ldewangan-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
Subject: Re: [PATCH] ARM: dts: tegra: move serial aliases to per-board
Date: Tue, 11 Nov 2014 14:14:07 -0700	[thread overview]
Message-ID: <54627C1F.9050200@wwwdotorg.org> (raw)
In-Reply-To: <1415738970-7963-1-git-send-email-olof-nZhT3qVonbNeoWH0uzbU5w@public.gmane.org>

On 11/11/2014 01:49 PM, Olof Johansson wrote:
> There are general changes pending to make the /aliases/serial* entries
> number the serial ports on the system. On tegra, so far the ports have been
> just numbered dynamically as they are configured so that makes them change.
>
> To avoid this, add specific aliases per board to keep the old numbers. This
> allows us to change the numbering by default on future SoCs while keeping the
> numbering on existing boards.

This change seems mostly OK to me. FWIW though, I had suggested this 
approach when the UART aliases were first added, and Laxman disagreed 
with it. See commit b6551bb933f9 "ARM: tegra: dts: add aliases and DMA 
requestor for serial controller", and its discussion: 
https://lkml.org/lkml/2012/12/25/4. I've CC'd Laxman in case he still 
objects.

> Signed-off-by: Olof Johansson <olof-nZhT3qVonbNeoWH0uzbU5w@public.gmane.org>
> ---
>
> Stephen/Thierry/Alex, as noticed this week we really should try to get
> this in before the 3.19 merge window so that the global aliases change
> can happen there without regression.

How did we resolve the issue that patch causes with old DTs; namely that 
it causes a change in behaviour for those old DTs? On IRC, I'd wondered 
whether we should set a flag so the kernel ignored aliases for boards 
containing currently upstreamed Tegra SoCs so that issue wouldn't occur. 
If we did that, we wouldn't need this patch.

WARNING: multiple messages have this Message-ID (diff)
From: swarren@wwwdotorg.org (Stephen Warren)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: dts: tegra: move serial aliases to per-board
Date: Tue, 11 Nov 2014 14:14:07 -0700	[thread overview]
Message-ID: <54627C1F.9050200@wwwdotorg.org> (raw)
In-Reply-To: <1415738970-7963-1-git-send-email-olof@lixom.net>

On 11/11/2014 01:49 PM, Olof Johansson wrote:
> There are general changes pending to make the /aliases/serial* entries
> number the serial ports on the system. On tegra, so far the ports have been
> just numbered dynamically as they are configured so that makes them change.
>
> To avoid this, add specific aliases per board to keep the old numbers. This
> allows us to change the numbering by default on future SoCs while keeping the
> numbering on existing boards.

This change seems mostly OK to me. FWIW though, I had suggested this 
approach when the UART aliases were first added, and Laxman disagreed 
with it. See commit b6551bb933f9 "ARM: tegra: dts: add aliases and DMA 
requestor for serial controller", and its discussion: 
https://lkml.org/lkml/2012/12/25/4. I've CC'd Laxman in case he still 
objects.

> Signed-off-by: Olof Johansson <olof@lixom.net>
> ---
>
> Stephen/Thierry/Alex, as noticed this week we really should try to get
> this in before the 3.19 merge window so that the global aliases change
> can happen there without regression.

How did we resolve the issue that patch causes with old DTs; namely that 
it causes a change in behaviour for those old DTs? On IRC, I'd wondered 
whether we should set a flag so the kernel ignored aliases for boards 
containing currently upstreamed Tegra SoCs so that issue wouldn't occur. 
If we did that, we wouldn't need this patch.

WARNING: multiple messages have this Message-ID (diff)
From: Stephen Warren <swarren@wwwdotorg.org>
To: Olof Johansson <olof@lixom.net>,
	thierry.reding@gmail.com, gnurou@gmail.com
Cc: linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	gregkh@linux-foundation.org,
	Laxman Dewangan <ldewangan@nvidia.com>
Subject: Re: [PATCH] ARM: dts: tegra: move serial aliases to per-board
Date: Tue, 11 Nov 2014 14:14:07 -0700	[thread overview]
Message-ID: <54627C1F.9050200@wwwdotorg.org> (raw)
In-Reply-To: <1415738970-7963-1-git-send-email-olof@lixom.net>

On 11/11/2014 01:49 PM, Olof Johansson wrote:
> There are general changes pending to make the /aliases/serial* entries
> number the serial ports on the system. On tegra, so far the ports have been
> just numbered dynamically as they are configured so that makes them change.
>
> To avoid this, add specific aliases per board to keep the old numbers. This
> allows us to change the numbering by default on future SoCs while keeping the
> numbering on existing boards.

This change seems mostly OK to me. FWIW though, I had suggested this 
approach when the UART aliases were first added, and Laxman disagreed 
with it. See commit b6551bb933f9 "ARM: tegra: dts: add aliases and DMA 
requestor for serial controller", and its discussion: 
https://lkml.org/lkml/2012/12/25/4. I've CC'd Laxman in case he still 
objects.

> Signed-off-by: Olof Johansson <olof@lixom.net>
> ---
>
> Stephen/Thierry/Alex, as noticed this week we really should try to get
> this in before the 3.19 merge window so that the global aliases change
> can happen there without regression.

How did we resolve the issue that patch causes with old DTs; namely that 
it causes a change in behaviour for those old DTs? On IRC, I'd wondered 
whether we should set a flag so the kernel ignored aliases for boards 
containing currently upstreamed Tegra SoCs so that issue wouldn't occur. 
If we did that, we wouldn't need this patch.

  parent reply	other threads:[~2014-11-11 21:14 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-11-11 20:49 [PATCH] ARM: dts: tegra: move serial aliases to per-board Olof Johansson
2014-11-11 20:49 ` Olof Johansson
     [not found] ` <1415738970-7963-1-git-send-email-olof-nZhT3qVonbNeoWH0uzbU5w@public.gmane.org>
2014-11-11 21:14   ` Stephen Warren [this message]
2014-11-11 21:14     ` Stephen Warren
2014-11-11 21:14     ` Stephen Warren
2014-11-11 22:45     ` Olof Johansson
2014-11-11 22:45       ` Olof Johansson
     [not found]       ` <CAOesGMh_8Ft=DKqm=e0fQdREC4aLmAAp3N0QyNsqWn2_rCbmnA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2014-11-11 23:39         ` Stephen Warren
2014-11-11 23:39           ` Stephen Warren
2014-11-11 23:39           ` Stephen Warren
     [not found]     ` <54627C1F.9050200-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2014-11-12 10:46       ` Lucas Stach
2014-11-12 10:46         ` Lucas Stach
2014-11-12 10:46         ` Lucas Stach
2014-11-12 12:20   ` Thierry Reding
2014-11-12 12:20     ` Thierry Reding
2014-11-12 12:20     ` Thierry Reding
     [not found]     ` <20141112122017.GC30821-AwZRO8vwLAwmlAP/+Wk3EA@public.gmane.org>
2014-11-12 17:07       ` Olof Johansson
2014-11-12 17:07         ` Olof Johansson
2014-11-12 17:07         ` Olof Johansson
     [not found]         ` <CAOesGMjmVJuaiFZf6msFtsGiQn6TOPatZ7V3p-KfaPqpXnrYmA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2014-11-13 11:27           ` Thierry Reding
2014-11-13 11:27             ` Thierry Reding
2014-11-13 11:27             ` Thierry Reding
2014-11-13 16:17             ` Thierry Reding
2014-11-13 16:17               ` Thierry Reding
2014-11-13 16:17               ` Thierry Reding
2014-11-12 18:14       ` Stephen Warren
2014-11-12 18:14         ` Stephen Warren
2014-11-12 18:14         ` Stephen Warren
     [not found]         ` <5463A390.2040609-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2014-11-13 12:04           ` Thierry Reding
2014-11-13 12:04             ` Thierry Reding
2014-11-13 12:04             ` Thierry Reding

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54627C1F.9050200@wwwdotorg.org \
    --to=swarren-3lzwwm7+weoh9zmkesr00q@public.gmane.org \
    --cc=gnurou-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
    --cc=gregkh-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org \
    --cc=ldewangan-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org \
    --cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
    --cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=olof-nZhT3qVonbNeoWH0uzbU5w@public.gmane.org \
    --cc=thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.