Re: [Qemu-devel] [PATCH 1/3] chardev: Add -qmp-pretty

[Eric Blake <eblake@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 1094 bytes --]

On 11/11/2014 06:34 AM, Max Reitz wrote:
> Add a command line option for adding a QMP monitor using pretty JSON
> formatting.
> 
> Signed-off-by: Max Reitz <mreitz@redhat.com>
> ---
>  qemu-options.hx |  8 ++++++++
>  vl.c            | 15 ++++++++++-----
>  2 files changed, 18 insertions(+), 5 deletions(-)
> 

Minor grammar suggestions:

> diff --git a/qemu-options.hx b/qemu-options.hx
> index da9851d..bc7b4c2 100644
> --- a/qemu-options.hx
> +++ b/qemu-options.hx
> @@ -2788,6 +2788,14 @@ STEXI
>  @findex -qmp
>  Like -monitor but opens in 'control' mode.
>  ETEXI
> +DEF("qmp-pretty", HAS_ARG, QEMU_OPTION_qmp_pretty, \
> +    "-qmp-pretty dev like -qmp but uses pretty JSON formatting\n",

maybe s/dev like -qmp/dev: like -qmp,/

> +    QEMU_ARCH_ALL)
> +STEXI
> +@item -qmp-pretty @var{dev}
> +@findex -qmp-pretty
> +Like -qmp but uses pretty JSON formatting.

maybe s/-qmp/-qmp,/

Either way,
Reviewed-by: Eric Blake <eblake@redhat.com>

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 539 bytes --]