Re: [Qemu-devel] [PATCH 3/3] iotests: Use -qmp-pretty in 067

[Eric Blake <eblake@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 1338 bytes --]

On 11/11/2014 06:34 AM, Max Reitz wrote:
> 067 invokes query-block, resulting in a reference output with really
> long lines (which may pose a problem in email patches and always poses a
> problem when the output changes, because it is hard to see what has
> actually changed). Use -qmp-pretty to mitigate this issue.
> 
> Signed-off-by: Max Reitz <mreitz@redhat.com>
> ---
>  tests/qemu-iotests/067     |   2 +-
>  tests/qemu-iotests/067.out | 779 +++++++++++++++++++++++++++++++++++++++++----
>  2 files changed, 723 insertions(+), 58 deletions(-)

Large, but mechanical.  I'm trusting this one is correct (if the
testsuite still passes, you did it right) rather than actually reading it :)

Reviewed-by: Eric Blake <eblake@redhat.com>

> 
> diff --git a/tests/qemu-iotests/067 b/tests/qemu-iotests/067
> index d025192..29cd6b5 100755
> --- a/tests/qemu-iotests/067
> +++ b/tests/qemu-iotests/067
> @@ -39,7 +39,7 @@ _supported_os Linux
>  function do_run_qemu()
>  {
>      echo Testing: "$@"
> -    $QEMU -nographic -qmp stdio -serial none "$@"
> +    $QEMU -nographic -qmp-pretty stdio -serial none "$@"

Such a trivial change for inducing over 700 lines of change in the
expected output :)

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 539 bytes --]