From: gregory.clement@free-electrons.com (Gregory CLEMENT)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 4/6] phy: add support for USB cluster on the Armada 375 SoC
Date: Wed, 12 Nov 2014 09:18:32 +0100 [thread overview]
Message-ID: <546317D8.9010602@free-electrons.com> (raw)
In-Reply-To: <5461E169.1040404@ti.com>
Hi,
[...]
>>> index 000000000000..cbd2d4e720bb
>>> --- /dev/null
>>> +++ b/include/dt-bindings/phy/armada-375-usb-cluster.h
>>> @@ -0,0 +1,19 @@
>>> +/*
>>> + * Copyright (C) 2014 Marvell
>>> + *
>>> + * This program is free software; you can redistribute it and/or
>>> + * modify it under the terms of the GNU General Public License as
>>> + * published by the Free Software Foundation; either version 2 of the
>>> + * License, or (at your option) any later version.
>>> + */
>>> +
>>> +#ifndef __ARMADA_375_USB_CLUSTER__
>>> +#define __ARMADA_375_USB_CLUSTER__
>>> +
>>> +/* The supported mode passed through by the phandle are the following */
>>> +
>>> +#define PHY_NONE 0
>>> +#define PHY_USB2 1
>>> +#define PHY_USB3 2
>>
>> Let's not add a separate file for every platform for these generic modes.
>
> Can you use this patch [1] and resend your series?
>
Yes sure, a new series is coming soon.
Thanks,
Gregory
> Thanks
> Kishon
>
> [1] -> http://www.gossamer-threads.com/lists/linux/kernel/2044969
>>
>> Thanks
>> Kishon
>>> +
>>> +#endif /* __DT_BINDINGS_CLOCK_R8A7791_H__ */
>>>
> --
> To unsubscribe from this list: send the line "unsubscribe devicetree" in
> the body of a message to majordomo at vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
--
Gregory Clement, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
WARNING: multiple messages have this Message-ID (diff)
From: Gregory CLEMENT <gregory.clement@free-electrons.com>
To: Kishon Vijay Abraham I <kishon@ti.com>,
Jason Cooper <jason@lakedaemon.net>, Andrew Lunn <andrew@lunn.ch>,
Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>
Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>,
Ezequiel Garcia <ezequiel.garcia@free-electrons.com>,
linux-arm-kernel@lists.infradead.org,
Lior Amsalem <alior@marvell.com>,
Tawfik Bayouk <tawfik@marvell.com>,
Nadav Haklai <nadavh@marvell.com>,
Mark Rutland <mark.rutland@arm.com>,
devicetree@vger.kernel.org,
Grant Likely <grant.likely@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 4/6] phy: add support for USB cluster on the Armada 375 SoC
Date: Wed, 12 Nov 2014 09:18:32 +0100 [thread overview]
Message-ID: <546317D8.9010602@free-electrons.com> (raw)
In-Reply-To: <5461E169.1040404@ti.com>
Hi,
[...]
>>> index 000000000000..cbd2d4e720bb
>>> --- /dev/null
>>> +++ b/include/dt-bindings/phy/armada-375-usb-cluster.h
>>> @@ -0,0 +1,19 @@
>>> +/*
>>> + * Copyright (C) 2014 Marvell
>>> + *
>>> + * This program is free software; you can redistribute it and/or
>>> + * modify it under the terms of the GNU General Public License as
>>> + * published by the Free Software Foundation; either version 2 of the
>>> + * License, or (at your option) any later version.
>>> + */
>>> +
>>> +#ifndef __ARMADA_375_USB_CLUSTER__
>>> +#define __ARMADA_375_USB_CLUSTER__
>>> +
>>> +/* The supported mode passed through by the phandle are the following */
>>> +
>>> +#define PHY_NONE 0
>>> +#define PHY_USB2 1
>>> +#define PHY_USB3 2
>>
>> Let's not add a separate file for every platform for these generic modes.
>
> Can you use this patch [1] and resend your series?
>
Yes sure, a new series is coming soon.
Thanks,
Gregory
> Thanks
> Kishon
>
> [1] -> http://www.gossamer-threads.com/lists/linux/kernel/2044969
>>
>> Thanks
>> Kishon
>>> +
>>> +#endif /* __DT_BINDINGS_CLOCK_R8A7791_H__ */
>>>
> --
> To unsubscribe from this list: send the line "unsubscribe devicetree" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
--
Gregory Clement, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
next prev parent reply other threads:[~2014-11-12 8:18 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-24 15:24 [PATCH v2 0/6] Add support for USB cluster(PHY muxer) on the Armada 375 Gregory CLEMENT
2014-10-24 15:24 ` Gregory CLEMENT
2014-10-24 15:24 ` Gregory CLEMENT
2014-10-24 15:24 ` [PATCH v2 1/6] phy: Use PTR_ERR_OR_ZERO to fix warning raised by coccinelle Gregory CLEMENT
2014-10-24 15:24 ` Gregory CLEMENT
2014-10-24 15:24 ` [PATCH v2 2/6] Phy: DT binding documentation for Marvell MVEBU SATA phy Gregory CLEMENT
2014-10-24 15:24 ` Gregory CLEMENT
2014-10-24 15:24 ` [PATCH v2 3/6] Phy: DT binding documentation for the Armada 375 USB cluster binding Gregory CLEMENT
2014-10-24 15:24 ` Gregory CLEMENT
2014-10-24 15:24 ` Gregory CLEMENT
2014-10-24 15:24 ` [PATCH v2 4/6] phy: add support for USB cluster on the Armada 375 SoC Gregory CLEMENT
2014-10-24 15:24 ` Gregory CLEMENT
2014-11-04 9:18 ` Kishon Vijay Abraham I
2014-11-04 9:18 ` Kishon Vijay Abraham I
2014-11-04 9:18 ` Kishon Vijay Abraham I
2014-11-11 10:14 ` Kishon Vijay Abraham I
2014-11-11 10:14 ` Kishon Vijay Abraham I
2014-11-11 10:14 ` Kishon Vijay Abraham I
2014-11-12 8:18 ` Gregory CLEMENT [this message]
2014-11-12 8:18 ` Gregory CLEMENT
2014-10-24 15:24 ` [PATCH v2 5/6] ARM: mvebu: add Device Tree description of USB cluster controller on Armada 375 Gregory CLEMENT
2014-10-24 15:24 ` Gregory CLEMENT
2014-11-04 6:25 ` Kishon Vijay Abraham I
2014-11-04 6:25 ` Kishon Vijay Abraham I
2014-11-04 6:25 ` Kishon Vijay Abraham I
2014-10-24 15:24 ` [PATCH v2 6/6] ARM: mvebu: add PHY support to the dts for the USB controllers " Gregory CLEMENT
2014-10-24 15:24 ` Gregory CLEMENT
2014-11-01 22:46 ` [PATCH v2 0/6] Add support for USB cluster(PHY muxer) on the " Jason Cooper
2014-11-01 22:46 ` Jason Cooper
2014-11-01 22:46 ` Jason Cooper
2014-11-03 16:48 ` Gregory CLEMENT
2014-11-03 16:48 ` Gregory CLEMENT
2014-11-03 16:48 ` Gregory CLEMENT
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=546317D8.9010602@free-electrons.com \
--to=gregory.clement@free-electrons.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.