From: Tang Chen <tangchen@cn.fujitsu.com>
To: akpm@linux-foundation.org, grygorii.strashko@ti.com,
yinghai@kernel.org, isimatu.yasuaki@jp.fujitsu.com,
fabf@skynet.be, nzimmer@sgi.com, wangnan0@huawei.com,
vdavydov@parallels.com, toshi.kani@hp.com,
phacht@linux.vnet.ibm.com, tj@kernel.org,
kirill.shutemov@linux.intel.com, riel@redhat.com,
luto@amacapital.net, hpa@linux.intel.com, aarcange@redhat.com,
qiuxishi@huawei.com, mgorman@suse.de, rientjes@google.com,
hannes@cmpxchg.org
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
tangchen@cn.fujitsu.com
Subject: Re: [PATCH 0/2] Fix node meminfo corruption.
Date: Wed, 12 Nov 2014 16:38:23 +0800 [thread overview]
Message-ID: <54631C7F.5090905@cn.fujitsu.com> (raw)
In-Reply-To: <1415781410-19825-1-git-send-email-tangchen@cn.fujitsu.com>
Sorry, please ignore this series. Sent by mistake.
On 11/12/2014 04:36 PM, Tang Chen wrote:
> There are two problems when calculating node meminfo:
>
> 1. When hot-adding a node without onlining any page, MemTotal corrupted.
>
> # hot-add node2 (memory not onlined)
> # cat /sys/device/system/node/node2/meminfo
> Node 2 MemTotal: 33554432 kB /* corrupted */
> Node 2 MemFree: 0 kB
> Node 2 MemUsed: 33554432 kB
> Node 2 Active: 0 kB
> ......
>
>
> 2. When onlining memory on node2, MemFree of node3 corrupted.
>
> # for ((i = 2048; i < 2064; i++)); do echo online_movable > /sys/devices/system/node/node2/memory$i/state; done
> # cat /sys/devices/system/node/node2/meminfo
> Node 2 MemTotal: 33554432 kB
> Node 2 MemFree: 33549092 kB
> Node 2 MemUsed: 5340 kB
> ......
> # cat /sys/devices/system/node/node3/meminfo
> Node 3 MemTotal: 0 kB
> Node 3 MemFree: 248 kB /* corrupted */
> Node 3 MemUsed: 0 kB
> ......
>
> This patch-set fixes them.
>
> Tang Chen (2):
> mem-hotplug: Reset node managed pages when hot-adding a new pgdat.
> mem-hotplug: Fix wrong check for zone->pageset initialization in
> online_pages().
>
> include/linux/bootmem.h | 1 +
> include/linux/mm.h | 1 +
> mm/bootmem.c | 9 +++++----
> mm/memory_hotplug.c | 15 ++++++++++++++-
> mm/nobootmem.c | 8 +++++---
> mm/page_alloc.c | 5 +++++
> 6 files changed, 31 insertions(+), 8 deletions(-)
>
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: Tang Chen <tangchen@cn.fujitsu.com>
To: <akpm@linux-foundation.org>, <grygorii.strashko@ti.com>,
<yinghai@kernel.org>, <isimatu.yasuaki@jp.fujitsu.com>,
<fabf@skynet.be>, <nzimmer@sgi.com>, <wangnan0@huawei.com>,
<vdavydov@parallels.com>, <toshi.kani@hp.com>,
<phacht@linux.vnet.ibm.com>, <tj@kernel.org>,
<kirill.shutemov@linux.intel.com>, <riel@redhat.com>,
<luto@amacapital.net>, <hpa@linux.intel.com>,
<aarcange@redhat.com>, <qiuxishi@huawei.com>, <mgorman@suse.de>,
<rientjes@google.com>, <hannes@cmpxchg.org>
Cc: <linux-mm@kvack.org>, <linux-kernel@vger.kernel.org>,
<tangchen@cn.fujitsu.com>
Subject: Re: [PATCH 0/2] Fix node meminfo corruption.
Date: Wed, 12 Nov 2014 16:38:23 +0800 [thread overview]
Message-ID: <54631C7F.5090905@cn.fujitsu.com> (raw)
In-Reply-To: <1415781410-19825-1-git-send-email-tangchen@cn.fujitsu.com>
Sorry, please ignore this series. Sent by mistake.
On 11/12/2014 04:36 PM, Tang Chen wrote:
> There are two problems when calculating node meminfo:
>
> 1. When hot-adding a node without onlining any page, MemTotal corrupted.
>
> # hot-add node2 (memory not onlined)
> # cat /sys/device/system/node/node2/meminfo
> Node 2 MemTotal: 33554432 kB /* corrupted */
> Node 2 MemFree: 0 kB
> Node 2 MemUsed: 33554432 kB
> Node 2 Active: 0 kB
> ......
>
>
> 2. When onlining memory on node2, MemFree of node3 corrupted.
>
> # for ((i = 2048; i < 2064; i++)); do echo online_movable > /sys/devices/system/node/node2/memory$i/state; done
> # cat /sys/devices/system/node/node2/meminfo
> Node 2 MemTotal: 33554432 kB
> Node 2 MemFree: 33549092 kB
> Node 2 MemUsed: 5340 kB
> ......
> # cat /sys/devices/system/node/node3/meminfo
> Node 3 MemTotal: 0 kB
> Node 3 MemFree: 248 kB /* corrupted */
> Node 3 MemUsed: 0 kB
> ......
>
> This patch-set fixes them.
>
> Tang Chen (2):
> mem-hotplug: Reset node managed pages when hot-adding a new pgdat.
> mem-hotplug: Fix wrong check for zone->pageset initialization in
> online_pages().
>
> include/linux/bootmem.h | 1 +
> include/linux/mm.h | 1 +
> mm/bootmem.c | 9 +++++----
> mm/memory_hotplug.c | 15 ++++++++++++++-
> mm/nobootmem.c | 8 +++++---
> mm/page_alloc.c | 5 +++++
> 6 files changed, 31 insertions(+), 8 deletions(-)
>
next prev parent reply other threads:[~2014-11-12 8:39 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-12 8:36 [PATCH 0/2] Fix node meminfo corruption Tang Chen
2014-11-12 8:36 ` Tang Chen
2014-11-12 8:38 ` Tang Chen [this message]
2014-11-12 8:38 ` Tang Chen
-- strict thread matches above, loose matches on Subject: below --
2014-10-31 9:46 Tang Chen
2014-10-31 9:46 ` Tang Chen
2014-11-04 1:10 ` Tang Chen
2014-11-04 1:10 ` Tang Chen
2014-10-31 9:46 Tang Chen
2014-10-31 9:46 ` Tang Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54631C7F.5090905@cn.fujitsu.com \
--to=tangchen@cn.fujitsu.com \
--cc=aarcange@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=fabf@skynet.be \
--cc=grygorii.strashko@ti.com \
--cc=hannes@cmpxchg.org \
--cc=hpa@linux.intel.com \
--cc=isimatu.yasuaki@jp.fujitsu.com \
--cc=kirill.shutemov@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=luto@amacapital.net \
--cc=mgorman@suse.de \
--cc=nzimmer@sgi.com \
--cc=phacht@linux.vnet.ibm.com \
--cc=qiuxishi@huawei.com \
--cc=riel@redhat.com \
--cc=rientjes@google.com \
--cc=tj@kernel.org \
--cc=toshi.kani@hp.com \
--cc=vdavydov@parallels.com \
--cc=wangnan0@huawei.com \
--cc=yinghai@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.