From: maitysanchayan@gmail.com (Sanchayan Maity)
To: linux-arm-kernel@lists.infradead.org
Subject: [[PATCHv2] 2/3] ARM: dts: vfxxx: Add SNVS node
Date: Wed, 12 Nov 2014 14:16:00 +0530 [thread overview]
Message-ID: <54631E48.7090804@gmail.com> (raw)
In-Reply-To: <38daf99040ba00bd5150e7bc73a2fd76@agner.ch>
Hello,
On Wednesday 12 November 2014 02:50 AM, Stefan Agner wrote:
> On 2014-11-07 14:04, Sanchayan Maity wrote:
>> This patch adds a devicetree node for the Secure
>> Non-Volatile Storage (SNVS) on the VF610 platform.
>> The SNVS block also has a Real Time Counter (RTC).
>>
>> Signed-off-by: Sanchayan Maity <maitysanchayan@gmail.com>
>> ---
>> arch/arm/boot/dts/vfxxx.dtsi | 15 +++++++++++++++
>> 1 file changed, 15 insertions(+)
>>
>> diff --git a/arch/arm/boot/dts/vfxxx.dtsi b/arch/arm/boot/dts/vfxxx.dtsi
>> index 4e70833..bc131b0 100644
>> --- a/arch/arm/boot/dts/vfxxx.dtsi
>> +++ b/arch/arm/boot/dts/vfxxx.dtsi
>> @@ -338,6 +338,21 @@
>> status = "disabled";
>> };
>>
>> + snvs0: snvs at 400a7000 {
>> + compatible = "fsl,sec-v4.0-mon", "simple-bus";
>> + #address-cells = <1>;
>> + #size-cells = <1>;
>> + ranges = <0 0x400a7000 0x2000>;
>> +
>> + snvs-rtc-lp at 34 {
>> + compatible = "fsl,sec-v4.0-mon-rtc-lp";
>> + reg = <0x34 0x58>;
>> + interrupts = <0 100 IRQ_TYPE_LEVEL_HIGH>;
>
> With the new device tree structure, the interrupt field needs to be part
> of the vf500.dtsi now. The vfxxx.dtsi will be the parent also for the
> Cortex-M4 device tree, which uses a different interrupt controller.
>
> While at it, use the GIC_SPI macro for the first cell (so this will be
> blend into the other interrupt definitions).
OK. Will fix this and send out a v3. My bad I missed the M4 changes.
>
>> + clocks = <&clks VF610_CLK_SNVS>;
>> + clock-names = "snvs-rtc";
>> + };
>> + };
>> +
>> uart4: serial at 400a9000 {
>> compatible = "fsl,vf610-lpuart";
>> reg = <0x400a9000 0x1000>;
>
Regards,
Sanchayan.
WARNING: multiple messages have this Message-ID (diff)
From: Sanchayan Maity <maitysanchayan@gmail.com>
To: Stefan Agner <stefan@agner.ch>
Cc: rtc-linux@googlegroups.com, shawn.guo@linaro.org,
linux@arm.linux.org.uk, kernel@pengutronix.de,
b35083@freescale.com, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [[PATCHv2] 2/3] ARM: dts: vfxxx: Add SNVS node
Date: Wed, 12 Nov 2014 14:16:00 +0530 [thread overview]
Message-ID: <54631E48.7090804@gmail.com> (raw)
In-Reply-To: <38daf99040ba00bd5150e7bc73a2fd76@agner.ch>
Hello,
On Wednesday 12 November 2014 02:50 AM, Stefan Agner wrote:
> On 2014-11-07 14:04, Sanchayan Maity wrote:
>> This patch adds a devicetree node for the Secure
>> Non-Volatile Storage (SNVS) on the VF610 platform.
>> The SNVS block also has a Real Time Counter (RTC).
>>
>> Signed-off-by: Sanchayan Maity <maitysanchayan@gmail.com>
>> ---
>> arch/arm/boot/dts/vfxxx.dtsi | 15 +++++++++++++++
>> 1 file changed, 15 insertions(+)
>>
>> diff --git a/arch/arm/boot/dts/vfxxx.dtsi b/arch/arm/boot/dts/vfxxx.dtsi
>> index 4e70833..bc131b0 100644
>> --- a/arch/arm/boot/dts/vfxxx.dtsi
>> +++ b/arch/arm/boot/dts/vfxxx.dtsi
>> @@ -338,6 +338,21 @@
>> status = "disabled";
>> };
>>
>> + snvs0: snvs@400a7000 {
>> + compatible = "fsl,sec-v4.0-mon", "simple-bus";
>> + #address-cells = <1>;
>> + #size-cells = <1>;
>> + ranges = <0 0x400a7000 0x2000>;
>> +
>> + snvs-rtc-lp@34 {
>> + compatible = "fsl,sec-v4.0-mon-rtc-lp";
>> + reg = <0x34 0x58>;
>> + interrupts = <0 100 IRQ_TYPE_LEVEL_HIGH>;
>
> With the new device tree structure, the interrupt field needs to be part
> of the vf500.dtsi now. The vfxxx.dtsi will be the parent also for the
> Cortex-M4 device tree, which uses a different interrupt controller.
>
> While at it, use the GIC_SPI macro for the first cell (so this will be
> blend into the other interrupt definitions).
OK. Will fix this and send out a v3. My bad I missed the M4 changes.
>
>> + clocks = <&clks VF610_CLK_SNVS>;
>> + clock-names = "snvs-rtc";
>> + };
>> + };
>> +
>> uart4: serial@400a9000 {
>> compatible = "fsl,vf610-lpuart";
>> reg = <0x400a9000 0x1000>;
>
Regards,
Sanchayan.
next prev parent reply other threads:[~2014-11-12 8:46 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-07 13:04 [[PATCHv2] 0/3] Add SNVS clock gating and clock support to rtc-snvs driver Sanchayan Maity
2014-11-07 13:04 ` Sanchayan Maity
2014-11-07 13:04 ` [[PATCHv2] 1/3] ARM: imx: clk-vf610: Add clock for SNVS Sanchayan Maity
2014-11-07 13:04 ` Sanchayan Maity
2014-11-11 14:49 ` Shawn Guo
2014-11-11 14:49 ` Shawn Guo
2014-11-11 20:58 ` Stefan Agner
2014-11-11 20:58 ` Stefan Agner
2014-11-11 21:13 ` Stefan Agner
2014-11-11 21:13 ` Stefan Agner
2014-11-07 13:04 ` [[PATCHv2] 2/3] ARM: dts: vfxxx: Add SNVS node Sanchayan Maity
2014-11-07 13:04 ` Sanchayan Maity
2014-11-11 21:20 ` Stefan Agner
2014-11-11 21:20 ` Stefan Agner
2014-11-12 8:46 ` Sanchayan Maity [this message]
2014-11-12 8:46 ` Sanchayan Maity
2014-11-07 13:04 ` [[PATCHv2] 3/3] drivers/rtc/rtc-snvs: Add clock support Sanchayan Maity
2014-11-07 13:04 ` Sanchayan Maity
2014-11-11 21:27 ` Stefan Agner
2014-11-11 21:27 ` Stefan Agner
2014-11-12 8:56 ` Sanchayan Maity
2014-11-12 8:56 ` Sanchayan Maity
2014-11-12 10:47 ` Shawn Guo
2014-11-12 10:47 ` Shawn Guo
2014-11-13 5:33 ` Sanchayan Maity
2014-11-13 5:33 ` Sanchayan Maity
2014-11-19 1:17 ` Shawn Guo
2014-11-19 1:17 ` Shawn Guo
2014-11-19 4:49 ` Sanchayan Maity
2014-11-19 4:49 ` Sanchayan Maity
2014-11-28 4:27 ` Sanchayan Maity
2014-11-28 4:27 ` Sanchayan Maity
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54631E48.7090804@gmail.com \
--to=maitysanchayan@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.