From: Tomi Valkeinen <tomi.valkeinen@ti.com>
To: linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 1/4] video: omapdss: Add opa362 driver
Date: Wed, 12 Nov 2014 13:57:55 +0000 [thread overview]
Message-ID: <54636763.10605@ti.com> (raw)
In-Reply-To: <1415051968-4878-2-git-send-email-marek@goldelico.com>
[-- Attachment #1: Type: text/plain, Size: 915 bytes --]
Hi,
On 03/11/14 23:59, Marek Belisko wrote:
> opa362 is amplifier for videoand can be connected to the tvout pads
> of the OMAP3. It has one gpio control for enable/disable of the output
> (high impedance).
>
> Signed-off-by: H. Nikolaus Schaller <hns@goldelico.com>
> ---
> drivers/video/fbdev/omap2/displays-new/Kconfig | 6 +
> drivers/video/fbdev/omap2/displays-new/Makefile | 1 +
> .../fbdev/omap2/displays-new/amplifier-opa362.c | 347 +++++++++++++++++++++
> 3 files changed, 354 insertions(+)
> create mode 100644 drivers/video/fbdev/omap2/displays-new/amplifier-opa362.c
This doesn't even compile:
drivers/video/fbdev/omap2/displays-new/amplifier-opa362.c:207:28: error:
dereferencing pointer to incomplete type
ddata->enable_gpio = pdata->enable_gpio;
And it seems to have fields for bypass and bypass which are handled in
the devconf1 patch.
Tomi
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Tomi Valkeinen <tomi.valkeinen-l0cyMroinI0@public.gmane.org>
To: Marek Belisko <marek-xXXSsgcRVICgSpxsJD1C4w@public.gmane.org>
Cc: robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
pawel.moll-5wv7dgnIgG8@public.gmane.org,
mark.rutland-5wv7dgnIgG8@public.gmane.org,
ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org,
galak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org,
bcousson-rdvid1DuHRBWk0Htik3J/w@public.gmane.org,
tony-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org,
linux-lFZ/pmaqli7XmaaqVzeoHQ@public.gmane.org,
plagnioj-sclMFOaUSTBWk0Htik3J/w@public.gmane.org,
grant.likely-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
linux-fbdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
hns-xXXSsgcRVICgSpxsJD1C4w@public.gmane.org
Subject: Re: [PATCH 1/4] video: omapdss: Add opa362 driver
Date: Wed, 12 Nov 2014 15:57:55 +0200 [thread overview]
Message-ID: <54636763.10605@ti.com> (raw)
In-Reply-To: <1415051968-4878-2-git-send-email-marek-xXXSsgcRVICgSpxsJD1C4w@public.gmane.org>
[-- Attachment #1: Type: text/plain, Size: 941 bytes --]
Hi,
On 03/11/14 23:59, Marek Belisko wrote:
> opa362 is amplifier for videoand can be connected to the tvout pads
> of the OMAP3. It has one gpio control for enable/disable of the output
> (high impedance).
>
> Signed-off-by: H. Nikolaus Schaller <hns-xXXSsgcRVICgSpxsJD1C4w@public.gmane.org>
> ---
> drivers/video/fbdev/omap2/displays-new/Kconfig | 6 +
> drivers/video/fbdev/omap2/displays-new/Makefile | 1 +
> .../fbdev/omap2/displays-new/amplifier-opa362.c | 347 +++++++++++++++++++++
> 3 files changed, 354 insertions(+)
> create mode 100644 drivers/video/fbdev/omap2/displays-new/amplifier-opa362.c
This doesn't even compile:
drivers/video/fbdev/omap2/displays-new/amplifier-opa362.c:207:28: error:
dereferencing pointer to incomplete type
ddata->enable_gpio = pdata->enable_gpio;
And it seems to have fields for bypass and bypass which are handled in
the devconf1 patch.
Tomi
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: tomi.valkeinen@ti.com (Tomi Valkeinen)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/4] video: omapdss: Add opa362 driver
Date: Wed, 12 Nov 2014 15:57:55 +0200 [thread overview]
Message-ID: <54636763.10605@ti.com> (raw)
In-Reply-To: <1415051968-4878-2-git-send-email-marek@goldelico.com>
Hi,
On 03/11/14 23:59, Marek Belisko wrote:
> opa362 is amplifier for videoand can be connected to the tvout pads
> of the OMAP3. It has one gpio control for enable/disable of the output
> (high impedance).
>
> Signed-off-by: H. Nikolaus Schaller <hns@goldelico.com>
> ---
> drivers/video/fbdev/omap2/displays-new/Kconfig | 6 +
> drivers/video/fbdev/omap2/displays-new/Makefile | 1 +
> .../fbdev/omap2/displays-new/amplifier-opa362.c | 347 +++++++++++++++++++++
> 3 files changed, 354 insertions(+)
> create mode 100644 drivers/video/fbdev/omap2/displays-new/amplifier-opa362.c
This doesn't even compile:
drivers/video/fbdev/omap2/displays-new/amplifier-opa362.c:207:28: error:
dereferencing pointer to incomplete type
ddata->enable_gpio = pdata->enable_gpio;
And it seems to have fields for bypass and bypass which are handled in
the devconf1 patch.
Tomi
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: OpenPGP digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20141112/376c65b7/attachment.sig>
WARNING: multiple messages have this Message-ID (diff)
From: Tomi Valkeinen <tomi.valkeinen@ti.com>
To: Marek Belisko <marek@goldelico.com>
Cc: <robh+dt@kernel.org>, <pawel.moll@arm.com>,
<mark.rutland@arm.com>, <ijc+devicetree@hellion.org.uk>,
<galak@codeaurora.org>, <bcousson@baylibre.com>,
<tony@atomide.com>, <linux@arm.linux.org.uk>,
<plagnioj@jcrosoft.com>, <grant.likely@linaro.org>,
<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<linux-omap@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-fbdev@vger.kernel.org>, <hns@goldelico.com>
Subject: Re: [PATCH 1/4] video: omapdss: Add opa362 driver
Date: Wed, 12 Nov 2014 15:57:55 +0200 [thread overview]
Message-ID: <54636763.10605@ti.com> (raw)
In-Reply-To: <1415051968-4878-2-git-send-email-marek@goldelico.com>
[-- Attachment #1: Type: text/plain, Size: 915 bytes --]
Hi,
On 03/11/14 23:59, Marek Belisko wrote:
> opa362 is amplifier for videoand can be connected to the tvout pads
> of the OMAP3. It has one gpio control for enable/disable of the output
> (high impedance).
>
> Signed-off-by: H. Nikolaus Schaller <hns@goldelico.com>
> ---
> drivers/video/fbdev/omap2/displays-new/Kconfig | 6 +
> drivers/video/fbdev/omap2/displays-new/Makefile | 1 +
> .../fbdev/omap2/displays-new/amplifier-opa362.c | 347 +++++++++++++++++++++
> 3 files changed, 354 insertions(+)
> create mode 100644 drivers/video/fbdev/omap2/displays-new/amplifier-opa362.c
This doesn't even compile:
drivers/video/fbdev/omap2/displays-new/amplifier-opa362.c:207:28: error:
dereferencing pointer to incomplete type
ddata->enable_gpio = pdata->enable_gpio;
And it seems to have fields for bypass and bypass which are handled in
the devconf1 patch.
Tomi
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2014-11-12 13:57 UTC|newest]
Thread overview: 86+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-03 21:59 [PATCH 0/4] omapdss: Add video output support for gta04 board Marek Belisko
2014-11-03 21:59 ` Marek Belisko
2014-11-03 21:59 ` Marek Belisko
2014-11-03 21:59 ` Marek Belisko
2014-11-03 21:59 ` [PATCH 1/4] video: omapdss: Add opa362 driver Marek Belisko
2014-11-03 21:59 ` Marek Belisko
2014-11-03 21:59 ` Marek Belisko
2014-11-12 13:57 ` Tomi Valkeinen [this message]
2014-11-12 13:57 ` Tomi Valkeinen
2014-11-12 13:57 ` Tomi Valkeinen
2014-11-12 13:57 ` Tomi Valkeinen
2014-11-12 14:04 ` Belisko Marek
2014-11-12 14:04 ` Belisko Marek
2014-11-12 14:04 ` Belisko Marek
2014-11-03 21:59 ` [PATCH 2/4] Documentation: DT: Add documentation for ti,opa362 bindings Marek Belisko
2014-11-03 21:59 ` [PATCH 2/4] Documentation: DT: Add documentation for ti, opa362 bindings Marek Belisko
2014-11-03 21:59 ` [PATCH 2/4] Documentation: DT: Add documentation for ti,opa362 bindings Marek Belisko
2014-11-12 14:00 ` Tomi Valkeinen
2014-11-12 14:00 ` Tomi Valkeinen
2014-11-12 14:00 ` Tomi Valkeinen
2014-11-12 14:00 ` Tomi Valkeinen
2014-11-03 21:59 ` [PATCH 3/4] arm: dts: omap3-gta04: Add handling for tv output Marek Belisko
2014-11-03 21:59 ` Marek Belisko
2014-11-03 21:59 ` Marek Belisko
2014-11-03 21:59 ` Marek Belisko
2014-11-10 23:30 ` Tony Lindgren
2014-11-10 23:30 ` Tony Lindgren
2014-11-10 23:30 ` Tony Lindgren
2014-11-10 23:30 ` Tony Lindgren
2014-11-11 7:41 ` Tomi Valkeinen
2014-11-11 7:41 ` Tomi Valkeinen
2014-11-11 7:41 ` Tomi Valkeinen
2014-11-11 7:41 ` Tomi Valkeinen
2014-11-11 15:00 ` Tony Lindgren
2014-11-11 15:00 ` Tony Lindgren
2014-11-11 15:00 ` Tony Lindgren
2014-11-03 21:59 ` [PATCH 4/4] arm: dts: omap3-gta04: Add static configuration for devconf1 register Marek Belisko
2014-11-03 21:59 ` Marek Belisko
2014-11-03 21:59 ` Marek Belisko
2014-11-10 23:36 ` Tony Lindgren
2014-11-10 23:36 ` Tony Lindgren
2014-11-10 23:36 ` Tony Lindgren
2014-11-12 21:02 ` Belisko Marek
2014-11-12 21:02 ` Belisko Marek
2014-11-12 21:02 ` Belisko Marek
2014-11-12 21:02 ` Belisko Marek
2014-11-12 21:23 ` Tony Lindgren
2014-11-12 21:23 ` Tony Lindgren
2014-11-12 21:23 ` Tony Lindgren
2014-11-12 12:53 ` Tomi Valkeinen
2014-11-12 12:53 ` Tomi Valkeinen
2014-11-12 12:53 ` Tomi Valkeinen
2014-11-12 12:53 ` Tomi Valkeinen
2014-11-12 15:02 ` Tony Lindgren
2014-11-12 15:02 ` Tony Lindgren
2014-11-12 15:02 ` Tony Lindgren
2014-11-12 15:02 ` Tony Lindgren
2014-11-13 11:31 ` Tomi Valkeinen
2014-11-13 11:31 ` Tomi Valkeinen
2014-11-13 11:31 ` Tomi Valkeinen
2014-11-13 11:31 ` Tomi Valkeinen
2014-11-13 18:28 ` Tony Lindgren
2014-11-13 18:28 ` Tony Lindgren
2014-11-13 18:28 ` Tony Lindgren
2014-11-13 18:28 ` Tony Lindgren
2014-11-13 22:59 ` Paul Walmsley
2014-11-13 22:59 ` Paul Walmsley
2014-11-13 22:59 ` Paul Walmsley
2014-11-13 22:59 ` Paul Walmsley
2014-11-13 23:58 ` Tony Lindgren
2014-11-13 23:58 ` Tony Lindgren
2014-11-13 23:58 ` Tony Lindgren
2014-11-14 7:32 ` Tero Kristo
2014-11-14 7:32 ` Tero Kristo
2014-11-14 7:32 ` Tero Kristo
2014-11-14 7:32 ` Tero Kristo
2014-11-14 18:01 ` Tony Lindgren
2014-11-14 18:01 ` Tony Lindgren
2014-11-14 18:01 ` Tony Lindgren
2014-11-14 14:36 ` Grazvydas Ignotas
2014-11-14 14:36 ` Grazvydas Ignotas
2014-11-14 14:36 ` Grazvydas Ignotas
2014-11-14 15:58 ` Tony Lindgren
2014-11-14 15:58 ` Tony Lindgren
2014-11-14 15:58 ` Tony Lindgren
2014-11-14 15:58 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54636763.10605@ti.com \
--to=tomi.valkeinen@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.