From: Tom Lendacky <thomas.lendacky@amd.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: netdev@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [patch -next] amd-xgbe: fix ->rss_hash_type
Date: Wed, 12 Nov 2014 15:45:40 +0000 [thread overview]
Message-ID: <546380A4.1030105@amd.com> (raw)
In-Reply-To: <20141112083135.GA12795@mwanda>
On 11/12/2014 02:31 AM, Dan Carpenter wrote:
> There was a missing break statement so we set everything to
> PKT_HASH_TYPE_L3 even when we intended to use PKT_HASH_TYPE_L4.
>
> Fixes: 5b9dfe299e55 ('amd-xgbe: Provide support for receive side scaling')
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Tom Lendacky <thomas.lendacky@amd.com>
> ---
> This driver has a lot of Sparse endian warnings.
> http://lwn.net/Articles/205624/
I'll send a patch to address the endian warnings.
Thanks,
Tom
>
> diff --git a/drivers/net/ethernet/amd/xgbe/xgbe-dev.c b/drivers/net/ethernet/amd/xgbe/xgbe-dev.c
> index 7daa2cd..55ba1dc 100644
> --- a/drivers/net/ethernet/amd/xgbe/xgbe-dev.c
> +++ b/drivers/net/ethernet/amd/xgbe/xgbe-dev.c
> @@ -1601,6 +1601,7 @@ static int xgbe_dev_read(struct xgbe_channel *channel)
> case RX_DESC3_L34T_IPV6_UDP:
> packet->rss_hash_type = PKT_HASH_TYPE_L4;
>
> + break;
> default:
> packet->rss_hash_type = PKT_HASH_TYPE_L3;
> }
>
WARNING: multiple messages have this Message-ID (diff)
From: Tom Lendacky <thomas.lendacky@amd.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: <netdev@vger.kernel.org>, <kernel-janitors@vger.kernel.org>
Subject: Re: [patch -next] amd-xgbe: fix ->rss_hash_type
Date: Wed, 12 Nov 2014 09:45:40 -0600 [thread overview]
Message-ID: <546380A4.1030105@amd.com> (raw)
In-Reply-To: <20141112083135.GA12795@mwanda>
On 11/12/2014 02:31 AM, Dan Carpenter wrote:
> There was a missing break statement so we set everything to
> PKT_HASH_TYPE_L3 even when we intended to use PKT_HASH_TYPE_L4.
>
> Fixes: 5b9dfe299e55 ('amd-xgbe: Provide support for receive side scaling')
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Tom Lendacky <thomas.lendacky@amd.com>
> ---
> This driver has a lot of Sparse endian warnings.
> http://lwn.net/Articles/205624/
I'll send a patch to address the endian warnings.
Thanks,
Tom
>
> diff --git a/drivers/net/ethernet/amd/xgbe/xgbe-dev.c b/drivers/net/ethernet/amd/xgbe/xgbe-dev.c
> index 7daa2cd..55ba1dc 100644
> --- a/drivers/net/ethernet/amd/xgbe/xgbe-dev.c
> +++ b/drivers/net/ethernet/amd/xgbe/xgbe-dev.c
> @@ -1601,6 +1601,7 @@ static int xgbe_dev_read(struct xgbe_channel *channel)
> case RX_DESC3_L34T_IPV6_UDP:
> packet->rss_hash_type = PKT_HASH_TYPE_L4;
>
> + break;
> default:
> packet->rss_hash_type = PKT_HASH_TYPE_L3;
> }
>
next prev parent reply other threads:[~2014-11-12 15:45 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-12 8:31 [patch -next] amd-xgbe: fix ->rss_hash_type Dan Carpenter
2014-11-12 8:31 ` Dan Carpenter
2014-11-12 15:45 ` Tom Lendacky [this message]
2014-11-12 15:45 ` Tom Lendacky
2014-11-12 20:04 ` David Miller
2014-11-12 20:04 ` David Miller
2014-11-13 6:19 ` [patch v2 " Dan Carpenter
2014-11-13 6:19 ` Dan Carpenter
2014-11-13 19:40 ` David Miller
2014-11-13 19:40 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=546380A4.1030105@amd.com \
--to=thomas.lendacky@amd.com \
--cc=dan.carpenter@oracle.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.