From: Paolo Bonzini <pbonzini@redhat.com>
To: "Andreas Färber" <afaerber@suse.de>,
"Markus Armbruster" <armbru@redhat.com>,
qemu-devel@nongnu.org
Cc: peter.crosthwaite@xilinx.com
Subject: Re: [Qemu-devel] [PATCH 4/4] Revert "qom: Add automatic arrayification to object_property_add()"
Date: Wed, 12 Nov 2014 23:25:09 +0100 [thread overview]
Message-ID: <5463DE45.1090901@redhat.com> (raw)
In-Reply-To: <54639572.9020206@suse.de>
On 12/11/2014 18:14, Andreas Färber wrote:
>> > This reverts commit 339659041f87a76f8b71ad3d12cadfc5f89b4bb3.
>> >
>> > It's been replaced by object_gen_new_property_name().
>> >
>> > Signed-off-by: Markus Armbruster <armbru@redhat.com>
>> > ---
>> > qom/object.c | 21 ---------------------
>> > 1 file changed, 21 deletions(-)
> Acked-by: Andreas Färber <afaerber@suse.de>
>
> I believe the sole purpose was to share code between memory and gpio
> here.
The plan was to move [*] down into the devices. Devices that do not
need to arrayify properties (e.g. most qdev-ified devices) can then skip
the [*] and have nicer names.
Paolo
next prev parent reply other threads:[~2014-11-12 22:25 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-12 17:08 [Qemu-devel] [PATCH 0/4] qom: Replace "automatic arrayification" Markus Armbruster
2014-11-12 17:08 ` [Qemu-devel] [PATCH 1/4] qom: New object_gen_new_property_name() Markus Armbruster
2014-11-12 17:08 ` [Qemu-devel] [PATCH 2/4] memory: Use object_gen_new_property_name() instead of "arrayification" Markus Armbruster
2014-11-12 17:08 ` [Qemu-devel] [PATCH 3/4] qdev: " Markus Armbruster
2014-11-12 17:08 ` [Qemu-devel] [PATCH 4/4] Revert "qom: Add automatic arrayification to object_property_add()" Markus Armbruster
2014-11-12 17:14 ` Andreas Färber
2014-11-12 22:25 ` Paolo Bonzini [this message]
2014-11-12 22:47 ` Peter Maydell
2014-11-13 10:05 ` Paolo Bonzini
2014-11-13 10:50 ` Peter Maydell
2014-11-12 17:13 ` [Qemu-devel] [PATCH 0/4] qom: Replace "automatic arrayification" Paolo Bonzini
2014-11-13 8:08 ` Markus Armbruster
2014-11-13 10:08 ` Paolo Bonzini
2014-11-13 14:34 ` Markus Armbruster
2014-11-13 14:39 ` Paolo Bonzini
2014-11-14 14:21 ` Markus Armbruster
2014-11-14 14:25 ` Paolo Bonzini
2014-11-14 15:10 ` Markus Armbruster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5463DE45.1090901@redhat.com \
--to=pbonzini@redhat.com \
--cc=afaerber@suse.de \
--cc=armbru@redhat.com \
--cc=peter.crosthwaite@xilinx.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.