* [PATCH 1/9] drm/exynos: remove uneeded declaration of struct dma_iommu_mapping
@ 2014-10-31 14:17 Gustavo Padovan
2014-10-31 14:17 ` [PATCH 2/9] drm/exynos: remove extra declaration of struct exynos_drm_manager Gustavo Padovan
` (9 more replies)
0 siblings, 10 replies; 14+ messages in thread
From: Gustavo Padovan @ 2014-10-31 14:17 UTC (permalink / raw)
To: dri-devel; +Cc: linux-samsung-soc, Gustavo Padovan
From: Gustavo Padovan <gustavo.padovan@collabora.co.uk>
It is not even used in this header anymore.
Signed-off-by: Gustavo Padovan <gustavo.padovan@collabora.co.uk>
---
drivers/gpu/drm/exynos/exynos_drm_iommu.h | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/gpu/drm/exynos/exynos_drm_iommu.h b/drivers/gpu/drm/exynos/exynos_drm_iommu.h
index 72376d4..35d2588 100644
--- a/drivers/gpu/drm/exynos/exynos_drm_iommu.h
+++ b/drivers/gpu/drm/exynos/exynos_drm_iommu.h
@@ -40,7 +40,6 @@ static inline bool is_drm_iommu_supported(struct drm_device *drm_dev)
#else
-struct dma_iommu_mapping;
static inline int drm_create_iommu_mapping(struct drm_device *drm_dev)
{
return 0;
--
1.9.3
^ permalink raw reply related [flat|nested] 14+ messages in thread
* [PATCH 2/9] drm/exynos: remove extra declaration of struct exynos_drm_manager
2014-10-31 14:17 [PATCH 1/9] drm/exynos: remove uneeded declaration of struct dma_iommu_mapping Gustavo Padovan
@ 2014-10-31 14:17 ` Gustavo Padovan
2014-10-31 14:17 ` [PATCH 3/9] drm/exynos: remove extra declaration of struct exynos_overlay Gustavo Padovan
` (8 subsequent siblings)
9 siblings, 0 replies; 14+ messages in thread
From: Gustavo Padovan @ 2014-10-31 14:17 UTC (permalink / raw)
To: dri-devel; +Cc: linux-samsung-soc, Gustavo Padovan
From: Gustavo Padovan <gustavo.padovan@collabora.co.uk>
The struct is defined in the same file, declare it here is just
unnecessary.
Signed-off-by: Gustavo Padovan <gustavo.padovan@collabora.co.uk>
---
drivers/gpu/drm/exynos/exynos_drm_encoder.h | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/gpu/drm/exynos/exynos_drm_encoder.h b/drivers/gpu/drm/exynos/exynos_drm_encoder.h
index b7a1620..26305d8 100644
--- a/drivers/gpu/drm/exynos/exynos_drm_encoder.h
+++ b/drivers/gpu/drm/exynos/exynos_drm_encoder.h
@@ -14,8 +14,6 @@
#ifndef _EXYNOS_DRM_ENCODER_H_
#define _EXYNOS_DRM_ENCODER_H_
-struct exynos_drm_manager;
-
void exynos_drm_encoder_setup(struct drm_device *dev);
struct drm_encoder *exynos_drm_encoder_create(struct drm_device *dev,
struct exynos_drm_display *mgr,
--
1.9.3
^ permalink raw reply related [flat|nested] 14+ messages in thread
* [PATCH 3/9] drm/exynos: remove extra declaration of struct exynos_overlay
2014-10-31 14:17 [PATCH 1/9] drm/exynos: remove uneeded declaration of struct dma_iommu_mapping Gustavo Padovan
2014-10-31 14:17 ` [PATCH 2/9] drm/exynos: remove extra declaration of struct exynos_drm_manager Gustavo Padovan
@ 2014-10-31 14:17 ` Gustavo Padovan
2014-10-31 14:17 ` [PATCH 4/9] drm/exynos: Replace repeated declaration by include <drm/drmP.h> Gustavo Padovan
` (7 subsequent siblings)
9 siblings, 0 replies; 14+ messages in thread
From: Gustavo Padovan @ 2014-10-31 14:17 UTC (permalink / raw)
To: dri-devel; +Cc: linux-samsung-soc, Gustavo Padovan
From: Gustavo Padovan <gustavo.padovan@collabora.co.uk>
The struct is defined in the same file, declare it here is just
unnecessary
Signed-off-by: Gustavo Padovan <gustavo.padovan@collabora.co.uk>
---
drivers/gpu/drm/exynos/exynos_drm_drv.h | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/gpu/drm/exynos/exynos_drm_drv.h b/drivers/gpu/drm/exynos/exynos_drm_drv.h
index 3c81c4b..3905e30 100644
--- a/drivers/gpu/drm/exynos/exynos_drm_drv.h
+++ b/drivers/gpu/drm/exynos/exynos_drm_drv.h
@@ -37,7 +37,6 @@
#define wait_for(COND, MS) _wait_for(COND, MS)
struct drm_device;
-struct exynos_drm_overlay;
struct drm_connector;
/* This enumerates device type. */
--
1.9.3
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] 14+ messages in thread
* [PATCH 4/9] drm/exynos: Replace repeated declaration by include <drm/drmP.h>
2014-10-31 14:17 [PATCH 1/9] drm/exynos: remove uneeded declaration of struct dma_iommu_mapping Gustavo Padovan
2014-10-31 14:17 ` [PATCH 2/9] drm/exynos: remove extra declaration of struct exynos_drm_manager Gustavo Padovan
2014-10-31 14:17 ` [PATCH 3/9] drm/exynos: remove extra declaration of struct exynos_overlay Gustavo Padovan
@ 2014-10-31 14:17 ` Gustavo Padovan
2014-10-31 14:17 ` [PATCH 5/9] drm/exynos: Replace repeated declarations by #include "exynos_drm_drv.h" Gustavo Padovan
` (6 subsequent siblings)
9 siblings, 0 replies; 14+ messages in thread
From: Gustavo Padovan @ 2014-10-31 14:17 UTC (permalink / raw)
To: dri-devel; +Cc: linux-samsung-soc, Gustavo Padovan
From: Gustavo Padovan <gustavo.padovan@collabora.co.uk>
Re-declare struct is not a good practice, let's use the original
drm declarations.
Signed-off-by: Gustavo Padovan <gustavo.padovan@collabora.co.uk>
---
drivers/gpu/drm/exynos/exynos_drm_drv.h | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/exynos/exynos_drm_drv.h b/drivers/gpu/drm/exynos/exynos_drm_drv.h
index 3905e30..7806981 100644
--- a/drivers/gpu/drm/exynos/exynos_drm_drv.h
+++ b/drivers/gpu/drm/exynos/exynos_drm_drv.h
@@ -15,6 +15,7 @@
#ifndef _EXYNOS_DRM_DRV_H_
#define _EXYNOS_DRM_DRV_H_
+#include <drm/drmP.h>
#include <linux/module.h>
#define MAX_CRTC 3
@@ -36,9 +37,6 @@
#define wait_for(COND, MS) _wait_for(COND, MS)
-struct drm_device;
-struct drm_connector;
-
/* This enumerates device type. */
enum exynos_drm_device_type {
EXYNOS_DEVICE_TYPE_NONE,
--
1.9.3
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] 14+ messages in thread
* [PATCH 5/9] drm/exynos: Replace repeated declarations by #include "exynos_drm_drv.h"
2014-10-31 14:17 [PATCH 1/9] drm/exynos: remove uneeded declaration of struct dma_iommu_mapping Gustavo Padovan
` (2 preceding siblings ...)
2014-10-31 14:17 ` [PATCH 4/9] drm/exynos: Replace repeated declaration by include <drm/drmP.h> Gustavo Padovan
@ 2014-10-31 14:17 ` Gustavo Padovan
2014-10-31 14:17 ` [PATCH 6/9] drm/exynos: remove unused wait_for macro Gustavo Padovan
` (5 subsequent siblings)
9 siblings, 0 replies; 14+ messages in thread
From: Gustavo Padovan @ 2014-10-31 14:17 UTC (permalink / raw)
To: dri-devel; +Cc: linux-samsung-soc, Gustavo Padovan
From: Gustavo Padovan <gustavo.padovan@collabora.co.uk>
Re-declare struct is not a good practice, let's use the original
drm and exynos declarations.
Signed-off-by: Gustavo Padovan <gustavo.padovan@collabora.co.uk>
---
drivers/gpu/drm/exynos/exynos_drm_crtc.h | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/drivers/gpu/drm/exynos/exynos_drm_crtc.h b/drivers/gpu/drm/exynos/exynos_drm_crtc.h
index 690dcdd..e353d35 100644
--- a/drivers/gpu/drm/exynos/exynos_drm_crtc.h
+++ b/drivers/gpu/drm/exynos/exynos_drm_crtc.h
@@ -15,10 +15,7 @@
#ifndef _EXYNOS_DRM_CRTC_H_
#define _EXYNOS_DRM_CRTC_H_
-struct drm_device;
-struct drm_crtc;
-struct exynos_drm_manager;
-struct exynos_drm_overlay;
+#include "exynos_drm_drv.h"
int exynos_drm_crtc_create(struct exynos_drm_manager *manager);
int exynos_drm_crtc_enable_vblank(struct drm_device *dev, int pipe);
--
1.9.3
^ permalink raw reply related [flat|nested] 14+ messages in thread
* [PATCH 6/9] drm/exynos: remove unused wait_for macro
2014-10-31 14:17 [PATCH 1/9] drm/exynos: remove uneeded declaration of struct dma_iommu_mapping Gustavo Padovan
` (3 preceding siblings ...)
2014-10-31 14:17 ` [PATCH 5/9] drm/exynos: Replace repeated declarations by #include "exynos_drm_drv.h" Gustavo Padovan
@ 2014-10-31 14:17 ` Gustavo Padovan
2014-10-31 14:17 ` [PATCH 7/9] drm/exynos: Save up space using bool var as bitfields Gustavo Padovan
` (4 subsequent siblings)
9 siblings, 0 replies; 14+ messages in thread
From: Gustavo Padovan @ 2014-10-31 14:17 UTC (permalink / raw)
To: dri-devel; +Cc: linux-samsung-soc, Gustavo Padovan
From: Gustavo Padovan <gustavo.padovan@collabora.co.uk>
This is a leftover, all code using this macro have been removed/
changed already.
Signed-off-by: Gustavo Padovan <gustavo.padovan@collabora.co.uk>
---
drivers/gpu/drm/exynos/exynos_drm_drv.h | 14 --------------
1 file changed, 14 deletions(-)
diff --git a/drivers/gpu/drm/exynos/exynos_drm_drv.h b/drivers/gpu/drm/exynos/exynos_drm_drv.h
index 7806981..9e4a7e1 100644
--- a/drivers/gpu/drm/exynos/exynos_drm_drv.h
+++ b/drivers/gpu/drm/exynos/exynos_drm_drv.h
@@ -23,20 +23,6 @@
#define MAX_FB_BUFFER 4
#define DEFAULT_ZPOS -1
-#define _wait_for(COND, MS) ({ \
- unsigned long timeout__ = jiffies + msecs_to_jiffies(MS); \
- int ret__ = 0; \
- while (!(COND)) { \
- if (time_after(jiffies, timeout__)) { \
- ret__ = -ETIMEDOUT; \
- break; \
- } \
- } \
- ret__; \
-})
-
-#define wait_for(COND, MS) _wait_for(COND, MS)
-
/* This enumerates device type. */
enum exynos_drm_device_type {
EXYNOS_DEVICE_TYPE_NONE,
--
1.9.3
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] 14+ messages in thread
* [PATCH 7/9] drm/exynos: Save up space using bool var as bitfields
2014-10-31 14:17 [PATCH 1/9] drm/exynos: remove uneeded declaration of struct dma_iommu_mapping Gustavo Padovan
` (4 preceding siblings ...)
2014-10-31 14:17 ` [PATCH 6/9] drm/exynos: remove unused wait_for macro Gustavo Padovan
@ 2014-10-31 14:17 ` Gustavo Padovan
2014-10-31 14:17 ` [PATCH 8/9] drm/exynos: update documentation to reflect code changes Gustavo Padovan
` (3 subsequent siblings)
9 siblings, 0 replies; 14+ messages in thread
From: Gustavo Padovan @ 2014-10-31 14:17 UTC (permalink / raw)
To: dri-devel; +Cc: linux-samsung-soc, Gustavo Padovan
From: Gustavo Padovan <gustavo.padovan@collabora.co.uk>
Save a few bytes by compiling them all in the same byte.
Signed-off-by: Gustavo Padovan <gustavo.padovan@collabora.co.uk>
---
drivers/gpu/drm/exynos/exynos_drm_drv.h | 16 ++++++++--------
1 file changed, 8 insertions(+), 8 deletions(-)
diff --git a/drivers/gpu/drm/exynos/exynos_drm_drv.h b/drivers/gpu/drm/exynos/exynos_drm_drv.h
index 9e4a7e1..f77e6aa 100644
--- a/drivers/gpu/drm/exynos/exynos_drm_drv.h
+++ b/drivers/gpu/drm/exynos/exynos_drm_drv.h
@@ -66,10 +66,10 @@ enum exynos_drm_output_type {
* @dma_addr: array of bus(accessed by dma) address to the memory region
* allocated for a overlay.
* @zpos: order of overlay layer(z position).
- * @default_win: a window to be enabled.
- * @color_key: color key on or off.
* @index_color: if using color key feature then this value would be used
* as index color.
+ * @default_win: a window to be enabled.
+ * @color_key: color key on or off.
* @local_path: in case of lcd type, local path mode on or off.
* @transparency: transparency on or off.
* @activated: activated or not.
@@ -97,13 +97,13 @@ struct exynos_drm_overlay {
uint32_t pixel_format;
dma_addr_t dma_addr[MAX_FB_BUFFER];
int zpos;
-
- bool default_win;
- bool color_key;
unsigned int index_color;
- bool local_path;
- bool transparency;
- bool activated;
+
+ bool default_win:1;
+ bool color_key:1;
+ bool local_path:1;
+ bool transparency:1;
+ bool activated:1;
};
/*
--
1.9.3
^ permalink raw reply related [flat|nested] 14+ messages in thread
* [PATCH 8/9] drm/exynos: update documentation to reflect code changes
2014-10-31 14:17 [PATCH 1/9] drm/exynos: remove uneeded declaration of struct dma_iommu_mapping Gustavo Padovan
` (5 preceding siblings ...)
2014-10-31 14:17 ` [PATCH 7/9] drm/exynos: Save up space using bool var as bitfields Gustavo Padovan
@ 2014-10-31 14:17 ` Gustavo Padovan
2014-10-31 14:17 ` [PATCH 9/9] drm/exynos: remove leftover hdmi function declarations Gustavo Padovan
` (2 subsequent siblings)
9 siblings, 0 replies; 14+ messages in thread
From: Gustavo Padovan @ 2014-10-31 14:17 UTC (permalink / raw)
To: dri-devel; +Cc: linux-samsung-soc, Gustavo Padovan
From: Gustavo Padovan <gustavo.padovan@collabora.co.uk>
Description of the @create_connector callback was missing,
and the @manager was no longer needed.
Signed-off-by: Gustavo Padovan <gustavo.padovan@collabora.co.uk>
---
drivers/gpu/drm/exynos/exynos_drm_drv.h | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/exynos/exynos_drm_drv.h b/drivers/gpu/drm/exynos/exynos_drm_drv.h
index f77e6aa..e762cbb 100644
--- a/drivers/gpu/drm/exynos/exynos_drm_drv.h
+++ b/drivers/gpu/drm/exynos/exynos_drm_drv.h
@@ -110,6 +110,7 @@ struct exynos_drm_overlay {
* Exynos DRM Display Structure.
* - this structure is common to analog tv, digital tv and lcd panel.
*
+ * @create_connector: initialize and register a new connector
* @remove: cleans up the display for removal
* @mode_fixup: fix mode data comparing to hw specific display mode.
* @mode_set: convert drm_display_mode to hw specific display mode and
@@ -262,8 +263,6 @@ struct exynos_drm_private {
* @dev: pointer to device object for subdrv device driver.
* @drm_dev: pointer to drm_device and this pointer would be set
* when sub driver calls exynos_drm_subdrv_register().
- * @manager: subdrv has its own manager to control a hardware appropriately
- * and we can access a hardware drawing on this manager.
* @probe: this callback would be called by exynos drm driver after
* subdrv is registered to it.
* @remove: this callback is used to release resources created
--
1.9.3
^ permalink raw reply related [flat|nested] 14+ messages in thread
* [PATCH 9/9] drm/exynos: remove leftover hdmi function declarations
2014-10-31 14:17 [PATCH 1/9] drm/exynos: remove uneeded declaration of struct dma_iommu_mapping Gustavo Padovan
` (6 preceding siblings ...)
2014-10-31 14:17 ` [PATCH 8/9] drm/exynos: update documentation to reflect code changes Gustavo Padovan
@ 2014-10-31 14:17 ` Gustavo Padovan
2014-11-06 12:38 ` [PATCH 1/9] drm/exynos: remove uneeded declaration of struct dma_iommu_mapping Gustavo Padovan
2014-11-13 8:45 ` Inki Dae
9 siblings, 0 replies; 14+ messages in thread
From: Gustavo Padovan @ 2014-10-31 14:17 UTC (permalink / raw)
To: dri-devel; +Cc: linux-samsung-soc, Gustavo Padovan
From: Gustavo Padovan <gustavo.padovan@collabora.co.uk>
They are not implemented anywhere, so wipe them out.
Signed-off-by: Gustavo Padovan <gustavo.padovan@collabora.co.uk>
---
drivers/gpu/drm/exynos/exynos_drm_drv.h | 11 -----------
1 file changed, 11 deletions(-)
diff --git a/drivers/gpu/drm/exynos/exynos_drm_drv.h b/drivers/gpu/drm/exynos/exynos_drm_drv.h
index e762cbb..262a459 100644
--- a/drivers/gpu/drm/exynos/exynos_drm_drv.h
+++ b/drivers/gpu/drm/exynos/exynos_drm_drv.h
@@ -294,17 +294,6 @@ int exynos_drm_device_subdrv_remove(struct drm_device *dev);
int exynos_drm_subdrv_open(struct drm_device *dev, struct drm_file *file);
void exynos_drm_subdrv_close(struct drm_device *dev, struct drm_file *file);
-/*
- * this function registers exynos drm hdmi platform device. It ensures only one
- * instance of the device is created.
- */
-int exynos_platform_device_hdmi_register(void);
-
-/*
- * this function unregisters exynos drm hdmi platform device if it exists.
- */
-void exynos_platform_device_hdmi_unregister(void);
-
#ifdef CONFIG_DRM_EXYNOS_IPP
int exynos_platform_device_ipp_register(void);
void exynos_platform_device_ipp_unregister(void);
--
1.9.3
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] 14+ messages in thread
* Re: [PATCH 1/9] drm/exynos: remove uneeded declaration of struct dma_iommu_mapping
2014-10-31 14:17 [PATCH 1/9] drm/exynos: remove uneeded declaration of struct dma_iommu_mapping Gustavo Padovan
` (7 preceding siblings ...)
2014-10-31 14:17 ` [PATCH 9/9] drm/exynos: remove leftover hdmi function declarations Gustavo Padovan
@ 2014-11-06 12:38 ` Gustavo Padovan
2014-11-06 12:44 ` Inki Dae
2014-11-13 8:45 ` Inki Dae
9 siblings, 1 reply; 14+ messages in thread
From: Gustavo Padovan @ 2014-11-06 12:38 UTC (permalink / raw)
To: dri-devel; +Cc: linux-samsung-soc, Inki Dae
Hi Inki,
Could you please give a review to this series?
Thanks.
Gustavo
2014-10-31 Gustavo Padovan <gustavo@padovan.org>:
> From: Gustavo Padovan <gustavo.padovan@collabora.co.uk>
>
> It is not even used in this header anymore.
>
> Signed-off-by: Gustavo Padovan <gustavo.padovan@collabora.co.uk>
> ---
> drivers/gpu/drm/exynos/exynos_drm_iommu.h | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/exynos/exynos_drm_iommu.h b/drivers/gpu/drm/exynos/exynos_drm_iommu.h
> index 72376d4..35d2588 100644
> --- a/drivers/gpu/drm/exynos/exynos_drm_iommu.h
> +++ b/drivers/gpu/drm/exynos/exynos_drm_iommu.h
> @@ -40,7 +40,6 @@ static inline bool is_drm_iommu_supported(struct drm_device *drm_dev)
>
> #else
>
> -struct dma_iommu_mapping;
> static inline int drm_create_iommu_mapping(struct drm_device *drm_dev)
> {
> return 0;
> --
> 1.9.3
>
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH 1/9] drm/exynos: remove uneeded declaration of struct dma_iommu_mapping
2014-11-06 12:38 ` [PATCH 1/9] drm/exynos: remove uneeded declaration of struct dma_iommu_mapping Gustavo Padovan
@ 2014-11-06 12:44 ` Inki Dae
2014-11-12 14:13 ` Gustavo Padovan
0 siblings, 1 reply; 14+ messages in thread
From: Inki Dae @ 2014-11-06 12:44 UTC (permalink / raw)
To: Gustavo Padovan; +Cc: dri-devel, linux-samsung-soc
Hi Gustavo,
On 2014년 11월 06일 21:38, Gustavo Padovan wrote:
>
> Hi Inki,
>
> Could you please give a review to this series?
It looks good to me. This patch series is just cleanup but not test so I
will merge them next week after testing if there is no any comment.
Thanks,
Inki Dae
>
> Thanks.
>
> Gustavo
>
> 2014-10-31 Gustavo Padovan <gustavo@padovan.org>:
>
>> From: Gustavo Padovan <gustavo.padovan@collabora.co.uk>
>>
>> It is not even used in this header anymore.
>>
>> Signed-off-by: Gustavo Padovan <gustavo.padovan@collabora.co.uk>
>> ---
>> drivers/gpu/drm/exynos/exynos_drm_iommu.h | 1 -
>> 1 file changed, 1 deletion(-)
>>
>> diff --git a/drivers/gpu/drm/exynos/exynos_drm_iommu.h b/drivers/gpu/drm/exynos/exynos_drm_iommu.h
>> index 72376d4..35d2588 100644
>> --- a/drivers/gpu/drm/exynos/exynos_drm_iommu.h
>> +++ b/drivers/gpu/drm/exynos/exynos_drm_iommu.h
>> @@ -40,7 +40,6 @@ static inline bool is_drm_iommu_supported(struct drm_device *drm_dev)
>>
>> #else
>>
>> -struct dma_iommu_mapping;
>> static inline int drm_create_iommu_mapping(struct drm_device *drm_dev)
>> {
>> return 0;
>> --
>> 1.9.3
>>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH 1/9] drm/exynos: remove uneeded declaration of struct dma_iommu_mapping
2014-11-06 12:44 ` Inki Dae
@ 2014-11-12 14:13 ` Gustavo Padovan
2014-11-13 2:22 ` Inki Dae
0 siblings, 1 reply; 14+ messages in thread
From: Gustavo Padovan @ 2014-11-12 14:13 UTC (permalink / raw)
To: Inki Dae; +Cc: linux-samsung-soc, dri-devel
Hi Inki,
2014-11-06 Inki Dae <inki.dae@samsung.com>:
>
> Hi Gustavo,
>
> On 2014년 11월 06일 21:38, Gustavo Padovan wrote:
> >
> > Hi Inki,
> >
> > Could you please give a review to this series?
>
> It looks good to me. This patch series is just cleanup but not test so I
> will merge them next week after testing if there is no any comment.
Is there any comments on this series or are the patches ready to be merged?
Thanks
Gustavo
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH 1/9] drm/exynos: remove uneeded declaration of struct dma_iommu_mapping
2014-11-12 14:13 ` Gustavo Padovan
@ 2014-11-13 2:22 ` Inki Dae
0 siblings, 0 replies; 14+ messages in thread
From: Inki Dae @ 2014-11-13 2:22 UTC (permalink / raw)
To: Gustavo Padovan; +Cc: linux-samsung-soc, dri-devel
Sorry for late.
I started to test and migrate them to exynos-drm-next yesterday. So I
guess that you can see your patch series on exynos-drm-next today night
or tomorrow.
Thanks,
Inki Dae
On 2014년 11월 12일 23:13, Gustavo Padovan wrote:
> Hi Inki,
>
> 2014-11-06 Inki Dae <inki.dae@samsung.com>:
>
>>
>> Hi Gustavo,
>>
>> On 2014년 11월 06일 21:38, Gustavo Padovan wrote:
>>>
>>> Hi Inki,
>>>
>>> Could you please give a review to this series?
>>
>> It looks good to me. This patch series is just cleanup but not test so I
>> will merge them next week after testing if there is no any comment.
>
> Is there any comments on this series or are the patches ready to be merged?
>
> Thanks
>
> Gustavo
> --
> To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH 1/9] drm/exynos: remove uneeded declaration of struct dma_iommu_mapping
2014-10-31 14:17 [PATCH 1/9] drm/exynos: remove uneeded declaration of struct dma_iommu_mapping Gustavo Padovan
` (8 preceding siblings ...)
2014-11-06 12:38 ` [PATCH 1/9] drm/exynos: remove uneeded declaration of struct dma_iommu_mapping Gustavo Padovan
@ 2014-11-13 8:45 ` Inki Dae
9 siblings, 0 replies; 14+ messages in thread
From: Inki Dae @ 2014-11-13 8:45 UTC (permalink / raw)
To: Gustavo Padovan; +Cc: linux-samsung-soc, Gustavo Padovan, dri-devel
On 2014년 10월 31일 23:17, Gustavo Padovan wrote:
> From: Gustavo Padovan <gustavo.padovan@collabora.co.uk>
>
> It is not even used in this header anymore.
All patches, Applied.
Thanks,
Inki Dae
>
> Signed-off-by: Gustavo Padovan <gustavo.padovan@collabora.co.uk>
> ---
> drivers/gpu/drm/exynos/exynos_drm_iommu.h | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/exynos/exynos_drm_iommu.h b/drivers/gpu/drm/exynos/exynos_drm_iommu.h
> index 72376d4..35d2588 100644
> --- a/drivers/gpu/drm/exynos/exynos_drm_iommu.h
> +++ b/drivers/gpu/drm/exynos/exynos_drm_iommu.h
> @@ -40,7 +40,6 @@ static inline bool is_drm_iommu_supported(struct drm_device *drm_dev)
>
> #else
>
> -struct dma_iommu_mapping;
> static inline int drm_create_iommu_mapping(struct drm_device *drm_dev)
> {
> return 0;
>
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 14+ messages in thread
end of thread, other threads:[~2014-11-13 8:45 UTC | newest]
Thread overview: 14+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-10-31 14:17 [PATCH 1/9] drm/exynos: remove uneeded declaration of struct dma_iommu_mapping Gustavo Padovan
2014-10-31 14:17 ` [PATCH 2/9] drm/exynos: remove extra declaration of struct exynos_drm_manager Gustavo Padovan
2014-10-31 14:17 ` [PATCH 3/9] drm/exynos: remove extra declaration of struct exynos_overlay Gustavo Padovan
2014-10-31 14:17 ` [PATCH 4/9] drm/exynos: Replace repeated declaration by include <drm/drmP.h> Gustavo Padovan
2014-10-31 14:17 ` [PATCH 5/9] drm/exynos: Replace repeated declarations by #include "exynos_drm_drv.h" Gustavo Padovan
2014-10-31 14:17 ` [PATCH 6/9] drm/exynos: remove unused wait_for macro Gustavo Padovan
2014-10-31 14:17 ` [PATCH 7/9] drm/exynos: Save up space using bool var as bitfields Gustavo Padovan
2014-10-31 14:17 ` [PATCH 8/9] drm/exynos: update documentation to reflect code changes Gustavo Padovan
2014-10-31 14:17 ` [PATCH 9/9] drm/exynos: remove leftover hdmi function declarations Gustavo Padovan
2014-11-06 12:38 ` [PATCH 1/9] drm/exynos: remove uneeded declaration of struct dma_iommu_mapping Gustavo Padovan
2014-11-06 12:44 ` Inki Dae
2014-11-12 14:13 ` Gustavo Padovan
2014-11-13 2:22 ` Inki Dae
2014-11-13 8:45 ` Inki Dae
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.