From: Max Reitz <mreitz@redhat.com>
To: Markus Armbruster <armbru@redhat.com>, qemu-devel@nongnu.org
Cc: kwolf@redhat.com, famz@redhat.com, tony@bakeyournoodle.com,
stefanha@redhat.com, pbonzini@redhat.com
Subject: Re: [Qemu-devel] [PATCH v2 3/4] raw-posix: Fix try_seek_hole()'s handling of SEEK_DATA failure
Date: Thu, 13 Nov 2014 11:22:26 +0100 [thread overview]
Message-ID: <54648662.4030709@redhat.com> (raw)
In-Reply-To: <1415873823-13844-4-git-send-email-armbru@redhat.com>
On 2014-11-13 at 11:17, Markus Armbruster wrote:
> When SEEK_HOLE tells us we're in a hole, we try SEEK_DATA to find its
> end. When that fails, we pretend the hole extends to the end of file.
> Wrong. Except when SEEK_END fails, we screw up and claim it extends
> to offset -1. More wrong.
>
> Fortunately, these seeks are very unlikely to fail. Fix it anyway, by
> returning failure. The caller will then pretend there are no holes.
> Inaccurate, but safe.
>
> Signed-off-by: Markus Armbruster <armbru@redhat.com>
> ---
> block/raw-posix.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
Reviewed-by: Max Reitz <mreitz@redhat.com>
next prev parent reply other threads:[~2014-11-13 10:22 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-13 10:16 [Qemu-devel] [PATCH v2 0/4] raw-posix: Get rid of FIEMAP, and more Markus Armbruster
2014-11-13 10:17 ` [Qemu-devel] [PATCH v2 1/4] raw-posix: Fix comment for raw_co_get_block_status() Markus Armbruster
2014-11-13 10:17 ` [Qemu-devel] [PATCH v2 2/4] raw-posix: SEEK_HOLE suffices, get rid of FIEMAP Markus Armbruster
2014-11-13 10:19 ` Max Reitz
2014-11-13 14:09 ` Eric Blake
2014-11-13 10:17 ` [Qemu-devel] [PATCH v2 3/4] raw-posix: Fix try_seek_hole()'s handling of SEEK_DATA failure Markus Armbruster
2014-11-13 10:22 ` Max Reitz [this message]
2014-11-13 13:03 ` Kevin Wolf
2014-11-13 14:52 ` Eric Blake
2014-11-13 15:29 ` Eric Blake
2014-11-13 15:44 ` Max Reitz
2014-11-13 15:49 ` Eric Blake
2014-11-13 15:52 ` Eric Blake
2014-11-13 15:47 ` Eric Blake
2014-11-13 16:01 ` Eric Blake
2014-11-14 13:12 ` Markus Armbruster
2014-11-15 0:47 ` Eric Blake
2014-11-13 10:17 ` [Qemu-devel] [PATCH v2 4/4] raw-posix: Clean up around raw_co_get_block_status() Markus Armbruster
2014-11-13 10:27 ` Max Reitz
2014-11-13 12:48 ` Markus Armbruster
2014-11-13 13:30 ` [Qemu-devel] [PATCH v2 0/4] raw-posix: Get rid of FIEMAP, and more Eric Blake
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54648662.4030709@redhat.com \
--to=mreitz@redhat.com \
--cc=armbru@redhat.com \
--cc=famz@redhat.com \
--cc=kwolf@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
--cc=tony@bakeyournoodle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.