From: Eric Blake <eblake@redhat.com>
To: Markus Armbruster <armbru@redhat.com>, qemu-devel@nongnu.org
Cc: kwolf@redhat.com, famz@redhat.com, tony@bakeyournoodle.com,
mreitz@redhat.com, stefanha@redhat.com, pbonzini@redhat.com
Subject: Re: [Qemu-devel] [PATCH v2 2/4] raw-posix: SEEK_HOLE suffices, get rid of FIEMAP
Date: Thu, 13 Nov 2014 07:09:46 -0700 [thread overview]
Message-ID: <5464BBAA.8090404@redhat.com> (raw)
In-Reply-To: <1415873823-13844-3-git-send-email-armbru@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 635 bytes --]
On 11/13/2014 03:17 AM, Markus Armbruster wrote:
> Commit 5500316 (May 2012) implemented raw_co_is_allocated() as
> follows:
>
> "Fortunately", the FIEMAP code is used only when
>
> * SEEK_HOLE/SEEK_DATA arent't defined, but CONFIG_FIEMAP is
s/arent't/aren't/
> Signed-off-by: Markus Armbruster <armbru@redhat.com>
> ---
> block/raw-posix.c | 60 ++++---------------------------------------------------
> 1 file changed, 4 insertions(+), 56 deletions(-)
Reviewed-by: Eric Blake <eblake@redhat.com>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 539 bytes --]
next prev parent reply other threads:[~2014-11-13 14:10 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-13 10:16 [Qemu-devel] [PATCH v2 0/4] raw-posix: Get rid of FIEMAP, and more Markus Armbruster
2014-11-13 10:17 ` [Qemu-devel] [PATCH v2 1/4] raw-posix: Fix comment for raw_co_get_block_status() Markus Armbruster
2014-11-13 10:17 ` [Qemu-devel] [PATCH v2 2/4] raw-posix: SEEK_HOLE suffices, get rid of FIEMAP Markus Armbruster
2014-11-13 10:19 ` Max Reitz
2014-11-13 14:09 ` Eric Blake [this message]
2014-11-13 10:17 ` [Qemu-devel] [PATCH v2 3/4] raw-posix: Fix try_seek_hole()'s handling of SEEK_DATA failure Markus Armbruster
2014-11-13 10:22 ` Max Reitz
2014-11-13 13:03 ` Kevin Wolf
2014-11-13 14:52 ` Eric Blake
2014-11-13 15:29 ` Eric Blake
2014-11-13 15:44 ` Max Reitz
2014-11-13 15:49 ` Eric Blake
2014-11-13 15:52 ` Eric Blake
2014-11-13 15:47 ` Eric Blake
2014-11-13 16:01 ` Eric Blake
2014-11-14 13:12 ` Markus Armbruster
2014-11-15 0:47 ` Eric Blake
2014-11-13 10:17 ` [Qemu-devel] [PATCH v2 4/4] raw-posix: Clean up around raw_co_get_block_status() Markus Armbruster
2014-11-13 10:27 ` Max Reitz
2014-11-13 12:48 ` Markus Armbruster
2014-11-13 13:30 ` [Qemu-devel] [PATCH v2 0/4] raw-posix: Get rid of FIEMAP, and more Eric Blake
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5464BBAA.8090404@redhat.com \
--to=eblake@redhat.com \
--cc=armbru@redhat.com \
--cc=famz@redhat.com \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
--cc=tony@bakeyournoodle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.