From: James Hogan <james.hogan@imgtec.com>
To: Jude Abraham <Jude.Abraham@imgtec.com>,
Andrew Bresticker <abrestic@chromium.org>,
Naidu Tellapati <Naidu.Tellapati@imgtec.com>
Cc: "wim@iguana.be" <wim@iguana.be>,
"linux@roeck-us.net" <linux@roeck-us.net>,
James Hartley <James.Hartley@imgtec.com>,
"Ezequiel Garcia" <Ezequiel.Garcia@imgtec.com>,
"linux-watchdog@vger.kernel.org" <linux-watchdog@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>
Subject: Re: [PATCH 2/2] DT: watchdog: Add ImgTec PDC Watchdog Timer binding documentation
Date: Thu, 13 Nov 2014 13:08:27 +0000 [thread overview]
Message-ID: <5464AD4B.1000509@imgtec.com> (raw)
In-Reply-To: <89F3BC60EA3A0141B1F6C2A661D95E5E3F192BAA@hbmail01.hb.imgtec.org>
Hi,
On 13/11/14 12:58, Jude Abraham wrote:
> On Wed, Nov 12, 2014 at 7:18 AM, <Naidu.Tellapati@imgtec.com> wrote:
>>> diff --git a/Documentation/devicetree/bindings/watchdog/imgpdc-wdt.txt
>>> +- interrupts : Should contain WDT interrupt
>
>> Not sure the interrupt will really be necessary.
>
> Ok, We will remove the interrupt.
Regardless, there is still an interrupt line coming out of the WDT and
interrupt status/clear/enable registers for the single reminder
interrupt. IMO it makes sense to describe it in DT even if the driver
doesn't [yet] make use it.
BTW, please do CC me on future versions of this patchset.
Cheers
James
WARNING: multiple messages have this Message-ID (diff)
From: James Hogan <james.hogan-1AXoQHu6uovQT0dZR+AlfA@public.gmane.org>
To: Jude Abraham
<Jude.Abraham-1AXoQHu6uovQT0dZR+AlfA@public.gmane.org>,
Andrew Bresticker
<abrestic-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>,
Naidu Tellapati
<Naidu.Tellapati-1AXoQHu6uovQT0dZR+AlfA@public.gmane.org>
Cc: "wim-IQzOog9fTRqzQB+pC5nmwQ@public.gmane.org"
<wim-IQzOog9fTRqzQB+pC5nmwQ@public.gmane.org>,
"linux-0h96xk9xTtrk1uMJSBkQmQ@public.gmane.org"
<linux-0h96xk9xTtrk1uMJSBkQmQ@public.gmane.org>,
James Hartley
<James.Hartley-1AXoQHu6uovQT0dZR+AlfA@public.gmane.org>,
Ezequiel Garcia
<Ezequiel.Garcia-1AXoQHu6uovQT0dZR+AlfA@public.gmane.org>,
"linux-watchdog-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<linux-watchdog-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
"devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: Re: [PATCH 2/2] DT: watchdog: Add ImgTec PDC Watchdog Timer binding documentation
Date: Thu, 13 Nov 2014 13:08:27 +0000 [thread overview]
Message-ID: <5464AD4B.1000509@imgtec.com> (raw)
In-Reply-To: <89F3BC60EA3A0141B1F6C2A661D95E5E3F192BAA-C8yLA94LPOy3snIXRfWIHVBRoQTxkR7k@public.gmane.org>
Hi,
On 13/11/14 12:58, Jude Abraham wrote:
> On Wed, Nov 12, 2014 at 7:18 AM, <Naidu.Tellapati-1AXoQHu6uovQT0dZR+AlfA@public.gmane.org> wrote:
>>> diff --git a/Documentation/devicetree/bindings/watchdog/imgpdc-wdt.txt
>>> +- interrupts : Should contain WDT interrupt
>
>> Not sure the interrupt will really be necessary.
>
> Ok, We will remove the interrupt.
Regardless, there is still an interrupt line coming out of the WDT and
interrupt status/clear/enable registers for the single reminder
interrupt. IMO it makes sense to describe it in DT even if the driver
doesn't [yet] make use it.
BTW, please do CC me on future versions of this patchset.
Cheers
James
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2014-11-13 13:08 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-12 15:18 [PATCH 0/2] watchdog: Add support for ImgTec PowerDown Controller Watchdog Timer Naidu.Tellapati
2014-11-12 15:18 ` [PATCH 1/2] watchdog: ImgTec PDC Watchdog Timer Driver Naidu.Tellapati
2014-11-13 4:56 ` Andrew Bresticker
2014-11-13 4:56 ` Andrew Bresticker
2014-11-13 12:58 ` Jude Abraham
2014-11-13 12:58 ` Jude Abraham
2014-11-13 13:26 ` James Hogan
2014-11-13 13:26 ` James Hogan
2014-11-14 13:08 ` Naidu Tellapati
2014-11-14 13:08 ` Naidu Tellapati
2014-11-14 14:08 ` James Hartley
2014-11-14 14:08 ` James Hartley
2014-11-13 13:05 ` Ezequiel Garcia
2014-11-13 13:05 ` Ezequiel Garcia
2014-11-12 15:18 ` [PATCH 2/2] DT: watchdog: Add ImgTec PDC Watchdog Timer binding documentation Naidu.Tellapati
2014-11-13 4:09 ` Andrew Bresticker
2014-11-13 4:09 ` Andrew Bresticker
2014-11-13 12:58 ` Jude Abraham
2014-11-13 12:58 ` Jude Abraham
2014-11-13 13:08 ` James Hogan [this message]
2014-11-13 13:08 ` James Hogan
2014-11-13 19:07 ` Andrew Bresticker
2014-11-13 19:07 ` Andrew Bresticker
2014-11-14 3:18 ` Naidu Tellapati
2014-11-14 3:18 ` Naidu Tellapati
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5464AD4B.1000509@imgtec.com \
--to=james.hogan@imgtec.com \
--cc=Ezequiel.Garcia@imgtec.com \
--cc=James.Hartley@imgtec.com \
--cc=Jude.Abraham@imgtec.com \
--cc=Naidu.Tellapati@imgtec.com \
--cc=abrestic@chromium.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=wim@iguana.be \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.