From: Josef Bacik <jbacik@fb.com>
To: Filipe Manana <fdmanana@suse.com>, fstests@vger.kernel.org
Cc: linux-btrfs@vger.kernel.org
Subject: Re: [PATCH v2] fstests: btrfs, add regression test for clone ioctl
Date: Thu, 13 Nov 2014 10:53:24 -0500 [thread overview]
Message-ID: <5464D3F4.6030706@fb.com> (raw)
In-Reply-To: <1415619766-30814-1-git-send-email-fdmanana@suse.com>
On 11/10/2014 06:42 AM, Filipe Manana wrote:
> Regression test for a btrfs clone ioctl issue where races between
> a clone operation and concurrent target file reads would result in
> leaving stale data in the page cache. After the clone operation
> finished, reading from the clone target file would return the old
> and no longer valid data. This affected only buffered reads (i.e.
> didn't affect direct IO reads).
>
> This issue was fixed by the following linux kernel patch:
>
> Btrfs: ensure readers see new data after a clone operation
> (commit c125b8bff1d9f6c8c91ce4eb8bd5616058c7d510)
>
> Signed-off-by: Filipe Manana <fdmanana@suse.com>
> ---
Verified and the test looks sane, you can add
Reviewed-by: Josef Bacik <jbacik@fb.com>
WARNING: multiple messages have this Message-ID (diff)
From: Josef Bacik <jbacik@fb.com>
To: Filipe Manana <fdmanana@suse.com>, <fstests@vger.kernel.org>
Cc: <linux-btrfs@vger.kernel.org>
Subject: Re: [PATCH v2] fstests: btrfs, add regression test for clone ioctl
Date: Thu, 13 Nov 2014 10:53:24 -0500 [thread overview]
Message-ID: <5464D3F4.6030706@fb.com> (raw)
In-Reply-To: <1415619766-30814-1-git-send-email-fdmanana@suse.com>
On 11/10/2014 06:42 AM, Filipe Manana wrote:
> Regression test for a btrfs clone ioctl issue where races between
> a clone operation and concurrent target file reads would result in
> leaving stale data in the page cache. After the clone operation
> finished, reading from the clone target file would return the old
> and no longer valid data. This affected only buffered reads (i.e.
> didn't affect direct IO reads).
>
> This issue was fixed by the following linux kernel patch:
>
> Btrfs: ensure readers see new data after a clone operation
> (commit c125b8bff1d9f6c8c91ce4eb8bd5616058c7d510)
>
> Signed-off-by: Filipe Manana <fdmanana@suse.com>
> ---
Verified and the test looks sane, you can add
Reviewed-by: Josef Bacik <jbacik@fb.com>
next prev parent reply other threads:[~2014-11-13 15:53 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-21 20:43 [PATCH] fstests: btrfs, add regression test for clone ioctl Filipe Manana
2014-11-10 1:47 ` Dave Chinner
2014-11-10 11:42 ` [PATCH v2] " Filipe Manana
2014-11-13 15:53 ` Josef Bacik [this message]
2014-11-13 15:53 ` Josef Bacik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5464D3F4.6030706@fb.com \
--to=jbacik@fb.com \
--cc=fdmanana@suse.com \
--cc=fstests@vger.kernel.org \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.