All of lore.kernel.org
 help / color / mirror / Atom feed
From: hdegoede@redhat.com (Hans de Goede)
To: linux-arm-kernel@lists.infradead.org
Subject: [linux-sunxi] Re: [PATCH 3/4] simplefb: Change simplefb_init from module_init to fs_initcall
Date: Thu, 13 Nov 2014 20:04:35 +0100	[thread overview]
Message-ID: <546500C3.7040908@redhat.com> (raw)
In-Reply-To: <jwvy4rf2i7h.fsf-monnier+gmane.comp.hardware.netbook.arm.sunxi@gnu.org>

Hi,

On 11/13/2014 05:13 PM, Stefan Monnier wrote:
>> Like a lot of things, if it is made a modules, and it breaks for the
>> user, the user gets to keep the pieces.  There are potentially some
> 
> But the option's description should probably include some blurb about
> the fact that it only works as a module with some combinations of
> SoC+kernel.

So I was about to add an update of the Kconfig text along this line
while I was respinning the patch anyways, and guess what simplefb
currently cannot be build as a module, so this is a non-issue.

I'll update my "simplefb: Add support for enumerating simplefb dt nodes in /chosen"
patch to not have a module_exit in the next version, since that is
not really useful if it cannot be build as a module anyways.

Regards,

Hans

WARNING: multiple messages have this Message-ID (diff)
From: Hans de Goede <hdegoede-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
To: linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org
Cc: linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
	devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: Re: [PATCH 3/4] simplefb: Change simplefb_init from module_init to fs_initcall
Date: Thu, 13 Nov 2014 20:04:35 +0100	[thread overview]
Message-ID: <546500C3.7040908@redhat.com> (raw)
In-Reply-To: <jwvy4rf2i7h.fsf-monnier+gmane.comp.hardware.netbook.arm.sunxi-mXXj517/zsQ@public.gmane.org>

Hi,

On 11/13/2014 05:13 PM, Stefan Monnier wrote:
>> Like a lot of things, if it is made a modules, and it breaks for the
>> user, the user gets to keep the pieces.  There are potentially some
> 
> But the option's description should probably include some blurb about
> the fact that it only works as a module with some combinations of
> SoC+kernel.

So I was about to add an update of the Kconfig text along this line
while I was respinning the patch anyways, and guess what simplefb
currently cannot be build as a module, so this is a non-issue.

I'll update my "simplefb: Add support for enumerating simplefb dt nodes in /chosen"
patch to not have a module_exit in the next version, since that is
not really useful if it cannot be build as a module anyways.

Regards,

Hans

  reply	other threads:[~2014-11-13 19:04 UTC|newest]

Thread overview: 90+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-11-12 22:08 [PATCH 1/4] dt-bindings: simplefb: Specify node location and handoff related properties Hans de Goede
2014-11-12 22:08 ` Hans de Goede
2014-11-12 22:08 ` Hans de Goede
2014-11-12 22:08 ` [PATCH 2/4] simplefb: Add support for enumerating simplefb dt nodes in /chosen Hans de Goede
2014-11-12 22:08   ` Hans de Goede
2014-11-12 22:08   ` Hans de Goede
2014-11-12 23:39   ` [linux-sunxi] " Julian Calaby
2014-11-12 23:39     ` Julian Calaby
2014-11-12 23:39     ` [linux-sunxi] " Julian Calaby
2014-11-13  8:27     ` Hans de Goede
2014-11-13  8:27       ` Hans de Goede
2014-11-13  8:27       ` [linux-sunxi] " Hans de Goede
2014-11-13  8:34       ` Geert Uytterhoeven
2014-11-13  8:34         ` Geert Uytterhoeven
2014-11-13  8:34         ` [linux-sunxi] " Geert Uytterhoeven
2014-11-13  8:40         ` Hans de Goede
2014-11-13  8:40           ` Hans de Goede
2014-11-13  8:40           ` [linux-sunxi] " Hans de Goede
2014-11-13  8:47           ` Julian Calaby
2014-11-13  8:47             ` Julian Calaby
2014-11-13  8:47             ` [linux-sunxi] " Julian Calaby
2014-11-13 10:24     ` Grant Likely
2014-11-13 10:24       ` Grant Likely
2014-11-13 10:24       ` [linux-sunxi] " Grant Likely
2014-11-13  8:15   ` Geert Uytterhoeven
2014-11-13  8:15     ` Geert Uytterhoeven
2014-11-13  8:15     ` Geert Uytterhoeven
2014-11-13  8:16     ` Geert Uytterhoeven
2014-11-13  8:16       ` Geert Uytterhoeven
2014-11-13  8:16       ` Geert Uytterhoeven
2014-11-13  8:28       ` Hans de Goede
2014-11-13  8:28         ` Hans de Goede
2014-11-13  8:28         ` Hans de Goede
2014-11-12 22:08 ` [PATCH 3/4] simplefb: Change simplefb_init from module_init to fs_initcall Hans de Goede
2014-11-12 22:08   ` Hans de Goede
2014-11-12 22:08   ` Hans de Goede
2014-11-13  8:52   ` Maxime Ripard
2014-11-13  8:52     ` Maxime Ripard
2014-11-13  8:52     ` Maxime Ripard
2014-11-13  8:58     ` Geert Uytterhoeven
2014-11-13  8:58       ` Geert Uytterhoeven
2014-11-13  8:58       ` Geert Uytterhoeven
2014-11-18 10:19       ` Thierry Reding
2014-11-18 10:19         ` Thierry Reding
2014-11-18 10:19         ` Thierry Reding
2014-11-18 11:01         ` Hans de Goede
2014-11-18 11:01           ` Hans de Goede
2014-11-18 11:01           ` Hans de Goede
2014-11-18 11:21           ` Thierry Reding
2014-11-18 11:21             ` Thierry Reding
2014-11-18 11:21             ` Thierry Reding
2014-11-18 11:46             ` Hans de Goede
2014-11-18 11:46               ` Hans de Goede
2014-11-18 11:46               ` Hans de Goede
2014-11-18 12:44               ` Hans de Goede
2014-11-18 12:44                 ` Hans de Goede
2014-11-18 12:44                 ` Hans de Goede
2014-11-18 15:16                 ` Thierry Reding
2014-11-18 15:16                   ` Thierry Reding
2014-11-18 15:16                   ` Thierry Reding
2014-11-18 15:28                   ` Maxime Ripard
2014-11-18 15:28                     ` Maxime Ripard
2014-11-18 15:28                     ` Maxime Ripard
2014-11-13  9:24     ` Hans de Goede
2014-11-13  9:24       ` Hans de Goede
2014-11-13  9:24       ` Hans de Goede
2014-11-13 10:29       ` Grant Likely
2014-11-13 10:29         ` Grant Likely
2014-11-13 10:29         ` Grant Likely
2014-11-13 10:31         ` Grant Likely
2014-11-13 10:31           ` Grant Likely
2014-11-13 10:31           ` Grant Likely
2014-11-13 12:01           ` Hans de Goede
2014-11-13 12:01             ` Hans de Goede
2014-11-13 12:01             ` Hans de Goede
2014-11-13 10:42         ` Maxime Ripard
2014-11-13 10:42           ` Maxime Ripard
2014-11-13 10:42           ` Maxime Ripard
2014-11-13 16:13         ` Stefan Monnier
2014-11-13 19:04           ` Hans de Goede [this message]
2014-11-13 19:04             ` Hans de Goede
2014-11-12 22:08 ` [PATCH 4/4] fbcon: Change fbcon_init " Hans de Goede
2014-11-12 22:08   ` Hans de Goede
2014-11-12 22:08   ` Hans de Goede
2014-11-13  8:38 ` [PATCH 1/4] dt-bindings: simplefb: Specify node location and handoff related properties Geert Uytterhoeven
2014-11-13  8:38   ` Geert Uytterhoeven
2014-11-13  8:38   ` Geert Uytterhoeven
2014-11-13  8:43   ` Hans de Goede
2014-11-13  8:43     ` Hans de Goede
2014-11-13  8:43     ` Hans de Goede

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=546500C3.7040908@redhat.com \
    --to=hdegoede@redhat.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.