All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: David Miller <davem@davemloft.net>, ykaneko0929@gmail.com
Cc: netdev@vger.kernel.org, horms@verge.net.au,
	magnus.damm@gmail.com, linux-sh@vger.kernel.org,
	grant.likely@linaro.org
Subject: Re: [PATCH] sh_eth: r8a779x: Enable automatically fetch receive descriptor
Date: Thu, 13 Nov 2014 21:59:37 +0000	[thread overview]
Message-ID: <546529C9.3080907@cogentembedded.com> (raw)
In-Reply-To: <20141113.150311.1961794581032201784.davem@davemloft.net>

Hello.

On 11/13/2014 11:03 PM, David Miller wrote:

>> From: Kouei Abe <kouei.abe.cp@renesas.com>

>> HDMAC automatically fetches the receive descriptor and receives frames.
>> Continuous reception of multiple frames is possible.

>> Signed-off-by: Kouei Abe <kouei.abe.cp@renesas.com>
>> Signed-off-by: Yoshihiro Kaneko <ykaneko0929@gmail.com>
>> ---
>>
>> This patch is based on net-next tree.
>
> This doesn't even compile, or, it depends upon another patch which you have
> not mentioned.

    This patch is just very outdated -- this issue has been fixed for all SoCs 
before.

> Because sh_eth_cpu_data does not have an rmcr_value field.

     Right, it was removed by the above mentioned patch (based on your 
feedback BTW ;-).

WBR, Sergei


WARNING: multiple messages have this Message-ID (diff)
From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: David Miller <davem@davemloft.net>, ykaneko0929@gmail.com
Cc: netdev@vger.kernel.org, horms@verge.net.au,
	magnus.damm@gmail.com, linux-sh@vger.kernel.org,
	grant.likely@linaro.org
Subject: Re: [PATCH] sh_eth: r8a779x: Enable automatically fetch receive descriptor
Date: Fri, 14 Nov 2014 00:59:37 +0300	[thread overview]
Message-ID: <546529C9.3080907@cogentembedded.com> (raw)
In-Reply-To: <20141113.150311.1961794581032201784.davem@davemloft.net>

Hello.

On 11/13/2014 11:03 PM, David Miller wrote:

>> From: Kouei Abe <kouei.abe.cp@renesas.com>

>> HDMAC automatically fetches the receive descriptor and receives frames.
>> Continuous reception of multiple frames is possible.

>> Signed-off-by: Kouei Abe <kouei.abe.cp@renesas.com>
>> Signed-off-by: Yoshihiro Kaneko <ykaneko0929@gmail.com>
>> ---
>>
>> This patch is based on net-next tree.
>
> This doesn't even compile, or, it depends upon another patch which you have
> not mentioned.

    This patch is just very outdated -- this issue has been fixed for all SoCs 
before.

> Because sh_eth_cpu_data does not have an rmcr_value field.

     Right, it was removed by the above mentioned patch (based on your 
feedback BTW ;-).

WBR, Sergei


  reply	other threads:[~2014-11-13 21:59 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-11-13  6:56 [PATCH] sh_eth: r8a779x: Enable automatically fetch receive descriptor Yoshihiro Kaneko
2014-11-13  6:56 ` Yoshihiro Kaneko
2014-11-13 20:03 ` David Miller
2014-11-13 20:03   ` David Miller
2014-11-13 21:59   ` Sergei Shtylyov [this message]
2014-11-13 21:59     ` Sergei Shtylyov
2014-11-13 21:57 ` Sergei Shtylyov
2014-11-13 21:57   ` Sergei Shtylyov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=546529C9.3080907@cogentembedded.com \
    --to=sergei.shtylyov@cogentembedded.com \
    --cc=davem@davemloft.net \
    --cc=grant.likely@linaro.org \
    --cc=horms@verge.net.au \
    --cc=linux-sh@vger.kernel.org \
    --cc=magnus.damm@gmail.com \
    --cc=netdev@vger.kernel.org \
    --cc=ykaneko0929@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.