From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: Yoshihiro Kaneko <ykaneko0929@gmail.com>, netdev@vger.kernel.org
Cc: "David S. Miller" <davem@davemloft.net>,
Simon Horman <horms@verge.net.au>,
Magnus Damm <magnus.damm@gmail.com>,
linux-sh@vger.kernel.org
Subject: Re: [PATCH] net: sh_eth: Add RMII mode setting in probe
Date: Thu, 13 Nov 2014 22:20:06 +0000 [thread overview]
Message-ID: <54652E96.2060100@cogentembedded.com> (raw)
In-Reply-To: <1415861645-27685-1-git-send-email-ykaneko0929@gmail.com>
Hello.
On 11/13/2014 09:54 AM, Yoshihiro Kaneko wrote:
> From: Hisashi Nakamura <hisashi.nakamura.ak@renesas.com>
> When using RMMI mode, it is necessary to change in probe.
I'd like this need to be explained in more detail.
> Signed-off-by: Hisashi Nakamura <hisashi.nakamura.ak@renesas.com>
> Signed-off-by: Yoshihiro Kaneko <ykaneko0929@gmail.com>
> ---
> This patch is based on net-next tree.
> drivers/net/ethernet/renesas/sh_eth.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/drivers/net/ethernet/renesas/sh_eth.c b/drivers/net/ethernet/renesas/sh_eth.c
> index dbe8606..1f79ed6 100644
> --- a/drivers/net/ethernet/renesas/sh_eth.c
> +++ b/drivers/net/ethernet/renesas/sh_eth.c
> @@ -1,5 +1,6 @@
> /* SuperH Ethernet device driver
> *
> + * Copyright (C) 2014 Renesas Electronics Corporation
> * Copyright (C) 2006-2012 Nobuhiro Iwamatsu
> * Copyright (C) 2008-2014 Renesas Solutions Corp.
> * Copyright (C) 2013-2014 Cogent Embedded, Inc.
> @@ -2883,6 +2884,9 @@ static int sh_eth_drv_probe(struct platform_device *pdev)
> }
> }
>
> + if (mdp->cd->rmiimode)
> + sh_eth_write(ndev, 0x1, RMIIMODE);
> +
Does not such code need to be removed from sh_eth_dev_init() then?
WBR, Sergei
WARNING: multiple messages have this Message-ID (diff)
From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: Yoshihiro Kaneko <ykaneko0929@gmail.com>, netdev@vger.kernel.org
Cc: "David S. Miller" <davem@davemloft.net>,
Simon Horman <horms@verge.net.au>,
Magnus Damm <magnus.damm@gmail.com>,
linux-sh@vger.kernel.org
Subject: Re: [PATCH] net: sh_eth: Add RMII mode setting in probe
Date: Fri, 14 Nov 2014 01:20:06 +0300 [thread overview]
Message-ID: <54652E96.2060100@cogentembedded.com> (raw)
In-Reply-To: <1415861645-27685-1-git-send-email-ykaneko0929@gmail.com>
Hello.
On 11/13/2014 09:54 AM, Yoshihiro Kaneko wrote:
> From: Hisashi Nakamura <hisashi.nakamura.ak@renesas.com>
> When using RMMI mode, it is necessary to change in probe.
I'd like this need to be explained in more detail.
> Signed-off-by: Hisashi Nakamura <hisashi.nakamura.ak@renesas.com>
> Signed-off-by: Yoshihiro Kaneko <ykaneko0929@gmail.com>
> ---
> This patch is based on net-next tree.
> drivers/net/ethernet/renesas/sh_eth.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/drivers/net/ethernet/renesas/sh_eth.c b/drivers/net/ethernet/renesas/sh_eth.c
> index dbe8606..1f79ed6 100644
> --- a/drivers/net/ethernet/renesas/sh_eth.c
> +++ b/drivers/net/ethernet/renesas/sh_eth.c
> @@ -1,5 +1,6 @@
> /* SuperH Ethernet device driver
> *
> + * Copyright (C) 2014 Renesas Electronics Corporation
> * Copyright (C) 2006-2012 Nobuhiro Iwamatsu
> * Copyright (C) 2008-2014 Renesas Solutions Corp.
> * Copyright (C) 2013-2014 Cogent Embedded, Inc.
> @@ -2883,6 +2884,9 @@ static int sh_eth_drv_probe(struct platform_device *pdev)
> }
> }
>
> + if (mdp->cd->rmiimode)
> + sh_eth_write(ndev, 0x1, RMIIMODE);
> +
Does not such code need to be removed from sh_eth_dev_init() then?
WBR, Sergei
next prev parent reply other threads:[~2014-11-13 22:20 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-13 6:54 [PATCH] net: sh_eth: Add RMII mode setting in probe Yoshihiro Kaneko
2014-11-13 6:54 ` Yoshihiro Kaneko
2014-11-13 20:04 ` David Miller
2014-11-13 20:04 ` David Miller
2014-11-13 22:20 ` Sergei Shtylyov [this message]
2014-11-13 22:20 ` Sergei Shtylyov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54652E96.2060100@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded.com \
--cc=davem@davemloft.net \
--cc=horms@verge.net.au \
--cc=linux-sh@vger.kernel.org \
--cc=magnus.damm@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=ykaneko0929@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.