From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: Yoshihiro Kaneko <ykaneko0929@gmail.com>, netdev@vger.kernel.org
Cc: "David S. Miller" <davem@davemloft.net>,
Simon Horman <horms@verge.net.au>,
Magnus Damm <magnus.damm@gmail.com>,
linux-sh@vger.kernel.org
Subject: Re: [PATCH 1/3] sh_eth: Remove redundant alignment adjustment
Date: Thu, 13 Nov 2014 22:37:22 +0000 [thread overview]
Message-ID: <546532A2.80509@cogentembedded.com> (raw)
In-Reply-To: <1415862301-28032-2-git-send-email-ykaneko0929@gmail.com>
On 11/13/2014 10:04 AM, Yoshihiro Kaneko wrote:
> From: Mitsuhiro Kimura <mitsuhiro.kimura.kc@renesas.com>
> PTR_ALIGN macro after skb_reserve is redundant, because skb_reserve
> function adjusts the alignment of skb->data.
OK, but where is the bug? There must be one if you base this patch on the
'net' tree...
> Signed-off-by: Mitsuhiro Kimura <mitsuhiro.kimura.kc@renesas.com>
> Signed-off-by: Yoshihiro Kaneko <ykaneko0929@gmail.com>
WBR, Sergei
WARNING: multiple messages have this Message-ID (diff)
From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: Yoshihiro Kaneko <ykaneko0929@gmail.com>, netdev@vger.kernel.org
Cc: "David S. Miller" <davem@davemloft.net>,
Simon Horman <horms@verge.net.au>,
Magnus Damm <magnus.damm@gmail.com>,
linux-sh@vger.kernel.org
Subject: Re: [PATCH 1/3] sh_eth: Remove redundant alignment adjustment
Date: Fri, 14 Nov 2014 01:37:22 +0300 [thread overview]
Message-ID: <546532A2.80509@cogentembedded.com> (raw)
In-Reply-To: <1415862301-28032-2-git-send-email-ykaneko0929@gmail.com>
On 11/13/2014 10:04 AM, Yoshihiro Kaneko wrote:
> From: Mitsuhiro Kimura <mitsuhiro.kimura.kc@renesas.com>
> PTR_ALIGN macro after skb_reserve is redundant, because skb_reserve
> function adjusts the alignment of skb->data.
OK, but where is the bug? There must be one if you base this patch on the
'net' tree...
> Signed-off-by: Mitsuhiro Kimura <mitsuhiro.kimura.kc@renesas.com>
> Signed-off-by: Yoshihiro Kaneko <ykaneko0929@gmail.com>
WBR, Sergei
next prev parent reply other threads:[~2014-11-13 22:37 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-13 7:04 [PATCH 0/3] sh_eth: Remove redundant alignment adjustment Yoshihiro Kaneko
2014-11-13 7:04 ` Yoshihiro Kaneko
2014-11-13 7:04 ` [PATCH 1/3] " Yoshihiro Kaneko
2014-11-13 7:04 ` Yoshihiro Kaneko
2014-11-13 22:37 ` Sergei Shtylyov [this message]
2014-11-13 22:37 ` Sergei Shtylyov
2014-11-14 0:43 ` Simon Horman
2014-11-14 0:43 ` Simon Horman
2014-11-13 7:05 ` [PATCH 2/3] sh_eth: Fix skb alloc size and alignment adjust rule Yoshihiro Kaneko
2014-11-13 7:05 ` Yoshihiro Kaneko
2014-11-13 22:48 ` Sergei Shtylyov
2014-11-13 22:48 ` Sergei Shtylyov
2014-11-13 7:05 ` [PATCH 3/3] sh_eth: Fix dma mapping issue Yoshihiro Kaneko
2014-11-13 7:05 ` Yoshihiro Kaneko
2014-11-13 23:05 ` Sergei Shtylyov
2014-11-13 23:05 ` Sergei Shtylyov
2014-11-17 4:09 ` Simon Horman
2014-11-17 4:09 ` Simon Horman
2014-11-25 20:07 ` Sergei Shtylyov
2014-11-25 20:07 ` Sergei Shtylyov
2014-11-13 9:04 ` [PATCH 0/3] sh_eth: Remove redundant alignment adjustment Geert Uytterhoeven
2014-11-13 9:04 ` Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=546532A2.80509@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded.com \
--cc=davem@davemloft.net \
--cc=horms@verge.net.au \
--cc=linux-sh@vger.kernel.org \
--cc=magnus.damm@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=ykaneko0929@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.