All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: Geoff Levand <geoff@infradead.org>
Cc: marc.zyngier@arm.com, Catalin Marinas <catalin.marinas@arm.com>,
	Will Deacon <will.deacon@arm.com>,
	christoffer.dall@linaro.org,
	Grant Likely <grant.likely@linaro.org>,
	kexec@lists.infradead.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 7/8] arm64/kexec: Add checks for KVM and EFI
Date: Fri, 14 Nov 2014 21:40:04 +0300	[thread overview]
Message-ID: <54664C84.1040003@cogentembedded.com> (raw)
In-Reply-To: <1415989719.15847.121.camel@smoke>

On 11/14/2014 09:28 PM, Geoff Levand wrote:

> Add runtime checks that fail the arm64 kexec syscall for situations that would
> result in system instability do to problems in the KVM and EFI kernel support.
> These checks should be removed when the KVM and EFI problems are fixed.

> Signed-off-by: Geoff Levand <geoff@infradead.org>
> ---
> v2: Typo fixes.

>   arch/arm64/kernel/machine_kexec.c | 22 ++++++++++++++++++++++
>   1 file changed, 22 insertions(+)

> diff --git a/arch/arm64/kernel/machine_kexec.c b/arch/arm64/kernel/machine_kexec.c
> index 775bcc3..faeb4f1 100644
> --- a/arch/arm64/kernel/machine_kexec.c
> +++ b/arch/arm64/kernel/machine_kexec.c
[...]
> @@ -101,6 +107,22 @@ int machine_kexec_prepare(struct kimage *image)
>
>   	kexec_image_info(image);
>
> +	/* TODO: Remove this message when KVM can support a kexec reboot. */
> +	if (IS_ENABLED(CONFIG_KVM) && is_hyp_mode_available()) {
> +		pr_err("%s: Your kernel is configured with KVM support "
> +			"(CONFIG_KVM=y) which currently does not allow for "
> +			"kexec re-boot.\n", __func__);

    Er, failed to notice the first time: you do not need to break up the 
message. This helps finding the messages in the kernel code. If you would have 
run the patch thru scripst/checkpatch.pl you would have gotten the actual 
warnings about that...

[...]

WBR, Sergei


_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec

WARNING: multiple messages have this Message-ID (diff)
From: sergei.shtylyov@cogentembedded.com (Sergei Shtylyov)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 7/8] arm64/kexec: Add checks for KVM and EFI
Date: Fri, 14 Nov 2014 21:40:04 +0300	[thread overview]
Message-ID: <54664C84.1040003@cogentembedded.com> (raw)
In-Reply-To: <1415989719.15847.121.camel@smoke>

On 11/14/2014 09:28 PM, Geoff Levand wrote:

> Add runtime checks that fail the arm64 kexec syscall for situations that would
> result in system instability do to problems in the KVM and EFI kernel support.
> These checks should be removed when the KVM and EFI problems are fixed.

> Signed-off-by: Geoff Levand <geoff@infradead.org>
> ---
> v2: Typo fixes.

>   arch/arm64/kernel/machine_kexec.c | 22 ++++++++++++++++++++++
>   1 file changed, 22 insertions(+)

> diff --git a/arch/arm64/kernel/machine_kexec.c b/arch/arm64/kernel/machine_kexec.c
> index 775bcc3..faeb4f1 100644
> --- a/arch/arm64/kernel/machine_kexec.c
> +++ b/arch/arm64/kernel/machine_kexec.c
[...]
> @@ -101,6 +107,22 @@ int machine_kexec_prepare(struct kimage *image)
>
>   	kexec_image_info(image);
>
> +	/* TODO: Remove this message when KVM can support a kexec reboot. */
> +	if (IS_ENABLED(CONFIG_KVM) && is_hyp_mode_available()) {
> +		pr_err("%s: Your kernel is configured with KVM support "
> +			"(CONFIG_KVM=y) which currently does not allow for "
> +			"kexec re-boot.\n", __func__);

    Er, failed to notice the first time: you do not need to break up the 
message. This helps finding the messages in the kernel code. If you would have 
run the patch thru scripst/checkpatch.pl you would have gotten the actual 
warnings about that...

[...]

WBR, Sergei

  reply	other threads:[~2014-11-14 18:40 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-11-14  1:22 [PATCH 0/8] arm64 kexec kernel patches V6 Geoff Levand
2014-11-14  1:22 ` Geoff Levand
2014-11-14  1:22 ` [PATCH 1/8] arm64: Convert hcalls to use ISS field Geoff Levand
2014-11-14  1:22   ` Geoff Levand
2014-11-14  1:22 ` [PATCH 2/8] arm64: Add new hcall HVC_CALL_FUNC Geoff Levand
2014-11-14  1:22   ` Geoff Levand
2014-11-14  1:22 ` [PATCH 6/8] arm64/kexec: Add pr_devel output Geoff Levand
2014-11-14  1:22   ` Geoff Levand
2014-11-14 21:12   ` [PATCH v2 " Geoff Levand
2014-11-14 21:12     ` Geoff Levand
2014-11-14  1:22 ` [PATCH 4/8] arm64: Move proc-macros.S to include/asm Geoff Levand
2014-11-14  1:22   ` Geoff Levand
2014-11-14  1:22 ` [PATCH 3/8] arm64: Add EL2 switch to soft_restart Geoff Levand
2014-11-14  1:22   ` Geoff Levand
2014-11-14  1:22 ` [PATCH 7/8] arm64/kexec: Add checks for KVM and EFI Geoff Levand
2014-11-14  1:22   ` Geoff Levand
2014-11-14 14:42   ` Sergei Shtylyov
2014-11-14 14:42     ` Sergei Shtylyov
2014-11-14 18:28     ` [PATCH v2 " Geoff Levand
2014-11-14 18:28       ` Geoff Levand
2014-11-14 18:40       ` Sergei Shtylyov [this message]
2014-11-14 18:40         ` Sergei Shtylyov
2014-11-14 21:08   ` [PATCH v3 " Geoff Levand
2014-11-14 21:08     ` Geoff Levand
2014-11-14  1:22 ` [PATCH 5/8] arm64/kexec: Add core kexec support Geoff Levand
2014-11-14  1:22   ` Geoff Levand
2014-11-14  1:22 ` [PATCH 8/8] arm64/kexec: Enable kexec in the arm64 defconfig Geoff Levand
2014-11-14  1:22   ` Geoff Levand
2014-11-27  6:19 ` [PATCH 0/8] arm64 kexec kernel patches V6 Dave Young
2014-11-27  6:19   ` Dave Young
2014-11-28  6:56   ` Dave Young
2014-11-28  6:56     ` Dave Young
2014-12-02 20:26     ` Geoff Levand
2014-12-02 20:26       ` Geoff Levand
2014-12-02 20:22   ` Geoff Levand
2014-12-02 20:22     ` Geoff Levand

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54664C84.1040003@cogentembedded.com \
    --to=sergei.shtylyov@cogentembedded.com \
    --cc=catalin.marinas@arm.com \
    --cc=christoffer.dall@linaro.org \
    --cc=geoff@infradead.org \
    --cc=grant.likely@linaro.org \
    --cc=kexec@lists.infradead.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=marc.zyngier@arm.com \
    --cc=will.deacon@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.