All of lore.kernel.org
 help / color / mirror / Atom feed
From: afaerber@suse.de (Andreas Färber)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v4 6/6] ARM: zynq: DT: Add OCM controller node
Date: Sun, 16 Nov 2014 11:51:54 +0100	[thread overview]
Message-ID: <546881CA.2020801@suse.de> (raw)
In-Reply-To: <0a88d52b5e71fb220ca619180ec9ca746edad2b1.1415962281.git.michal.simek@xilinx.com>

Hi Michal,

Am 14.11.2014 um 11:52 schrieb Michal Simek:
> diff --git a/arch/arm/boot/dts/zynq-7000.dtsi b/arch/arm/boot/dts/zynq-7000.dtsi
> index ce2ef5bec4f2..e217fb1c1169 100644
> --- a/arch/arm/boot/dts/zynq-7000.dtsi
> +++ b/arch/arm/boot/dts/zynq-7000.dtsi
> @@ -150,6 +150,13 @@
>  			reg = <0xf8006000 0x1000>;
>  		};
> 
> +		ocmc: memory-controller at f800c000 {
> +			compatible = "xlnx,zynq-ocmc-1.0";
> +			interrupt-parent = <&intc>;
> +			interrupts = <0 3 4>;
> +			reg = <0xf800c000 0x1000>;
> +		};
> +
>  		uart0: serial at e0000000 {
>  			compatible = "xlnx,xuartps", "cdns,uart-r1p8";
>  			status = "disabled";

Not directly related to this patch: As one can see here, the node order
is quite a mess... According to Olof, nodes should be ordered by unit
address, whereas here some but not all seem ordered by node name. Would
you welcome a cleanup patch, or can you fix that yourself?

Regards,
Andreas

-- 
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 N?rnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imend?rffer; HRB 21284 AG N?rnberg

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: OpenPGP digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20141116/ca28033d/attachment.sig>

WARNING: multiple messages have this Message-ID (diff)
From: "Andreas Färber" <afaerber@suse.de>
To: Michal Simek <michal.simek@xilinx.com>
Cc: linux-arm-kernel@lists.infradead.org,
	Soren Brinkmann <soren.brinkmann@xilinx.com>,
	Olof Johansson <olof@lixom.net>, Arnd Bergmann <arnd@arndb.de>,
	Mark Rutland <mark.rutland@arm.com>,
	Josh Cartwright <josh.cartwright@ni.com>,
	monstr@monstr.eu, Russell King <linux@arm.linux.org.uk>,
	Pawel Moll <pawel.moll@arm.com>,
	Ian Campbell <ijc+devicetree@hellion.org.uk>,
	Peter Crosthwaite <peter.crosthwaite@xilinx.com>,
	linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
	Rob Herring <robh+dt@kernel.org>,
	Kumar Gala <galak@codeaurora.org>,
	Steffen Trumtrar <s.trumtrar@pengutronix.de>
Subject: Re: [PATCH v4 6/6] ARM: zynq: DT: Add OCM controller node
Date: Sun, 16 Nov 2014 11:51:54 +0100	[thread overview]
Message-ID: <546881CA.2020801@suse.de> (raw)
In-Reply-To: <0a88d52b5e71fb220ca619180ec9ca746edad2b1.1415962281.git.michal.simek@xilinx.com>

[-- Attachment #1: Type: text/plain, Size: 1089 bytes --]

Hi Michal,

Am 14.11.2014 um 11:52 schrieb Michal Simek:
> diff --git a/arch/arm/boot/dts/zynq-7000.dtsi b/arch/arm/boot/dts/zynq-7000.dtsi
> index ce2ef5bec4f2..e217fb1c1169 100644
> --- a/arch/arm/boot/dts/zynq-7000.dtsi
> +++ b/arch/arm/boot/dts/zynq-7000.dtsi
> @@ -150,6 +150,13 @@
>  			reg = <0xf8006000 0x1000>;
>  		};
> 
> +		ocmc: memory-controller@f800c000 {
> +			compatible = "xlnx,zynq-ocmc-1.0";
> +			interrupt-parent = <&intc>;
> +			interrupts = <0 3 4>;
> +			reg = <0xf800c000 0x1000>;
> +		};
> +
>  		uart0: serial@e0000000 {
>  			compatible = "xlnx,xuartps", "cdns,uart-r1p8";
>  			status = "disabled";

Not directly related to this patch: As one can see here, the node order
is quite a mess... According to Olof, nodes should be ordered by unit
address, whereas here some but not all seem ordered by node name. Would
you welcome a cleanup patch, or can you fix that yourself?

Regards,
Andreas

-- 
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 21284 AG Nürnberg


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

  reply	other threads:[~2014-11-16 10:51 UTC|newest]

Thread overview: 39+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-11-14 10:52 [PATCH v4 0/6] Xilinx Zynq OCM support Michal Simek
2014-11-14 10:52 ` Michal Simek
2014-11-14 10:52 ` Michal Simek
2014-11-14 10:52 ` [PATCH v4 1/6] ARM: zynq: Extract smp related functions out of common.h Michal Simek
2014-11-14 10:52   ` Michal Simek
2014-11-14 10:52 ` [PATCH v4 2/6] ARM: zynq: Extract slcr " Michal Simek
2014-11-14 10:52   ` Michal Simek
2014-11-14 10:52 ` [PATCH v4 3/6] ARM: zynq: Move slcr.h and smp.h to generic location Michal Simek
2014-11-14 10:52   ` Michal Simek
2014-11-14 10:52 ` [PATCH v4 4/6] ARM: zynq: Extend SLCR driver to read OCM configuration Michal Simek
2014-11-14 10:52   ` Michal Simek
2014-11-14 15:15   ` Sören Brinkmann
2014-11-14 15:15     ` Sören Brinkmann
2014-11-14 10:52 ` [PATCH v4 5/6] ARM: zynq: Add OCM controller driver Michal Simek
2014-11-14 10:52   ` Michal Simek
2014-11-14 10:52   ` Michal Simek
2014-11-27 13:20   ` Linus Walleij
2014-11-27 13:20     ` Linus Walleij
2014-11-27 13:20     ` Linus Walleij
2014-11-27 13:57     ` Michal Simek
2014-11-27 13:57       ` Michal Simek
2014-11-27 13:57       ` Michal Simek
2014-11-28 15:35       ` Linus Walleij
2014-11-28 15:35         ` Linus Walleij
2014-11-28 15:35         ` Linus Walleij
2014-12-01 14:24         ` Michal Simek
2014-12-01 14:24           ` Michal Simek
2014-12-01 14:24           ` Michal Simek
2014-11-14 10:52 ` [PATCH v4 6/6] ARM: zynq: DT: Add OCM controller node Michal Simek
2014-11-14 10:52   ` Michal Simek
2014-11-16 10:51   ` Andreas Färber [this message]
2014-11-16 10:51     ` Andreas Färber
2014-11-16 19:32     ` Sören Brinkmann
2014-11-16 19:32       ` Sören Brinkmann
2014-11-16 19:32       ` Sören Brinkmann
2014-11-16 23:00       ` Peter Crosthwaite
2014-11-16 23:00         ` Peter Crosthwaite
2014-11-18  7:56         ` Michal Simek
2014-11-18  7:56           ` Michal Simek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=546881CA.2020801@suse.de \
    --to=afaerber@suse.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.