From: Loic Poulain <loic.poulain@intel.com>
To: Doug Anderson <dianders@chromium.org>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Heiko Stuebner <heiko@sntech.de>, Jiri Slaby <jslaby@suse.cz>,
Chris Zhong <zyw@rock-chips.com>,
linux-rockchip@lists.infradead.org,
linux-arm-kernel@lists.infradead.org,
Andrew Bresticker <abrestic@chromium.org>,
mika.westerberg@linux.intel.com, heikki.krogerus@linux.intel.com,
andriy.shevchenko@linux.intel.com, wens@csie.org,
alan@linux.intel.com, linux-serial@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] serial: 8250_dw: Handle no_console_suspend when uart loses state
Date: Mon, 17 Nov 2014 09:56:08 +0100 [thread overview]
Message-ID: <5469B828.90401@intel.com> (raw)
In-Reply-To: <1416011556-23422-1-git-send-email-dianders@chromium.org>
> In certain suspend modes on certain boards the 8250 UART may lose
> state when the device goes to suspend. If we're using
> no_console_suspend this can cause lots of problems during resume.
>
> Let's cache the basic UART config registers at suspend time and if we
> notice that the UART loses state (by looking at a canary stored in the
> scratch register) we'll restore it.
If I'm not wrong, it's already done in acpi_lpss suspend/resume (for
8250_dw).
Commit c78b0830667a7e7c1f0ca65b76b33166a84806b3.
Regards,
Loic
--
Intel Open Source Technology Center
http://oss.intel.com/
WARNING: multiple messages have this Message-ID (diff)
From: loic.poulain@intel.com (Loic Poulain)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] serial: 8250_dw: Handle no_console_suspend when uart loses state
Date: Mon, 17 Nov 2014 09:56:08 +0100 [thread overview]
Message-ID: <5469B828.90401@intel.com> (raw)
In-Reply-To: <1416011556-23422-1-git-send-email-dianders@chromium.org>
> In certain suspend modes on certain boards the 8250 UART may lose
> state when the device goes to suspend. If we're using
> no_console_suspend this can cause lots of problems during resume.
>
> Let's cache the basic UART config registers at suspend time and if we
> notice that the UART loses state (by looking at a canary stored in the
> scratch register) we'll restore it.
If I'm not wrong, it's already done in acpi_lpss suspend/resume (for
8250_dw).
Commit c78b0830667a7e7c1f0ca65b76b33166a84806b3.
Regards,
Loic
--
Intel Open Source Technology Center
http://oss.intel.com/
next prev parent reply other threads:[~2014-11-17 8:53 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-15 0:32 [PATCH] serial: 8250_dw: Handle no_console_suspend when uart loses state Doug Anderson
2014-11-15 0:32 ` Doug Anderson
2014-11-17 8:56 ` Loic Poulain [this message]
2014-11-17 8:56 ` Loic Poulain
2014-11-17 9:20 ` Heiko Stübner
2014-11-17 9:20 ` Heiko Stübner
2014-11-28 12:09 ` Heikki Krogerus
2014-11-28 12:09 ` Heikki Krogerus
2014-11-28 12:30 ` Andy Shevchenko
2014-11-28 12:30 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5469B828.90401@intel.com \
--to=loic.poulain@intel.com \
--cc=abrestic@chromium.org \
--cc=alan@linux.intel.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=dianders@chromium.org \
--cc=gregkh@linuxfoundation.org \
--cc=heikki.krogerus@linux.intel.com \
--cc=heiko@sntech.de \
--cc=jslaby@suse.cz \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=linux-serial@vger.kernel.org \
--cc=mika.westerberg@linux.intel.com \
--cc=wens@csie.org \
--cc=zyw@rock-chips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.