From: Paolo Bonzini <pbonzini@redhat.com>
To: Tiejun Chen <tiejun.chen@intel.com>
Cc: kvm@vger.kernel.org
Subject: Re: [v2][PATCH] kvm: x86: mmio: fix setting the present bit of mmio spte
Date: Mon, 17 Nov 2014 12:40:52 +0100 [thread overview]
Message-ID: <5469DEC4.6050206@redhat.com> (raw)
In-Reply-To: <1416223883-4485-1-git-send-email-tiejun.chen@intel.com>
On 17/11/2014 12:31, Tiejun Chen wrote:
> In non-ept 64-bit of PAE case maxphyaddr may be 52bit as well,
There is no such thing as 64-bit PAE.
On 32-bit PAE hosts, PTEs have bit 62 reserved, as in your patch:
> + /* Magic bits are always reserved for 32bit host. */
> + mask |= 0x3ull << 62;
so there is no need to disable the MMIO page fault.
Paolo
next prev parent reply other threads:[~2014-11-17 11:40 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-17 11:31 [v2][PATCH] kvm: x86: mmio: fix setting the present bit of mmio spte Tiejun Chen
2014-11-17 11:40 ` Paolo Bonzini [this message]
2014-11-18 9:23 ` Chen, Tiejun
2014-11-18 10:06 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5469DEC4.6050206@redhat.com \
--to=pbonzini@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=tiejun.chen@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.