Re: [Qemu-devel] [PATCH v2 1/5] libqos: Change use of pointers to uint64_t in virtio

["Andreas Färber" <afaerber@suse.de>]

Am 17.11.2014 um 16:19 schrieb Marc Marí:
> El Mon, 17 Nov 2014 15:16:21 +0000
> Stefan Hajnoczi <stefanha@gmail.com> escribió:
>> On Sat, Nov 01, 2014 at 06:02:26PM +0100, Marc Marí wrote:
>>> Convert use of pointers in functions of virtio to uint64_t in order
>>> to make it platform-independent.
>>>
>>> Add casting from pointers (in PCI functions) to uint64_t and vice
>>> versa through uintptr_t.
>>>
>>> Signed-off-by: Marc Marí <marc.mari.barcelo@gmail.com>
>>> ---
>>>  tests/libqos/virtio-pci.c |   20 +++++++++++---------
>>>  tests/libqos/virtio.c     |    8 ++++----
>>>  tests/libqos/virtio.h     |   16 ++++++++--------
>>>  tests/virtio-blk-test.c   |   21 ++++++++++++++-------
>>>  4 files changed, 37 insertions(+), 28 deletions(-)
>>
>> This makes sense.  To fully abolish pointers the PCI code also needs
>> to be converted.  Do plan plan to do that?
>>
>> Stefan
> 
> Not planned, but if asked, I may do it.

Pretty please. :) I was wondering the same thing when reading the patch.

Regards,
Andreas

-- 
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 21284 AG Nürnberg