Re: [PATCH 6/7] MIPS: Apply `.insn' to fixup labels throughout

["Steven J. Hill" <Steven.Hill@imgtec.com>]

On 11/15/2014 04:09 PM, Maciej W. Rozycki wrote:
> Fix the issue with the ISA bit being lost in fixups that jump to
> labels placed just before a section switch.  Such a switch leads to
> the ISA bit being lost, because GAS concludes there is no code that
> follows and therefore the label refers to data.  Use the `.insn'
> pseudo-op to convince the tool this is not the case.
> 
> This lack of label annotation leads to microMIPS compilation errors 
> like:
> 
> mips-linux-gnu-ld: arch/mips/built-in.o: .fixup+0x3b8: Unsupported
> jump between ISA modes; consider recompiling with interlinking
> enabled. mips-linux-gnu-ld: final link failed: Bad value
> 
> Signed-off-by: Maciej W. Rozycki <macro@codesourcery.com> --- Hi,
> 
> I see someone has just fixed this issue in one place, so I had to 
> regenerate the change I originally made against 3.17, but I really
> fail to see why not to fix it throughout at once.
> 
In our earlier branches I believe all of the '.insn' pseudo-ops were in
place. I remember removing a number of them during release testing since
they appeared to not make any difference. It appears that use of
different toolchains has shown that to be in error.

Steve


Signed-off-by: Steven J. Hill <Steven.Hill@imgtec.com>