From: Eric Blake <eblake@redhat.com>
To: Fam Zheng <famz@redhat.com>, qemu-devel@nongnu.org
Cc: qemu-trivial@nongnu.org, kwolf@redhat.com, mjt@tls.msk.ru,
stefanha@redhat.com, mreitz@redhat.com
Subject: Re: [Qemu-trivial] [Qemu-devel] [PATCH] qemu-iotests: Fix error message if which(1) not installed
Date: Mon, 17 Nov 2014 21:40:29 -0700 [thread overview]
Message-ID: <546ACDBD.9010403@redhat.com> (raw)
In-Reply-To: <1416278986-17320-1-git-send-email-famz@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 557 bytes --]
On 11/17/2014 07:49 PM, Fam Zheng wrote:
> When which(1) is not installed, we complain "perl not found" because
> it's the first set_prog_path check. The error message is misleading.
>
> Fix it by adding a check for which(1) in the beginning.
Why not instead change set_prog_path to use 'command -v' instead of
'which'? As this is a bash script, we shouldn't need to shell out to an
optional package for something we can do natively.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 539 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Eric Blake <eblake@redhat.com>
To: Fam Zheng <famz@redhat.com>, qemu-devel@nongnu.org
Cc: qemu-trivial@nongnu.org, kwolf@redhat.com, mjt@tls.msk.ru,
stefanha@redhat.com, mreitz@redhat.com
Subject: Re: [Qemu-devel] [PATCH] qemu-iotests: Fix error message if which(1) not installed
Date: Mon, 17 Nov 2014 21:40:29 -0700 [thread overview]
Message-ID: <546ACDBD.9010403@redhat.com> (raw)
In-Reply-To: <1416278986-17320-1-git-send-email-famz@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 557 bytes --]
On 11/17/2014 07:49 PM, Fam Zheng wrote:
> When which(1) is not installed, we complain "perl not found" because
> it's the first set_prog_path check. The error message is misleading.
>
> Fix it by adding a check for which(1) in the beginning.
Why not instead change set_prog_path to use 'command -v' instead of
'which'? As this is a bash script, we shouldn't need to shell out to an
optional package for something we can do natively.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 539 bytes --]
next prev parent reply other threads:[~2014-11-18 4:40 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-18 2:49 [Qemu-trivial] [PATCH] qemu-iotests: Fix error message if which(1) not installed Fam Zheng
2014-11-18 2:49 ` [Qemu-devel] " Fam Zheng
2014-11-18 4:40 ` Eric Blake [this message]
2014-11-18 4:40 ` Eric Blake
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=546ACDBD.9010403@redhat.com \
--to=eblake@redhat.com \
--cc=famz@redhat.com \
--cc=kwolf@redhat.com \
--cc=mjt@tls.msk.ru \
--cc=mreitz@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.