From: Jiang Liu <jiang.liu@linux.intel.com>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: Bjorn Helgaas <bhelgaas@google.com>,
Ingo Molnar <mingo@redhat.com>,
Grant Likely <grant.likely@linaro.org>,
Marc Zyngier <marc.zyngier@arm.com>,
Yijing Wang <wangyijing@huawei.com>,
Yingjoe Chen <yingjoe.chen@mediatek.com>,
Borislav Petkov <bp@alien8.de>, "H. Peter Anvin" <hpa@zytor.com>,
Matthias Brugger <matthias.bgg@gmail.com>,
Tony Luck <tony.luck@intel.com>,
LKML <linux-kernel@vger.kernel.org>,
linux-pci@vger.kernel.org,
LAK <linux-arm-kernel@lists.infradead.org>,
Arnd Bergmann <arnd@arndb.de>
Subject: Re: [Patch V3 0/9] Refine generic/PCI MSI irqodmian interfaces
Date: Tue, 18 Nov 2014 13:08:38 +0800 [thread overview]
Message-ID: <546AD456.3030000@linux.intel.com> (raw)
In-Reply-To: <alpine.DEB.2.11.1411180133130.3909@nanos>
On 2014/11/18 8:59, Thomas Gleixner wrote:
> On Mon, 17 Nov 2014, Jiang Liu wrote:
>> This patch set is based on tip/irq/irqdomain and tries to refine
>> interfaces to support irqdomain for generic MSI and PCI MSI.
>
> So to make progress on that matter I picked that up along with a few
> other patches which affect the core code (more stacked irq callbacks
> and Marcs workaround for the handler assignment issue).
>
> I rebased the whole lot on Bjorns pci/msi branch as discussed in this
> thread: https://lkml.org/lkml/2014/11/16/292
>
> After that I spent quite some time to reorder and fold back patches so
> we have no obvious wreckage, but at the same time preserve at least
> some of the development process for this.
>
> Finally I added docbook comments where missing (please provide them
> next time yourself).
Sure, need improvements on docs.
>
> Marc ran an initial smoketest on an early iteration which did not fall
> into bits and pieces right away.
>
> The only major change is that I got rid of the ugly
>
> #ifndef msi_alloc_info_t
>
> trickery by moving the generic version into include/asm-generic/msi.h
>
> So if you want to use the generic version, you need to create your
> arch/xxx/include/asm/msi.h file which includes asm-generic/msi.h.
>
> For the ones who want to override it, create
> arch/xxx/include/asm/msi.h, include whatever it takes and provide the
> proper typedef.
Two issues are solved by adding new header files, a good technique to
improve code quality:)
>
> I'll send that patch (7bde31a7969f) out tomorrow morning as I want to
> have Arnds blessing for that.
>
<snip>
> I really rely on your cooperation here, as I don't want to end up with
> an unexplainable mess when the stuff hits Linus tree and he starts
> rumaging for his diving harpune ....
I have rebased x86 changes onto tip/irq/irqdomain, it works perfectly:)
Regards!
Gerry
WARNING: multiple messages have this Message-ID (diff)
From: jiang.liu@linux.intel.com (Jiang Liu)
To: linux-arm-kernel@lists.infradead.org
Subject: [Patch V3 0/9] Refine generic/PCI MSI irqodmian interfaces
Date: Tue, 18 Nov 2014 13:08:38 +0800 [thread overview]
Message-ID: <546AD456.3030000@linux.intel.com> (raw)
In-Reply-To: <alpine.DEB.2.11.1411180133130.3909@nanos>
On 2014/11/18 8:59, Thomas Gleixner wrote:
> On Mon, 17 Nov 2014, Jiang Liu wrote:
>> This patch set is based on tip/irq/irqdomain and tries to refine
>> interfaces to support irqdomain for generic MSI and PCI MSI.
>
> So to make progress on that matter I picked that up along with a few
> other patches which affect the core code (more stacked irq callbacks
> and Marcs workaround for the handler assignment issue).
>
> I rebased the whole lot on Bjorns pci/msi branch as discussed in this
> thread: https://lkml.org/lkml/2014/11/16/292
>
> After that I spent quite some time to reorder and fold back patches so
> we have no obvious wreckage, but at the same time preserve at least
> some of the development process for this.
>
> Finally I added docbook comments where missing (please provide them
> next time yourself).
Sure, need improvements on docs.
>
> Marc ran an initial smoketest on an early iteration which did not fall
> into bits and pieces right away.
>
> The only major change is that I got rid of the ugly
>
> #ifndef msi_alloc_info_t
>
> trickery by moving the generic version into include/asm-generic/msi.h
>
> So if you want to use the generic version, you need to create your
> arch/xxx/include/asm/msi.h file which includes asm-generic/msi.h.
>
> For the ones who want to override it, create
> arch/xxx/include/asm/msi.h, include whatever it takes and provide the
> proper typedef.
Two issues are solved by adding new header files, a good technique to
improve code quality:)
>
> I'll send that patch (7bde31a7969f) out tomorrow morning as I want to
> have Arnds blessing for that.
>
<snip>
> I really rely on your cooperation here, as I don't want to end up with
> an unexplainable mess when the stuff hits Linus tree and he starts
> rumaging for his diving harpune ....
I have rebased x86 changes onto tip/irq/irqdomain, it works perfectly:)
Regards!
Gerry
next prev parent reply other threads:[~2014-11-18 5:08 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-17 11:03 [Patch V3 0/9] Refine generic/PCI MSI irqodmian interfaces Jiang Liu
2014-11-17 11:03 ` Jiang Liu
2014-11-17 11:03 ` [Patch V3 1/9] PCI, MSI: Fix errors caused by commit e5f1a59c4e12 Jiang Liu
2014-11-17 11:03 ` Jiang Liu
2014-11-17 11:03 ` [Patch V3 2/9] irqdomain: Use consistent prototype for irq_domain_free_irqs_* Jiang Liu
2014-11-17 11:03 ` Jiang Liu
2014-11-17 11:03 ` [Patch V3 3/9] irqdomain: Implement a method to automatically call parent domain's alloc/free Jiang Liu
2014-11-17 11:03 ` Jiang Liu
2014-11-17 11:03 ` [Patch V3 4/9] irqdomain: Introduce helper function irq_domain_add_hierarchy() Jiang Liu
2014-11-17 11:03 ` Jiang Liu
2014-11-17 11:03 ` [Patch V3 5/9] PCI, MSI: Introduce helpers to hide struct msi_desc implementation details Jiang Liu
2014-11-17 11:03 ` Jiang Liu
2014-11-17 11:03 ` [Patch V3 6/9] genirq: Introduce msi_domain_{alloc|free}_irqs() Jiang Liu
2014-11-17 11:03 ` Jiang Liu
2014-11-17 11:30 ` Thomas Gleixner
2014-11-17 11:30 ` Thomas Gleixner
2014-11-17 11:37 ` Jiang Liu
2014-11-17 11:37 ` Jiang Liu
2014-11-17 11:03 ` [Patch V3 7/9] genirq: Provide default callbacks for msi_domain_ops Jiang Liu
2014-11-17 11:03 ` Jiang Liu
2014-11-17 11:03 ` [Patch V3 8/9] PCI, MSI: Refine irqdomain interfaces to simplify its usage Jiang Liu
2014-11-17 11:03 ` Jiang Liu
2014-11-17 11:03 ` [Patch V3 9/9] PCI, MSI: Provide mechanism to alloc/free MSI/MSIX interrupt from irqdomain Jiang Liu
2014-11-17 11:03 ` Jiang Liu
2014-11-18 0:59 ` [Patch V3 0/9] Refine generic/PCI MSI irqodmian interfaces Thomas Gleixner
2014-11-18 0:59 ` Thomas Gleixner
2014-11-18 5:08 ` Jiang Liu [this message]
2014-11-18 5:08 ` Jiang Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=546AD456.3030000@linux.intel.com \
--to=jiang.liu@linux.intel.com \
--cc=arnd@arndb.de \
--cc=bhelgaas@google.com \
--cc=bp@alien8.de \
--cc=grant.likely@linaro.org \
--cc=hpa@zytor.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=marc.zyngier@arm.com \
--cc=matthias.bgg@gmail.com \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=tony.luck@intel.com \
--cc=wangyijing@huawei.com \
--cc=yingjoe.chen@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.