From: Paolo Bonzini <pbonzini@redhat.com>
To: Ming Lei <ming.lei@canonical.com>,
qemu-devel@nongnu.org, Peter Maydell <peter.maydell@linaro.org>,
Stefan Hajnoczi <stefanha@redhat.com>,
Kevin Wolf <kwolf@redhat.com>
Cc: "Benoît Canet" <benoit.canet@irqsave.net>
Subject: Re: [Qemu-devel] [PATCH v3 3/3] linux-aio: remove 'node' from 'struct qemu_laiocb'
Date: Tue, 18 Nov 2014 15:06:40 +0100 [thread overview]
Message-ID: <546B5270.5080402@redhat.com> (raw)
In-Reply-To: <1415286601-30715-4-git-send-email-ming.lei@canonical.com>
On 06/11/2014 16:10, Ming Lei wrote:
> No one uses the 'node' field any more, so remove it
> from 'struct qemu_laiocb', and this can save 16byte
> for the struct on 64bit arch.
>
> Signed-off-by: Ming Lei <ming.lei@canonical.com>
> ---
> block/linux-aio.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/block/linux-aio.c b/block/linux-aio.c
> index f5ca41d..b12da25 100644
> --- a/block/linux-aio.c
> +++ b/block/linux-aio.c
> @@ -35,7 +35,6 @@ struct qemu_laiocb {
> size_t nbytes;
> QEMUIOVector *qiov;
> bool is_read;
> - QLIST_ENTRY(qemu_laiocb) node;
> };
>
> /*
>
Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>
prev parent reply other threads:[~2014-11-18 14:07 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-06 15:09 [Qemu-devel] [PATCH v3 0/3] linux-aio: fix batch submission Ming Lei
2014-11-06 15:09 ` [Qemu-devel] [PATCH v3 1/3] linux-aio: fix submit aio as a batch Ming Lei
2014-11-18 14:18 ` Paolo Bonzini
2014-11-22 12:16 ` Ming Lei
2014-11-24 9:47 ` Paolo Bonzini
2014-11-24 10:02 ` Ming Lei
2014-11-24 10:09 ` Paolo Bonzini
2014-11-06 15:10 ` [Qemu-devel] [PATCH v3 2/3] linux-aio: handling -EAGAIN for !s->io_q.plugged case Ming Lei
2014-11-18 14:06 ` Paolo Bonzini
2014-11-22 12:24 ` Ming Lei
2014-11-24 9:52 ` Paolo Bonzini
2014-11-24 10:11 ` Ming Lei
2014-11-24 10:48 ` Paolo Bonzini
2014-11-06 15:10 ` [Qemu-devel] [PATCH v3 3/3] linux-aio: remove 'node' from 'struct qemu_laiocb' Ming Lei
2014-11-18 14:06 ` Paolo Bonzini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=546B5270.5080402@redhat.com \
--to=pbonzini@redhat.com \
--cc=benoit.canet@irqsave.net \
--cc=kwolf@redhat.com \
--cc=ming.lei@canonical.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.