From: Paolo Bonzini <pbonzini@redhat.com>
To: Ming Lei <ming.lei@canonical.com>
Cc: "Kevin Wolf" <kwolf@redhat.com>,
"Peter Maydell" <peter.maydell@linaro.org>,
"Benoît Canet" <benoit.canet@irqsave.net>,
qemu-devel <qemu-devel@nongnu.org>,
"Stefan Hajnoczi" <stefanha@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v3 1/3] linux-aio: fix submit aio as a batch
Date: Mon, 24 Nov 2014 10:47:01 +0100 [thread overview]
Message-ID: <5472FE95.1090503@redhat.com> (raw)
In-Reply-To: <CACVXFVMZLNQCLWp4pcG18OpNzuf6PS691uVtcbRuuy8=LA3Tyg@mail.gmail.com>
On 22/11/2014 13:16, Ming Lei wrote:
> > > +static int ioq_enqueue(struct qemu_laio_state *s, struct iocb *iocb)
> > > {
> > > unsigned int idx = s->io_q.idx;
> > >
> > > + if (unlikely(idx == s->io_q.size)) {
> > > + return -1;
> >
> > return -EAGAIN?
>
> It means the io queue is full, so the code has to fail the current
> request.
Right, but "-1" is "-EPERM" which doesn't make much sense. I think the
right thing to do is to return EAGAIN, and let the owner figure it out.
For example, a SCSI device might return a "BUSY" status code.
Paolo
next prev parent reply other threads:[~2014-11-24 9:47 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-06 15:09 [Qemu-devel] [PATCH v3 0/3] linux-aio: fix batch submission Ming Lei
2014-11-06 15:09 ` [Qemu-devel] [PATCH v3 1/3] linux-aio: fix submit aio as a batch Ming Lei
2014-11-18 14:18 ` Paolo Bonzini
2014-11-22 12:16 ` Ming Lei
2014-11-24 9:47 ` Paolo Bonzini [this message]
2014-11-24 10:02 ` Ming Lei
2014-11-24 10:09 ` Paolo Bonzini
2014-11-06 15:10 ` [Qemu-devel] [PATCH v3 2/3] linux-aio: handling -EAGAIN for !s->io_q.plugged case Ming Lei
2014-11-18 14:06 ` Paolo Bonzini
2014-11-22 12:24 ` Ming Lei
2014-11-24 9:52 ` Paolo Bonzini
2014-11-24 10:11 ` Ming Lei
2014-11-24 10:48 ` Paolo Bonzini
2014-11-06 15:10 ` [Qemu-devel] [PATCH v3 3/3] linux-aio: remove 'node' from 'struct qemu_laiocb' Ming Lei
2014-11-18 14:06 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5472FE95.1090503@redhat.com \
--to=pbonzini@redhat.com \
--cc=benoit.canet@irqsave.net \
--cc=kwolf@redhat.com \
--cc=ming.lei@canonical.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.